Minor include sanity in WebPage.h
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Apr 2014 21:53:51 +0000 (21:53 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Apr 2014 21:53:51 +0000 (21:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131752

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.h:
Remove a bunch of unnecessary includes.
Un-indent some stuff.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/FindController.cpp:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/WebPageMac.mm:
Add back more specific includes, into implementation files.

* WebProcess/WebPage/WebUndoStep.cpp:
(WebKit::WebUndoStep::~WebUndoStep):
* WebProcess/WebPage/WebUndoStep.h:
Add an out-of-line destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/Shared/LayerTreeContext.h
Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Source/WebKit2/WebProcess/WebPage/FindController.cpp
Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Source/WebKit2/WebProcess/WebPage/WebPage.h
Source/WebKit2/WebProcess/WebPage/WebUndoStep.cpp
Source/WebKit2/WebProcess/WebPage/WebUndoStep.h
Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm

index e34f3b1..87381ba 100644 (file)
@@ -1,3 +1,26 @@
+2014-04-16  Tim Horton  <timothy_horton@apple.com>
+
+        Minor include sanity in WebPage.h
+        https://bugs.webkit.org/show_bug.cgi?id=131752
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/WebPage.h:
+        Remove a bunch of unnecessary includes.
+        Un-indent some stuff.
+
+        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebProcess/WebPage/FindController.cpp:
+        * WebProcess/WebPage/WebPage.cpp:
+        * WebProcess/WebPage/mac/WebPageMac.mm:
+        Add back more specific includes, into implementation files.
+        
+        * WebProcess/WebPage/WebUndoStep.cpp:
+        (WebKit::WebUndoStep::~WebUndoStep):
+        * WebProcess/WebPage/WebUndoStep.h:
+        Add an out-of-line destructor.
+
 2014-04-16  Gavin Barraclough  <baraclough@apple.com>
 
         REGRESSION: PCE.js is 20x slower in WebKit2 because timers are throttled
index 62c357c..7f033d4 100644 (file)
@@ -29,8 +29,8 @@
 #include <stdint.h>
 
 namespace IPC {
-    class ArgumentDecoder;
-    class ArgumentEncoder;
+class ArgumentDecoder;
+class ArgumentEncoder;
 }
 
 namespace WebKit {
index cf6d222..3b88433 100644 (file)
@@ -34,6 +34,7 @@
 #include "WebPageProxy.h"
 #include "WebPageProxyMessages.h"
 #include "WebProcess.h"
+#include "WebUndoStep.h"
 #include <WebCore/ArchiveResource.h>
 #include <WebCore/DocumentFragment.h>
 #include <WebCore/FocusController.h>
index 315de5e..3de2186 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "AuthenticationManager.h"
 #include "DataReference.h"
+#include "DrawingArea.h"
 #include "InjectedBundle.h"
 #include "InjectedBundleBackForwardListItem.h"
 #include "InjectedBundleDOMWindowExtension.h"
index de52ed7..1d994a0 100644 (file)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "FindController.h"
 
+#include "DrawingArea.h"
 #include "PluginView.h"
 #include "ShareableBitmap.h"
 #include "WKPage.h"
index 372ffd4..af53486 100644 (file)
@@ -90,6 +90,7 @@
 #include "WebProcess.h"
 #include "WebProcessProxyMessages.h"
 #include "WebProgressTrackerClient.h"
+#include "WebUndoStep.h"
 #include <JavaScriptCore/APICast.h>
 #include <WebCore/ArchiveResource.h>
 #include <WebCore/Chrome.h>
index 62033e3..49afcca 100644 (file)
@@ -29,7 +29,6 @@
 #include "APIInjectedBundleFormClient.h"
 #include "APIInjectedBundlePageUIClient.h"
 #include "APIObject.h"
-#include "DrawingArea.h"
 #include "FindController.h"
 #include "GeolocationPermissionRequestManager.h"
 #include "ImageOptions.h"
 #include "InjectedBundlePageLoaderClient.h"
 #include "InjectedBundlePagePolicyClient.h"
 #include "InjectedBundlePageResourceLoadClient.h"
+#include "LayerTreeHost.h"
 #include "MessageReceiver.h"
 #include "MessageSender.h"
 #include "PageOverlayController.h"
 #include "Plugin.h"
 #include "SandboxExtension.h"
 #include "ShareableBitmap.h"
-#include "TapHighlightController.h"
-#include "WebUndoStep.h"
-#include <WebCore/ContextMenuItem.h>
 #include <WebCore/DictationAlternative.h>
 #include <WebCore/DragData.h>
 #include <WebCore/Editor.h>
@@ -55,7 +52,6 @@
 #include <WebCore/IntRect.h>
 #include <WebCore/Page.h>
 #include <WebCore/PageVisibilityState.h>
-#include <WebCore/PlatformScreen.h>
 #include <WebCore/ScrollTypes.h>
 #include <WebCore/TextChecking.h>
 #include <WebCore/UserActivity.h>
@@ -95,8 +91,6 @@
 #endif
 
 #if PLATFORM(COCOA)
-#include "DictionaryPopupInfo.h"
-#include "LayerHostingContext.h"
 #include "ViewGestureGeometryCollector.h"
 #include <wtf/RetainPtr.h>
 OBJC_CLASS CALayer;
@@ -112,29 +106,29 @@ class Array;
 }
 
 namespace IPC {
-    class ArgumentDecoder;
-    class Connection;
+class ArgumentDecoder;
+class Connection;
 }
 
 namespace WebCore {
-    class DocumentLoader;
-    class GraphicsContext;
-    class Frame;
-    class FrameView;
-    class HTMLPlugInElement;
-    class IntPoint;
-    class KeyboardEvent;
-    class Page;
-    class PrintContext;
-    class Range;
-    class ResourceResponse;
-    class ResourceRequest;
-    class SharedBuffer;
-    class SubstituteData;
-    class TextCheckingRequest;
-    class VisibleSelection;
-    struct KeypressCommand;
-    struct TextCheckingResult;
+class DocumentLoader;
+class GraphicsContext;
+class Frame;
+class FrameView;
+class HTMLPlugInElement;
+class IntPoint;
+class KeyboardEvent;
+class Page;
+class PrintContext;
+class Range;
+class ResourceResponse;
+class ResourceRequest;
+class SharedBuffer;
+class SubstituteData;
+class TextCheckingRequest;
+class VisibleSelection;
+struct KeypressCommand;
+struct TextCheckingResult;
 }
 
 namespace WebKit {
@@ -162,6 +156,7 @@ class WebNotificationClient;
 class WebOpenPanelResultListener;
 class WebPageGroupProxy;
 class WebPopupMenu;
+class WebUndoStep;
 class WebVideoFullscreenManager;
 class WebWheelEvent;
 struct AssistedNodeInformation;
index 7b41c5a..b005e08 100644 (file)
@@ -39,4 +39,8 @@ PassRefPtr<WebUndoStep> WebUndoStep::create(PassRefPtr<WebCore::UndoStep> step)
     return adoptRef(new WebUndoStep(step, generateUndoStep()));
 }
 
+WebUndoStep::~WebUndoStep()
+{
+}
+
 } // namespace WebKit
index 745377a..6f49c29 100644 (file)
@@ -35,6 +35,7 @@ namespace WebKit {
 class WebUndoStep : public RefCounted<WebUndoStep> {
 public:
     static PassRefPtr<WebUndoStep> create(PassRefPtr<WebCore::UndoStep>);
+    ~WebUndoStep();
 
     WebCore::UndoStep* step() const { return m_step.get(); }
     uint64_t stepID() const { return m_stepID; }
index 317736e..eaaebc9 100644 (file)
@@ -30,6 +30,7 @@
 
 #import "AssistedNodeInformation.h"
 #import "DataReference.h"
+#import "DrawingArea.h"
 #import "EditingRange.h"
 #import "EditorState.h"
 #import "GestureTypes.h"
index 7487bfe..9d6158b 100644 (file)
@@ -30,6 +30,7 @@
 
 #import "AttributedString.h"
 #import "DataReference.h"
+#import "DictionaryPopupInfo.h"
 #import "EditingRange.h"
 #import "EditorState.h"
 #import "PDFKitImports.h"