[Xcode] ICU headers aren’t treated as system headers after r219155
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 9 Jul 2017 20:19:47 +0000 (20:19 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 9 Jul 2017 20:19:47 +0000 (20:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=174299

Reviewed by Sam Weinig.

* Configurations/JavaScriptCore.xcconfig: Pass --system-header-prefix=unicode/ to the C and
  C++ compilers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
Source/JavaScriptCore/runtime/IntlCollator.cpp
Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp
Source/JavaScriptCore/runtime/JSGlobalObject.cpp
Source/JavaScriptCore/runtime/StringPrototype.cpp

index 038c584..70217e3 100644 (file)
@@ -1,3 +1,18 @@
+2017-07-09  Dan Bernstein  <mitz@apple.com>
+
+        [Xcode] ICU headers aren’t treated as system headers after r219155
+        https://bugs.webkit.org/show_bug.cgi?id=174299
+
+        Reviewed by Sam Weinig.
+
+        * Configurations/JavaScriptCore.xcconfig: Pass --system-header-prefix=unicode/ to the C and
+          C++ compilers.
+
+* runtime/IntlCollator.cpp: Removed documentation warning suppression.
+        * runtime/IntlDateTimeFormat.cpp: Ditto.
+        * runtime/JSGlobalObject.cpp: Ditto.
+        * runtime/StringPrototype.cpp: Ditto.
+
 2017-07-09  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         [JSC] Use fastMalloc / fastFree for STL containers
index 47b0285..5dbc528 100644 (file)
@@ -47,6 +47,8 @@ SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,JavaScriptCore.order;
 
 GCC_PREFIX_HEADER = JavaScriptCorePrefix.h;
 GCC_SYMBOLS_PRIVATE_EXTERN = YES;
+OTHER_CFLAGS = $(inherited) --system-header-prefix=unicode/;
+OTHER_CPLUSPLUSFLAGS = $(inherited) --system-header-prefix=unicode/;
 HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore" $(HEADER_SEARCH_PATHS);
 INFOPLIST_FILE = Info.plist;
 INSTALL_PATH = $(JAVASCRIPTCORE_FRAMEWORKS_DIR);
index 790dcf9..7cbe54e 100644 (file)
 #include "ObjectConstructor.h"
 #include "SlotVisitorInlines.h"
 #include "StructureInlines.h"
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
 #include <unicode/ucol.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
 #include <wtf/unicode/Collator.h>
 
 namespace JSC {
index dddb3e5..01f240b 100644 (file)
 #include "JSCInlines.h"
 #include "ObjectConstructor.h"
 #include <unicode/ucal.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
 #include <unicode/udatpg.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
 #include <unicode/uenum.h>
 #include <wtf/text/StringBuilder.h>
 
index 7bf1894..f7cf4ae 100644 (file)
 
 #if ENABLE(INTL)
 #include "IntlObject.h"
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
 #include <unicode/ucol.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
 #include <unicode/udat.h>
 #include <unicode/unum.h>
 #endif // ENABLE(INTL)
index fbbc3f3..68a010c 100644 (file)
 #include "SuperSampler.h"
 #include <algorithm>
 #include <unicode/uconfig.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
 #include <unicode/unorm.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
 #include <unicode/ustring.h>
 #include <wtf/ASCIICType.h>
 #include <wtf/MathExtras.h>