LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Jul 2006 19:45:31 +0000 (19:45 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Jul 2006 19:45:31 +0000 (19:45 +0000)
        Reviewed by Geoff (well, half of it at least).

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9788
          storage leaks in Objective-C tests

        * plugins/jsobjc-simple.html: Add an autorelease to fix a storage leak.

WebKitTools:

        Reviewed by Geoff (well, half of it at least).

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9788
          storage leaks in Objective-C tests

        * DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController keepWebHistory]):
        * DumpRenderTree/ObjCPlugin.m: (-[ObjCPlugin removeBridgeRestrictions:]):
        Add a release to fix a storage leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/plugins/jsobjc-simple.html
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.m
WebKitTools/DumpRenderTree/ObjCPlugin.m

index 22c15c6..2b06d73 100644 (file)
@@ -1,5 +1,14 @@
 2006-07-08  Darin Adler  <darin@apple.com>
 
+        Reviewed by Geoff (well, half of it at least).
+
+        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9788
+          storage leaks in Objective-C tests
+
+        * plugins/jsobjc-simple.html: Add an autorelease to fix a storage leak.
+
+2006-07-08  Darin Adler  <darin@apple.com>
+
         - clear up a few minor housekeeping problems
 
         * fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Added.
index 087c0fb..1c4d81e 100644 (file)
@@ -19,7 +19,7 @@ function test() {
     // test creating an obj-c object
     var NSCell = objc('NSCell');
     print('got class: ' + NSCell);
-    var cell = NSCell.alloc().init();
+    var cell = NSCell.alloc().init().autorelease();
     print('created object: <' + cell.className() + '>');
     cell.setValue_forKey_('zoe', 'stringValue');
     print('set string value: ' + cell.stringValue());
index 0994f35..4955e0b 100644 (file)
@@ -1,5 +1,16 @@
 2006-07-08  Darin Adler  <darin@apple.com>
 
+        Reviewed by Geoff (well, half of it at least).
+
+        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9788
+          storage leaks in Objective-C tests
+
+        * DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController keepWebHistory]):
+        * DumpRenderTree/ObjCPlugin.m: (-[ObjCPlugin removeBridgeRestrictions:]):
+        Add a release to fix a storage leak.
+
+2006-07-08  Darin Adler  <darin@apple.com>
+
         * Scripts/do-webcore-rename: A few more.
 
 2006-07-08  Darin Adler  <darin@apple.com>
index d2c6ba2..c2eb6eb 100644 (file)
@@ -633,8 +633,11 @@ static void dump(void)
 
 - (void)keepWebHistory
 {
-    if (![WebHistory optionalSharedHistory])
-        [WebHistory setOptionalSharedHistory:[[WebHistory alloc] init]];
+    if (![WebHistory optionalSharedHistory]) {
+        WebHistory *history = [[WebHistory alloc] init];
+        [WebHistory setOptionalSharedHistory:history];
+        [history release];
+    }
 }
 
 - (void)waitUntilDone 
index 7ea5198..199e895 100644 (file)
@@ -149,7 +149,9 @@ static BOOL _allowsScriptsFullAccess = NO;
     [NSObject setAllowsScriptsFullAccess:YES];
     
     // store a JSObjC instance into the provided container
-    [container setValue:[[JSObjC alloc] init] forKey:@"objc"];
+    JSObjC *objc = [[JSObjC alloc] init];
+    [container setValue:objc forKey:@"objc"];
+    [objc release];
 }
 
 @end