Some WeakPtr typedef cleanup
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 31 May 2019 21:56:37 +0000 (21:56 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 31 May 2019 21:56:37 +0000 (21:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198431

Reviewed by Chris Dumez.

Use "using" instead of "typedef", since using is preferred in C++ for
better compatibility with templates.

Source/WebCore:

* Modules/indexeddb/shared/InProcessIDBServer.h:
* html/HTMLMediaElement.h:
* platform/ScrollView.h:

Source/WebKit:

* UIProcess/WebAuthentication/AuthenticatorManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h
Source/WebCore/html/HTMLMediaElement.h
Source/WebCore/platform/ScrollView.h
Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h

index f7c24b5..6d41d46 100644 (file)
@@ -1,3 +1,17 @@
+2019-05-31  Geoffrey Garen  <ggaren@apple.com>
+
+        Some WeakPtr typedef cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=198431
+
+        Reviewed by Chris Dumez.
+
+        Use "using" instead of "typedef", since using is preferred in C++ for
+        better compatibility with templates.
+
+        * Modules/indexeddb/shared/InProcessIDBServer.h:
+        * html/HTMLMediaElement.h:
+        * platform/ScrollView.h:
+
 2019-05-31  Andres Gonzalez  <andresg_22@apple.com>
 
         Inserting a newline in contenteditable causes two characters to be added instead of one
index 6f5fbef..26abe64 100644 (file)
@@ -54,7 +54,7 @@ class IDBServer;
 class InProcessIDBServer final : public IDBClient::IDBConnectionToServerDelegate, public IDBServer::IDBConnectionToClientDelegate, public RefCounted<InProcessIDBServer>, public IDBServer::IDBBackingStoreTemporaryFileHandler {
 public:
     using IDBClient::IDBConnectionToServerDelegate::weakPtrFactory;
-    typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;
+    using WeakValueType = IDBClient::IDBConnectionToServerDelegate::WeakValueType;
 
     WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID);
     WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
index ed88e3c..b6d1809 100644 (file)
@@ -149,7 +149,7 @@ class HTMLMediaElement
 {
     WTF_MAKE_ISO_ALLOCATED(HTMLMediaElement);
 public:
-    typedef HTMLElement::WeakValueType WeakValueType;
+    using WeakValueType = HTMLElement::WeakValueType;
     using HTMLElement::weakPtrFactory;
 
     RefPtr<MediaPlayer> player() const { return m_player; }
index d847a20..ff82c27 100644 (file)
@@ -65,7 +65,7 @@ class ScrollView : public Widget, public ScrollableArea {
 public:
     virtual ~ScrollView();
 
-    typedef Widget::WeakValueType WeakValueType;
+    using WeakValueType = Widget::WeakValueType;
     using Widget::weakPtrFactory;
 
     // ScrollableArea functions.
index 061a1e7..310c5b0 100644 (file)
@@ -1,3 +1,15 @@
+2019-05-31  Geoffrey Garen  <ggaren@apple.com>
+
+        Some WeakPtr typedef cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=198431
+
+        Reviewed by Chris Dumez.
+
+        Use "using" instead of "typedef", since using is preferred in C++ for
+        better compatibility with templates.
+
+        * UIProcess/WebAuthentication/AuthenticatorManager.h:
+
 2019-05-31  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r245953.
index ce06c50..3ad4c9b 100644 (file)
@@ -49,7 +49,7 @@ public:
     using TransportSet = HashSet<WebCore::AuthenticatorTransport, WTF::IntHash<WebCore::AuthenticatorTransport>, WTF::StrongEnumHashTraits<WebCore::AuthenticatorTransport>>;
 
     using AuthenticatorTransportService::Observer::weakPtrFactory;
-    typedef AuthenticatorTransportService::Observer::WeakValueType WeakValueType;
+    using WeakValueType = AuthenticatorTransportService::Observer::WeakValueType;
 
     AuthenticatorManager();
     virtual ~AuthenticatorManager() = default;