Web Inspector: Worker imported scripts not showing up in Open Quickly dialog if inspe...
authorpecoraro@apple.com <pecoraro@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 23:44:07 +0000 (23:44 +0000)
committerpecoraro@apple.com <pecoraro@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 23:44:07 +0000 (23:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196986

Reviewed by Devin Rousso.

* UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._addScriptsForTarget):
We were unnecessary skipping Scripts that do not have a sourceURL but do
have a URL, which ends up being Worker populated scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js

index adb8fe4..61ff4d8 100644 (file)
@@ -1,5 +1,17 @@
 2019-04-16  Joseph Pecoraro  <pecoraro@apple.com>
 
+        Web Inspector: Worker imported scripts not showing up in Open Quickly dialog if inspector open after workers exist
+        https://bugs.webkit.org/show_bug.cgi?id=196986
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/OpenResourceDialog.js:
+        (WI.OpenResourceDialog.prototype._addScriptsForTarget):
+        We were unnecessary skipping Scripts that do not have a sourceURL but do
+        have a URL, which ends up being Worker populated scripts.
+
+2019-04-16  Joseph Pecoraro  <pecoraro@apple.com>
+
         REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Network Tab
         https://bugs.webkit.org/show_bug.cgi?id=193505
         <rdar://problem/47325957>
index 7e606e6..7e5984e 100644 (file)
@@ -327,7 +327,7 @@ WI.OpenResourceDialog = class OpenResourceDialog extends WI.Dialog
                 continue;
             if (script.dynamicallyAddedScriptElement)
                 continue;
-            if (!script.sourceURL || isWebKitInternalScript(script.sourceURL) || isWebInspectorConsoleEvaluationScript(script.sourceURL))
+            if (isWebKitInternalScript(script.sourceURL) || isWebInspectorConsoleEvaluationScript(script.sourceURL))
                 continue;
             this._addResource(script, suppressFilterUpdate);
         }