[Immediate Actions] Should re-enable immediate actions for iBooks
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Mar 2015 21:23:21 +0000 (21:23 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Mar 2015 21:23:21 +0000 (21:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142915
-and corresponding-
rdar://problem/19585689

Reviewed by Tim Horton.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processPool:configuration:webView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/mac/WKView.mm

index 959c710..23414be 100644 (file)
@@ -1,3 +1,15 @@
+2015-03-20  Beth Dakin  <bdakin@apple.com>
+
+        [Immediate Actions] Should re-enable immediate actions for iBooks
+        https://bugs.webkit.org/show_bug.cgi?id=142915
+        -and corresponding-
+        rdar://problem/19585689
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView initWithFrame:processPool:configuration:webView:]):
+
 2015-03-20  Alex Christensen  <achristensen@webkit.org>
 
         Progress towards CMake on Mac.
index ea4da95..6f2fb04 100644 (file)
@@ -3724,9 +3724,7 @@ static NSString *pathWithUniqueFilenameForPath(NSString *path)
         self._actionMenu.autoenablesItems = NO;
     }
 
-    // FIXME: We should not permanently disable this for iBooks. rdar://problem/19585689
-    Class gestureClass = NSClassFromString(@"NSImmediateActionGestureRecognizer");
-    if (gestureClass && !applicationIsIBooks()) {
+    if (Class gestureClass = NSClassFromString(@"NSImmediateActionGestureRecognizer")) {
         _data->_immediateActionGestureRecognizer = adoptNS([(NSImmediateActionGestureRecognizer *)[gestureClass alloc] initWithTarget:nil action:NULL]);
         _data->_immediateActionController = adoptNS([[WKImmediateActionController alloc] initWithPage:*_data->_page view:self recognizer:_data->_immediateActionGestureRecognizer.get()]);
         [_data->_immediateActionGestureRecognizer setDelegate:_data->_immediateActionController.get()];