[GTK] fast/events/page-visibility-transition-test.html is timing out
authormrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 May 2015 00:57:01 +0000 (00:57 +0000)
committermrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 May 2015 00:57:01 +0000 (00:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

Tools:

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.

LayoutTests:

* platform/gtk/TestExpectations: Unskip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@184060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Tools/ChangeLog
Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp

index 70a1270..5d14a47 100644 (file)
@@ -1,3 +1,12 @@
+2015-05-10  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] fast/events/page-visibility-transition-test.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=114789
+
+        Reviewed by Darin Adler.
+
+        * platform/gtk/TestExpectations: Unskip failing tests.
+
 2015-05-10  Chris Fleizach  <cfleizach@apple.com>
 
         AX: Don't expose elements as data tables just because they use display: table
index 7eb2145..6f0517e 100644 (file)
@@ -2270,12 +2270,6 @@ webkit.org/b/144765 fast/events/touch/touch-inside-iframe-scrolled.html [ Failur
 webkit.org/b/144765 fast/events/touch/touch-slider-no-js-touch-listener.html [ Failure ]
 webkit.org/b/144765 fast/events/touch/touch-inside-iframe.html [ Timeout ]
 
-# Need support for adjusting page visibility in the test harness.
-webkit.org/b/114789 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-propagation-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-transition-test.html [ Timeout ]
-
 webkit.org/b/144763 fast/events/scroll-in-scaled-page-with-overflow-hidden.html
 
 #////////////////////////////////////////////////////////////////////////////////////////
index 5ef4695..7c7f27b 100644 (file)
@@ -1,3 +1,14 @@
+2015-05-10  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] fast/events/page-visibility-transition-test.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=114789
+
+        Reviewed by Darin Adler.
+
+        * WebKitTestRunner/gtk/TestControllerGtk.cpp:
+        (WTR::TestController::setHidden): Map and unmap the WebView when the harness
+        requests visibility changes.
+
 2015-05-10  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
index f242e96..80f6c22 100644 (file)
@@ -95,9 +95,14 @@ void TestController::platformInitializeContext()
 {
 }
 
-void TestController::setHidden(bool)
+void TestController::setHidden(bool hidden)
 {
-    // FIXME: Need to implement this to test visibilityState.
+    if (!m_mainWebView)
+        return;
+    if (hidden)
+        gtk_widget_unmap(GTK_WIDGET(m_mainWebView->platformView()));
+    else
+        gtk_widget_map(GTK_WIDGET(m_mainWebView->platformView()));
 }
 
 void TestController::runModal(PlatformWebView*)