Do not run binding tests on multiple EWSes
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Oct 2017 21:56:51 +0000 (21:56 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Oct 2017 21:56:51 +0000 (21:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=178599

Reviewed by Alexey Proskuryakov.

Remove old code which runs bindings tests and ignore it's result. We now have
a dedicated bindings test EWS.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run): Removed bindings tests code.
* Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
(RunTestsTest.test_webkit_run_unit_tests): Ditto.
* Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
* Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/tool/commands/download_unittest.py
Tools/Scripts/webkitpy/tool/steps/runtests.py
Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py
Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

index 30c1321..3ad10f7 100644 (file)
@@ -1,3 +1,20 @@
+2017-10-20  Aakash Jain  <aakash_jain@apple.com>
+
+        Do not run binding tests on multiple EWSes
+        https://bugs.webkit.org/show_bug.cgi?id=178599
+
+        Reviewed by Alexey Proskuryakov. 
+
+        Remove old code which runs bindings tests and ignore it's result. We now have
+        a dedicated bindings test EWS.
+
+        * Scripts/webkitpy/tool/steps/runtests.py:
+        (RunTests.run): Removed bindings tests code.
+        * Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
+        (RunTestsTest.test_webkit_run_unit_tests): Ditto.
+        * Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
+        * Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.
+
 2017-10-20  Youenn Fablet  <youenn@apple.com>
 
         WebsiteDataStoreCustomPaths.mm is failing after r223718
index 0ea78cd..aa8cafc 100644 (file)
@@ -103,7 +103,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 """
         self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_logs=expected_logs)
@@ -144,7 +143,6 @@ Message2."
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Updating bug 50000
@@ -171,8 +169,6 @@ Running Perl unit tests
 MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
 Running JavaScriptCore tests
 MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
 Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--quiet'], cwd=/mock-checkout
 Committed r49824: <https://trac.webkit.org/changeset/49824>
@@ -190,7 +186,6 @@ No bug id provided.
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Updating bug 50000
@@ -221,7 +216,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
@@ -238,7 +232,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
@@ -248,7 +241,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
@@ -265,7 +257,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
@@ -275,7 +266,6 @@ Building WebKit
 Running Python unit tests
 Running Perl unit tests
 Running JavaScriptCore tests
-Running bindings generation tests
 Running run-webkit-tests
 Committed r49824: <https://trac.webkit.org/changeset/49824>
 Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
index 1aee712..c8359d2 100644 (file)
@@ -104,15 +104,6 @@ class RunTests(AbstractStep):
                 _log.info("Running JavaScriptCore tests")
                 self._tool.executive.run_and_throw_if_fail(javascriptcore_tests_command, quiet=True, cwd=self._tool.scm().checkout_root)
 
-        bindings_tests_command = self._tool.deprecated_port().run_bindings_tests_command()
-        if bindings_tests_command:
-            _log.info("Running bindings generation tests")
-            args = bindings_tests_command
-            try:
-                self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
-            except ScriptError, e:
-                _log.info("Error running run-bindings-tests: %s" % e.message_with_output())
-
         _log.info("Running run-webkit-tests")
         self._run_webkit_tests()
 
index d4d9964..9fad327 100644 (file)
@@ -43,15 +43,11 @@ class RunTestsTest(unittest.TestCase):
         step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False, build_style="release", iterate_on_new_tests=0, group=None))
 
         if sys.platform != "cygwin":
-            expected_logs = """Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
-Running run-webkit-tests
+            expected_logs = """Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-tests'], cwd=/mock-checkout
 """
         else:
-            expected_logs = """Running bindings generation tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
-Running run-webkit-tests
+            expected_logs = """Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--no-build'], cwd=/mock-checkout
 """
 
index 78d0fcd..6fc41ea 100644 (file)
@@ -124,8 +124,6 @@ Running Perl unit tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
 Running JavaScriptCore tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
 Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--release', '--quiet'], cwd=/mock-checkout
 """
@@ -146,8 +144,6 @@ Running Perl unit tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
 Running JavaScriptCore tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast'], cwd=/mock-checkout
-Running bindings generation tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
 Running run-webkit-tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--debug', '--quiet'], cwd=/mock-checkout
 """