Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a...

https://bugs.webkit.org/show_bug.cgi?id=118505

Reviewed by Joseph Pecoraro.

* Scripts/valgrind/suppressions.txt:
* Scripts/webkitpy/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index c62a0a7..42d6f01 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2017-11-28  Alexey Proskuryakov  <ap@apple.com>
+
+        Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
+        https://bugs.webkit.org/show_bug.cgi?id=118505
+
+        Reviewed by Joseph Pecoraro.
+
+        * Scripts/valgrind/suppressions.txt:
+        * Scripts/webkitpy/port/leakdetector.py:
+        (LeakDetector._callstacks_to_exclude_from_leaks):
+
 2017-11-28  Ms2ger  <Ms2ger@igalia.com>
 
         Stop modifying self.expectations in TestExpectationLine.expected_behavior.

diff --git a/Tools/Scripts/valgrind/suppressions.txt b/Tools/Scripts/valgrind/suppressions.txt
index 2edabd1..a6a0571 100644 (file)
--- a/Tools/Scripts/valgrind/suppressions.txt
+++ b/Tools/Scripts/valgrind/suppressions.txt
@@ -594,8 +594,6 @@
 }
 
 {
-   # TextCodecICU::registerCodecs is leaking https://bugs.webkit.org/show_bug.cgi?id=118505
-   WebCore::TextCodec::registerCodecs()
    Memcheck:Leak
    fun:malloc
    fun:_ZN3WTF10fastMallocEm

diff --git a/Tools/Scripts/webkitpy/port/leakdetector.py b/Tools/Scripts/webkitpy/port/leakdetector.py
index af94140..3213d53 100644 (file)
--- a/Tools/Scripts/webkitpy/port/leakdetector.py
+++ b/Tools/Scripts/webkitpy/port/leakdetector.py
@@ -54,12 +54,9 @@ class LeakDetector(object):
 
     def _callstacks_to_exclude_from_leaks(self):
         callstacks = [
-            'TextCodecICU::registerCodecs',  # https://bugs.webkit.org/show_bug.cgi?id=118505
+            # List substrings here, e.g.
+            # 'TextCodecICU::registerCodecs',  # https://bugs.webkit.org/show_bug.cgi?id=118505
         ]
-        if self._port.operating_system == 'mac' and self._port.is_mavericks():
-            callstacks += [
-                'AVAssetResourceLoader _poseAuthenticationChallengeWithKey:data:requestDictionary:fallbackHandler:',  # <rdar://problem/19699887> leak in AVFoundation
-            ]
         return callstacks
 
     def _leaks_args(self, pid):