Occasionally, hundreds of tests fail with small text diffs on Mavericks
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Nov 2013 23:42:41 +0000 (23:42 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Nov 2013 23:42:41 +0000 (23:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=124312

Reviewed by Alexey Proskuryakov.

Try reverting the part of r158652 that deleted all of the persistent
defaults, in the thought that there might be some sort of race between
processes causing some settings to be left in the wrong state.

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
* WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/WebKitTestRunner/mac/main.mm

index beb2497..2eb8602 100644 (file)
@@ -1,3 +1,19 @@
+2013-11-15  Tim Horton  <timothy_horton@apple.com>
+
+        Occasionally, hundreds of tests fail with small text diffs on Mavericks
+        https://bugs.webkit.org/show_bug.cgi?id=124312
+
+        Reviewed by Alexey Proskuryakov.
+
+        Try reverting the part of r158652 that deleted all of the persistent
+        defaults, in the thought that there might be some sort of race between
+        processes causing some settings to be left in the wrong state.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (setDefaultsToConsistentValuesForTesting):
+        * WebKitTestRunner/mac/main.mm:
+        (setDefaultsToConsistentValuesForTesting):
+
 2013-11-15  Dan Bernstein  <mitz@apple.com>
 
         Give the policy client the originating frame of a navigation action
index ea52375..5d70bf6 100644 (file)
@@ -679,8 +679,6 @@ static void setDefaultsToConsistentValuesForTesting()
     static const int NoFontSmoothing = 0;
     static const int BlueTintedAppearance = 1;
 
-    [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"DumpRenderTree"];
-
     NSString *libraryPath = libraryPathForDumpRenderTree();
 
     NSDictionary *dict = @{
index bb87c1d..79b192e 100644 (file)
@@ -29,8 +29,6 @@
 
 static void setDefaultsToConsistentValuesForTesting()
 {
-    [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"WebKitTestRunner"];
-
     NSDictionary *dict = @{
         @"AppleKeyboardUIMode": @1,
         @"AppleMagnifiedMode": @YES,