git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (from parent 1: c64f3f8)
[CSS Grid Layout] Add layout test for anonymous grid items
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Mar 2014 13:29:03 +0000 (13:29 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Mar 2014 13:29:03 +0000 (13:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=130083

Reviewed by Sergio Villar Senin.

Add a layout test to prevent regressions supporting anonymous grid items.

For example, anonymous grid items do not have an associated Node, so trying to access it will make this test
crash.

* fast/css-grid-layout/anonymous-grid-items-expected.html: Added.
* fast/css-grid-layout/anonymous-grid-items.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@165449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/fast/css-grid-layout/anonymous-grid-items-expected.html [new file with mode: 0644] patch | blob
LayoutTests/fast/css-grid-layout/anonymous-grid-items.html [new file with mode: 0644] patch | blob

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index aa9fe3c..18cc6b5 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,18 @@
+2014-03-11  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Add layout test for anonymous grid items
+        https://bugs.webkit.org/show_bug.cgi?id=130083
+
+        Reviewed by Sergio Villar Senin.
+
+        Add a layout test to prevent regressions supporting anonymous grid items.
+
+        For example, anonymous grid items do not have an associated Node, so trying to access it will make this test
+        crash.
+
+        * fast/css-grid-layout/anonymous-grid-items-expected.html: Added.
+        * fast/css-grid-layout/anonymous-grid-items.html: Added.
+
 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
 
         [ATK] Expose aria-posinset and aria-setsize through object attributes
diff --git a/LayoutTests/fast/css-grid-layout/anonymous-grid-items-expected.html b/LayoutTests/fast/css-grid-layout/anonymous-grid-items-expected.html
new file mode 100644 (file)
index 0000000..c3d0a18
--- /dev/null
+++ b/LayoutTests/fast/css-grid-layout/anonymous-grid-items-expected.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+<script>
+if (window.testRunner)
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
+</script>
+<body>
+    <div>Checks that anonymous grid items are supported. This should not crash.</div>
+    <div style="display: -webkit-grid;">
+        <div>anonymous item</div>
+    </div>
+</body>
+</html>
diff --git a/LayoutTests/fast/css-grid-layout/anonymous-grid-items.html b/LayoutTests/fast/css-grid-layout/anonymous-grid-items.html
new file mode 100644 (file)
index 0000000..54425ef
--- /dev/null
+++ b/LayoutTests/fast/css-grid-layout/anonymous-grid-items.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+<script>
+if (window.testRunner)
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
+</script>
+<body>
+    <div>Checks that anonymous grid items are supported. This should not crash.</div>
+    <div style="display: -webkit-grid;">
+        anonymous item
+    </div>
+</body>
+</html>
Mirror of the WebKit open source project from svn.webkit.org.