<rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h...
authormrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 May 2008 21:23:36 +0000 (21:23 +0000)
committermrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 May 2008 21:23:36 +0000 (21:23 +0000)
Reviewed by John Sullivan.

* Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
* Carbon/HIWebView.m: Ditto.
(HIWebViewCreate):
(HIWebViewConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/mac/Carbon/HIWebView.h
WebKit/mac/Carbon/HIWebView.m
WebKit/mac/ChangeLog

index 33536cc..5483472 100644 (file)
@@ -72,32 +72,6 @@ HIWebViewCreate(HIViewRef * outControl) AVAILABLE_WEBKIT_VERSION_1_0_AND_LATER_B
 #ifdef __OBJC__
 
 /*
- *  HIWebViewCreateWithClass(HIViewRef * outControl, Class aClass)
- *  
- *  Summary:
- *    Creates a new web view using the specified subclass of WebView.
- *  
- *  Parameters:
- *    
- *    aClass:
- *      Either WebView, or a subclass, to be created and wrapped in an HIWebView.
- *    outControl:
- *      The new web view.
- *  
- *  Result:
- *    An operating system status code.
- *  
- *  Availability:
- *    Mac OS X:         in version 10.4 and later [32-bit only]
- *    CarbonLib:        not available
- *    Non-Carbon CFM:   not available
- */
-extern OSStatus
-HIWebViewCreateWithClass(
-  Class       aClass,
-  HIViewRef * outControl) AVAILABLE_WEBKIT_VERSION_2_0_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_3_1;
-
-/*
  *  HIWebViewGetWebView()
  *  
  *  Summary:
index 2b9bda4..b461394 100644 (file)
@@ -202,39 +202,15 @@ static inline void HIRectToQDRect( const HIRect* inRect, Rect* outRect )
     outRect->right = (SInt16)CGRectGetMaxX( *inRect );
 }
 
-static Class webViewClass;
-
 //----------------------------------------------------------------------------------
 // HIWebViewCreate
 //----------------------------------------------------------------------------------
 //
 OSStatus
-HIWebViewCreate( HIViewRef* outControl )
+HIWebViewCreate(HIViewRef* outControl)
 {
-       OSStatus                        err;
-    
-       HIWebViewRegisterClass();
-
-    webViewClass = [WebView class];
-       err = HIObjectCreate( kHIWebViewClassID, NULL, (HIObjectRef*)outControl );
-
-       return err;
-}
-
-//----------------------------------------------------------------------------------
-// HIWebViewCreateWithClass
-//----------------------------------------------------------------------------------
-//
-OSStatus HIWebViewCreateWithClass(Class aClass, HIViewRef * outControl)
-{
-       OSStatus                        err;
-    
-       HIWebViewRegisterClass();
-
-    webViewClass = aClass;
-       err = HIObjectCreate( kHIWebViewClassID, NULL, (HIObjectRef*)outControl );
-
-       return err;
+    HIWebViewRegisterClass();
+    return HIObjectCreate(kHIWebViewClassID, NULL, (HIObjectRef*)outControl);
 }
 
 //----------------------------------------------------------------------------------
@@ -269,7 +245,7 @@ HIWebViewConstructor( HIViewRef inView )
        
                view->fViewRef = inView;
 
-                WebView *webView = [[webViewClass alloc] initWithFrame: frame];
+                WebView *webView = [[WebView alloc] initWithFrame: frame];
                 CFRetain(webView);
                 [webView release];
                view->fWebView = webView;
index 7571081..3d43692 100644 (file)
@@ -1,3 +1,14 @@
+2008-05-13  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by John Sullivan.
+
+        <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
+
+        * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
+        * Carbon/HIWebView.m: Ditto.
+        (HIWebViewCreate):
+        (HIWebViewConstructor):
+
 2008-05-12  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by Ada Chan.