[GTK] Silence ATK_XY_PARENT warnings
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Nov 2018 09:05:49 +0000 (09:05 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Nov 2018 09:05:49 +0000 (09:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191504

Reviewed by Carlos Garcia Campos.

* accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
(atkToContents):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textExtents):
* accessibility/atk/WebKitAccessibleUtil.cpp:
(contentsRelativeToAtkCoordinateType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp

index b9d4506..91fee8f 100644 (file)
@@ -1,3 +1,17 @@
+2018-11-12  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Silence ATK_XY_PARENT warnings
+        https://bugs.webkit.org/show_bug.cgi?id=191504
+
+        Reviewed by Carlos Garcia Campos.
+
+        * accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
+        (atkToContents):
+        * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+        (textExtents):
+        * accessibility/atk/WebKitAccessibleUtil.cpp:
+        (contentsRelativeToAtkCoordinateType):
+
 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Implement a new edit command to change the enclosing list type
index e86f230..439fe96 100644 (file)
@@ -60,6 +60,10 @@ static IntPoint atkToContents(AccessibilityObject* coreObject, AtkCoordType coor
             return frameView->screenToContents(pos);
         case ATK_XY_WINDOW:
             return frameView->windowToContents(pos);
+#if ATK_CHECK_VERSION(2, 30, 0)
+        case ATK_XY_PARENT:
+            RELEASE_ASSERT_NOT_REACHED();
+#endif
         }
     }
 
index a3a4f7a..18c9e9b 100644 (file)
@@ -325,6 +325,10 @@ static IntRect textExtents(AtkText* text, gint startOffset, gint length, AtkCoor
     case ATK_XY_WINDOW:
         // No-op
         break;
+#if ATK_CHECK_VERSION(2, 30, 0)
+    case ATK_XY_PARENT:
+        RELEASE_ASSERT_NOT_REACHED();
+#endif
     }
 
     return extents;
index 8f993d1..a26f70a 100644 (file)
@@ -66,6 +66,10 @@ void contentsRelativeToAtkCoordinateType(AccessibilityObject* coreObject, AtkCoo
         case ATK_XY_SCREEN:
             rect = frameView->contentsToScreen(rect);
             break;
+#if ATK_CHECK_VERSION(2, 30, 0)
+        case ATK_XY_PARENT:
+            RELEASE_ASSERT_NOT_REACHED();
+#endif
         }
     }