webkitpy: Use current environment value for GST_DEBUG(_FILE) and DOT_DIR env vars
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2018 18:34:35 +0000 (18:34 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2018 18:34:35 +0000 (18:34 +0000)
https://bugs.webkit.org/show_bug.cgi?id=184036

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-04-02
Reviewed by Philippe Normand.

Those variables are for debug purpose and should not change the behaviour
itself, and developers expect them to have effect.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/gtk.py

index 199cda4..0b0ab09 100644 (file)
@@ -1,3 +1,16 @@
+2018-04-02  Thibault Saunier  <tsaunier@igalia.com>
+
+        webkitpy: Use current environment value for GST_DEBUG(_FILE) and DOT_DIR env vars
+        https://bugs.webkit.org/show_bug.cgi?id=184036
+
+        Reviewed by Philippe Normand.
+
+        Those variables are for debug purpose and should not change the behaviour
+        itself, and developers expect them to have effect.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.setup_environ_for_server):
+
 2018-04-02  Daniel Bates  <dabates@apple.com>
 
         Remove Options constructor and use internal linkage for option handlers
index dac4986..b1b2b69 100644 (file)
@@ -122,6 +122,9 @@ class GtkPort(Port):
         environment['TEST_RUNNER_INJECTED_BUNDLE_FILENAME'] = self._build_path('lib', 'libTestRunnerInjectedBundle.so')
         environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('lib', 'plugins')
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_DUMP_DOT_DIR')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_FILE')
 
         # Configure the software libgl renderer if jhbuild ready and we test inside a virtualized window system
         if self._driver_class() in [XvfbDriver, WestonDriver] and self._should_use_jhbuild():