openDatabase property should not be enumerable on DOMWindow
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Jul 2019 18:09:27 +0000 (18:09 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Jul 2019 18:09:27 +0000 (18:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=199672
<rdar://problem/52809000>

Reviewed by Chris Dumez.

Source/WebCore:

Test: storage/websql/openDatabase-deprecation.html

* Modules/webdatabase/DOMWindowWebDatabase.idl:

LayoutTests:

* storage/websql/openDatabase-deprecation-expected.txt: Added.
* storage/websql/openDatabase-deprecation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/storage/websql/openDatabase-deprecation-expected.txt [new file with mode: 0644]
LayoutTests/storage/websql/openDatabase-deprecation.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.idl

index f85323a..811ff5c 100644 (file)
@@ -1,3 +1,14 @@
+2019-07-10  Youenn Fablet  <youenn@apple.com>
+
+        openDatabase property should not be enumerable on DOMWindow
+        https://bugs.webkit.org/show_bug.cgi?id=199672
+        <rdar://problem/52809000>
+
+        Reviewed by Chris Dumez.
+
+        * storage/websql/openDatabase-deprecation-expected.txt: Added.
+        * storage/websql/openDatabase-deprecation.html: Added.
+
 2019-07-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 
         [GTK][WPE] Enable support for CSS_COMPOSITING
diff --git a/LayoutTests/storage/websql/openDatabase-deprecation-expected.txt b/LayoutTests/storage/websql/openDatabase-deprecation-expected.txt
new file mode 100644 (file)
index 0000000..4669152
--- /dev/null
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: line 12: Web SQL is deprecated. Please use IndexedDB instead.
+
+PASS openDatabase deprecation 
+
diff --git a/LayoutTests/storage/websql/openDatabase-deprecation.html b/LayoutTests/storage/websql/openDatabase-deprecation.html
new file mode 100644 (file)
index 0000000..b036844
--- /dev/null
@@ -0,0 +1,16 @@
+<!doctype html>
+<html>
+    <head>
+        <meta charset="utf-8">
+        <title>openDatabase deprecation</title>
+        <script src="../../resources/testharness.js"></script>
+        <script src="../../resources/testharnessreport.js"></script>
+    </head>
+    <body>
+        <script>
+assert_equals(Object.keys(window).indexOf("openDatabase"), -1);
+window.openDatabase(null, null, null, null);
+done();
+        </script>
+    </body>
+</html>
index 714d4a0..a6566b6 100644 (file)
@@ -1,3 +1,15 @@
+2019-07-10  Youenn Fablet  <youenn@apple.com>
+
+        openDatabase property should not be enumerable on DOMWindow
+        https://bugs.webkit.org/show_bug.cgi?id=199672
+        <rdar://problem/52809000>
+
+        Reviewed by Chris Dumez.
+
+        Test: storage/websql/openDatabase-deprecation.html
+
+        * Modules/webdatabase/DOMWindowWebDatabase.idl:
+
 2019-07-10  Chris Dumez  <cdumez@apple.com>
 
         Fix unsafe usage of makeWeakPtr() in CMTimebaseEffectiveRateChangedCallback()
index b628eec..11eadaa 100644 (file)
@@ -25,5 +25,5 @@
  */
 
 partial interface DOMWindow {
-    [CustomGetter] readonly attribute any openDatabase;
+    [CustomGetter, NotEnumerable] readonly attribute any openDatabase;
 };