2010-06-10 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Jun 2010 08:35:13 +0000 (08:35 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Jun 2010 08:35:13 +0000 (08:35 +0000)
        Reviewed by Eric Seidel.

        fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
        https://bugs.webkit.org/show_bug.cgi?id=40262

        See comment in opacity-change-on-overflow-float.html to understand why
        we made this goofy change.

        * fast/repaint/opacity-change-on-overflow-float.html:
        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
        * platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/repaint/opacity-change-on-overflow-float.html
LayoutTests/html5lib/resources/webkit01.dat
LayoutTests/html5lib/runner-expected.txt
LayoutTests/html5lib/webkit-resumer-expected.txt
LayoutTests/platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt
LayoutTests/platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt

index 8aa2721..b6d01e7 100644 (file)
@@ -1,3 +1,20 @@
+2010-06-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
+        https://bugs.webkit.org/show_bug.cgi?id=40262
+
+        See comment in opacity-change-on-overflow-float.html to understand why
+        we made this goofy change.
+
+        * fast/repaint/opacity-change-on-overflow-float.html:
+        * html5lib/resources/webkit01.dat:
+        * html5lib/runner-expected.txt:
+        * html5lib/webkit-resumer-expected.txt:
+        * platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
+        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:
+
 2010-06-09  Alexey Proskuryakov  <ap@apple.com>
 
         Undo an accidentally committed change.
index ba5fd0c..aa29aa0 100644 (file)
@@ -27,7 +27,19 @@ function repaintTest()
 
 </head>
 <body onload="runRepaintTest()">
-<p>Repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.  Make sure when a layer switches
+<p>Repaint test for <rdar><!-- 
+Oh man, let me explain why this is here.  In the beginning, there was an
+<rdar:://problem/6869687> link to the great and mysterious rdar.  However, that
+link was invisible because whoever added it decided to enclose the link in
+angle brackets.
+
+There was peace in the land, until we implemented the HTML5 parsing algorithm,
+which changed the name of the mysterious rdar element to not include //
+charaters.  Rather than regenerate the expected results (which were platform
+specific), our hero changed the rdar link to an <rdar> element and hand-edited
+the expected render tree.
+
+And on the third day, he rested. --> REGRESSION (r41203): Facebook friend suggestions disappear on update.  Make sure when a layer switches
 from being self-painting to non-self-painting that a layout happens to fix up the floating objects lists.  You should see a 100x100 green square below.
 If you see any red, the test has failed.
 </p>
index 43bf0fe..d633c6e 100644 (file)
@@ -188,3 +188,14 @@ console.log("FOO<span>BAR</span>BAZ");
 |     <p>
 |       "Test"
 |       "Test2"
+
+#data
+<rdar://problem/6869687>
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <rdar:>
+|       6869687=""
+|       problem=""
index 94c00c1..71a902b 100644 (file)
@@ -400,6 +400,7 @@ resources/tests16.dat:
 resources/webkit01.dat:
 13
 15
+16
 
 resources/doctype01.dat:
 2
index e4b9981..2aef2d4 100644 (file)
@@ -185,3 +185,26 @@ resources/webkit01.dat:
 567.19
 568.20
 569.21
+570.1
+571.2
+572.3
+573.4
+574.5
+575.6
+576.7
+577.8
+578.9
+579.10
+580.11
+581.12
+582.13
+583.14
+584.15
+585.16
+586.17
+587.18
+588.19
+589.20
+590.21
+591.22
+592.23
index ec56513..29d27e1 100644 (file)
@@ -6,7 +6,7 @@ layer at (0,0) size 800x600
       RenderBlock {P} at (0,0) size 784x60
         RenderText {#text} at (0,0) size 96x19
           text run at (0,0) width 96: "Repaint test for "
-        RenderInline {RDAR://PROBLEM/6869687} at (0,0) size 765x59
+        RenderInline {RDAR} at (0,0) size 765x59
           RenderText {#text} at (96,0) size 765x59
             text run at (96,0) width 469: "REGRESSION (r41203): Facebook friend suggestions disappear on update. "
             text run at (565,0) width 200: "Make sure when a layer switches"
index 74b7a94..56f7466 100644 (file)
@@ -6,7 +6,7 @@ layer at (0,0) size 800x600
       RenderBlock {P} at (0,0) size 784x54
         RenderText {#text} at (0,0) size 100x18
           text run at (0,0) width 100: "Repaint test for "
-        RenderInline {RDAR://PROBLEM/6869687} at (0,0) size 763x54
+        RenderInline {RDAR} at (0,0) size 763x54
           RenderText {#text} at (100,0) size 763x54
             text run at (100,0) width 486: "REGRESSION (r41203): Facebook friend suggestions disappear on update. "
             text run at (586,0) width 151: "Make sure when a layer"