Disable ENABLE_DATALIST for now
authorkeishi@webkit.org <keishi@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Apr 2012 04:43:17 +0000 (04:43 +0000)
committerkeishi@webkit.org <keishi@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Apr 2012 04:43:17 +0000 (04:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=82871

Reviewed by Kent Tamura.

.:

We should disable ENABLE_DATALIST because
- We need platform-dependent implementation, and non-BlackBerry platforms don't have it.
- We need to hide the content of <datalist>, but it is shown for now.

* Source/cmake/OptionsEfl.cmake: Disabled ENABLE_DATALIST.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Tools:

* Scripts/build-webkit: Disabled ENABLE_DATALIST.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops: Disabled ENABLE_DATALIST.

LayoutTests:

Moved datalist tests into directory fast/forms/datalist and added it to Skipped files.

* fast/forms/datalist/datalist-expected.txt: Moved from LayoutTests/fast/forms/datalist-expected.txt.
* fast/forms/datalist/datalist-nonoption-child-expected.txt: Moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt.
* fast/forms/datalist/datalist-nonoption-child.html: Moved from LayoutTests/fast/forms/datalist-nonoption-child.html.
* fast/forms/datalist/datalist.html: Moved from LayoutTests/fast/forms/datalist.html.
* fast/forms/datalist/input-list-expected.txt: Moved from LayoutTests/fast/forms/input-list-expected.txt.
* fast/forms/datalist/input-list.html: Moved from LayoutTests/fast/forms/input-list.html.
* fast/forms/datalist/input-selectedoption-expected.txt: Moved from LayoutTests/fast/forms/input-selectedoption-expected.txt.
* fast/forms/datalist/input-selectedoption.html: Moved from LayoutTests/fast/forms/input-selectedoption.html.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

29 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/fast/forms/datalist/datalist-expected.txt [moved from LayoutTests/fast/forms/datalist-expected.txt with 100% similarity]
LayoutTests/fast/forms/datalist/datalist-nonoption-child-expected.txt [moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt with 100% similarity]
LayoutTests/fast/forms/datalist/datalist-nonoption-child.html [moved from LayoutTests/fast/forms/datalist-nonoption-child.html with 83% similarity]
LayoutTests/fast/forms/datalist/datalist.html [moved from LayoutTests/fast/forms/datalist.html with 85% similarity]
LayoutTests/fast/forms/datalist/input-list-expected.txt [moved from LayoutTests/fast/forms/input-list-expected.txt with 100% similarity]
LayoutTests/fast/forms/datalist/input-list.html [moved from LayoutTests/fast/forms/input-list.html with 100% similarity]
LayoutTests/fast/forms/datalist/input-selectedoption-expected.txt [moved from LayoutTests/fast/forms/input-selectedoption-expected.txt with 100% similarity]
LayoutTests/fast/forms/datalist/input-selectedoption.html [moved from LayoutTests/fast/forms/input-selectedoption.html with 100% similarity]
LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/platform/efl/Skipped
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac/Skipped
LayoutTests/platform/qt/Skipped
LayoutTests/platform/win/Skipped
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Source/cmake/OptionsEfl.cmake
Tools/ChangeLog
Tools/Scripts/build-webkit
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops

index 5378a07..c02fe2e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        We should disable ENABLE_DATALIST because
+        - We need platform-dependent implementation, and non-BlackBerry platforms don't have it.
+        - We need to hide the content of <datalist>, but it is shown for now.
+
+        * Source/cmake/OptionsEfl.cmake: Disabled ENABLE_DATALIST.
+
 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
 
         [Qt][WK2] Set up plugin process on Unix
index 24c4208..d96f746 100644 (file)
@@ -1,3 +1,27 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        Moved datalist tests into directory fast/forms/datalist and added it to Skipped files.
+
+        * fast/forms/datalist/datalist-expected.txt: Moved from LayoutTests/fast/forms/datalist-expected.txt.
+        * fast/forms/datalist/datalist-nonoption-child-expected.txt: Moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt.
+        * fast/forms/datalist/datalist-nonoption-child.html: Moved from LayoutTests/fast/forms/datalist-nonoption-child.html.
+        * fast/forms/datalist/datalist.html: Moved from LayoutTests/fast/forms/datalist.html.
+        * fast/forms/datalist/input-list-expected.txt: Moved from LayoutTests/fast/forms/input-list-expected.txt.
+        * fast/forms/datalist/input-list.html: Moved from LayoutTests/fast/forms/input-list.html.
+        * fast/forms/datalist/input-selectedoption-expected.txt: Moved from LayoutTests/fast/forms/input-selectedoption-expected.txt.
+        * fast/forms/datalist/input-selectedoption.html: Moved from LayoutTests/fast/forms/input-selectedoption.html.
+        * platform/chromium/test_expectations.txt:
+        * platform/efl/Skipped:
+        * platform/gtk/Skipped:
+        * platform/mac/Skipped:
+        * platform/qt/Skipped:
+        * platform/win/Skipped:
+
 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
 
         Update another baseline for a failing chromium SL svg test (and mark it flaky).
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../../fast/js/resources/js-test-pre.js"></script>
+<script src="../../../fast/js/resources/js-test-pre.js"></script>
 </head>
 <body>
 <p id="description"></p>
@@ -23,6 +23,6 @@ shouldBe('datalist.firstChild.nodeName', '"B"');
 datalist = document.getElementById('dl3');
 shouldBe('datalist.firstChild.nodeName', '"DIV"');
 </script>
-<script src="../../fast/js/resources/js-test-post.js"></script>
+<script src="../../../fast/js/resources/js-test-post.js"></script>
 </body>
 </html>
similarity index 85%
rename from LayoutTests/fast/forms/datalist.html
rename to LayoutTests/fast/forms/datalist/datalist.html
index 4d163a3..3019bb5 100644 (file)
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../../fast/js/resources/js-test-pre.js"></script>
+<script src="../../../fast/js/resources/js-test-pre.js"></script>
 </head>
 <body>
 <p id="description"></p>
@@ -29,6 +29,6 @@ shouldBe('datalist.options.length', '3');
 // After datalist is implemented, the expected text should not contain the
 // text in the datalist element.
 </script>
-<script src="../../fast/js/resources/js-test-post.js"></script>
+<script src="../../../fast/js/resources/js-test-post.js"></script>
 </body>
 </html>
index 719634f..e77c689 100644 (file)
@@ -1083,9 +1083,7 @@ BUGCR27697 SKIP : storage/hash-change-with-xhr.html = PASS
 
 // HTML5 datalist element. We don't enable it because WebKit implementation
 // is incomplete.
-BUGCR20226 : fast/forms/datalist.html = TEXT
-BUGCR20226 : fast/forms/input-list.html = FAIL
-BUGCR20226 : fast/forms/input-selectedoption.html = FAIL
+BUGCR20226 : fast/forms/datalist/ = PASS FAIL
 
 // Implementation of Date/time input types are incomplete and
 // ENABLE_INPUT_TYPE_* flags are not enabled.
index 1787125..6a7b898 100644 (file)
@@ -299,6 +299,9 @@ fast/media/print-restores-previous-mediatype.html
 # ENABLE(SHADOW_DOM) is disabled
 fast/dom/shadow
 
+# ENABLE(DATALIST) is disabled
+fast/forms/datalist
+
 # defined(ENABLE_INPUT_TYPE_COLOR) is disabled
 fast/forms/color/input-color-onchange-event.html
 
index 1eaf950..172f40f 100644 (file)
@@ -259,6 +259,9 @@ http/tests/inspector/indexeddb
 # StorageTracker is not enabled.
 storage/domstorage/localstorage/storagetracker
 
+# Datalist is not yet enabled.
+fast/forms/datalist
+
 # Color input is not yet enabled.
 fast/forms/color
 
index 443bc41..aafbb05 100644 (file)
@@ -209,6 +209,9 @@ fast/events/drag-image-filename.html
 # Hits an assert in FrameLoader.cpp. https://bugs.webkit.org/show_bug.cgi?id=31387
 http/tests/multipart/policy-ignore-crash.php
 
+# Datalist is not yet enabled.
+fast/forms/datalist
+
 # Color input is not yet enabled.
 fast/forms/color
 
index 9d19a15..bbd4442 100644 (file)
@@ -67,6 +67,9 @@ canvas/philip/tests/2d.drawImage.outsidesource.html
 #       Disabled features.                                                    #
 # =========================================================================== #
 
+# ENABLE_DATALIST is not yet enabled.
+fast/forms/datalist
+
 # ENABLE_INPUT_TYPE_COLOR is disabled.
 fast/forms/color
 
index ea7df32..587faee 100644 (file)
@@ -1159,6 +1159,9 @@ fast/forms/number/input-number-size.html
 fast/forms/number/input-spinbutton-capturing.html
 fast/forms/number/spin-button-gets-disabled-or-readonly.html
 
+# Datalist is not yet enabled.
+fast/forms/datalist
+
 # Color input is not yet enabled.
 fast/forms/color
 
index 04f7722..7a1bb83 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
+
 2012-04-02  Filip Pizlo  <fpizlo@apple.com>
 
         jsr/sret should be removed
index f5ef0bc..5fd791d 100644 (file)
@@ -36,9 +36,6 @@ ENABLE_BLOB = ENABLE_BLOB;
 ENABLE_DASHBOARD_SUPPORT = $(ENABLE_DASHBOARD_SUPPORT_$(REAL_PLATFORM_NAME));
 ENABLE_DASHBOARD_SUPPORT_macosx = ENABLE_DASHBOARD_SUPPORT;
 
-ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
-ENABLE_DATALIST_macosx = ENABLE_DATALIST;
-
 ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
 ENABLE_FILTERS_macosx = ENABLE_FILTERS;
 
@@ -73,6 +70,7 @@ ENABLE_ANIMATION_API = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSS_FILTERS = ENABLE_CSS_FILTERS;
 ENABLE_CSS_GRID_LAYOUT = ENABLE_CSS_GRID_LAYOUT;
+ENABLE_DATALIST = ;
 ENABLE_DATA_TRANSFER_ITEMS = ;
 ENABLE_DETAILS = ENABLE_DETAILS;
 ENABLE_DEVICE_ORIENTATION = ;
index e4d9aff..869721b 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
+
 2012-04-03  Yael Aharon  <yael.aharon@nokia.com>
 
         [Qt][WK2] Assert on startup after r113090
index f5ef0bc..5fd791d 100644 (file)
@@ -36,9 +36,6 @@ ENABLE_BLOB = ENABLE_BLOB;
 ENABLE_DASHBOARD_SUPPORT = $(ENABLE_DASHBOARD_SUPPORT_$(REAL_PLATFORM_NAME));
 ENABLE_DASHBOARD_SUPPORT_macosx = ENABLE_DASHBOARD_SUPPORT;
 
-ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
-ENABLE_DATALIST_macosx = ENABLE_DATALIST;
-
 ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
 ENABLE_FILTERS_macosx = ENABLE_FILTERS;
 
@@ -73,6 +70,7 @@ ENABLE_ANIMATION_API = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSS_FILTERS = ENABLE_CSS_FILTERS;
 ENABLE_CSS_GRID_LAYOUT = ENABLE_CSS_GRID_LAYOUT;
+ENABLE_DATALIST = ;
 ENABLE_DATA_TRANSFER_ITEMS = ;
 ENABLE_DETAILS = ENABLE_DETAILS;
 ENABLE_DEVICE_ORIENTATION = ;
index 684656e..8be22c9 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
+
 2012-04-03  Anders Carlsson  <andersca@apple.com>
 
         Add audit token to PHCheckInWithPluginHost
index f5ef0bc..5fd791d 100644 (file)
@@ -36,9 +36,6 @@ ENABLE_BLOB = ENABLE_BLOB;
 ENABLE_DASHBOARD_SUPPORT = $(ENABLE_DASHBOARD_SUPPORT_$(REAL_PLATFORM_NAME));
 ENABLE_DASHBOARD_SUPPORT_macosx = ENABLE_DASHBOARD_SUPPORT;
 
-ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
-ENABLE_DATALIST_macosx = ENABLE_DATALIST;
-
 ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
 ENABLE_FILTERS_macosx = ENABLE_FILTERS;
 
@@ -73,6 +70,7 @@ ENABLE_ANIMATION_API = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSS_FILTERS = ENABLE_CSS_FILTERS;
 ENABLE_CSS_GRID_LAYOUT = ENABLE_CSS_GRID_LAYOUT;
+ENABLE_DATALIST = ;
 ENABLE_DATA_TRANSFER_ITEMS = ;
 ENABLE_DETAILS = ENABLE_DETAILS;
 ENABLE_DEVICE_ORIENTATION = ;
index 428ee33..45831cb 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
+
 2012-04-03  Yael Aharon  <yael.aharon@nokia.com>
 
         [Qt][WK2] Assert on startup after r113090
index f5ef0bc..5fd791d 100644 (file)
@@ -36,9 +36,6 @@ ENABLE_BLOB = ENABLE_BLOB;
 ENABLE_DASHBOARD_SUPPORT = $(ENABLE_DASHBOARD_SUPPORT_$(REAL_PLATFORM_NAME));
 ENABLE_DASHBOARD_SUPPORT_macosx = ENABLE_DASHBOARD_SUPPORT;
 
-ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
-ENABLE_DATALIST_macosx = ENABLE_DATALIST;
-
 ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
 ENABLE_FILTERS_macosx = ENABLE_FILTERS;
 
@@ -73,6 +70,7 @@ ENABLE_ANIMATION_API = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_CSS_FILTERS = ENABLE_CSS_FILTERS;
 ENABLE_CSS_GRID_LAYOUT = ENABLE_CSS_GRID_LAYOUT;
+ENABLE_DATALIST = ;
 ENABLE_DATA_TRANSFER_ITEMS = ;
 ENABLE_DETAILS = ENABLE_DETAILS;
 ENABLE_DEVICE_ORIENTATION = ;
index 5926f40..9d3ac6b 100644 (file)
@@ -67,7 +67,7 @@ SET(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter"
 WEBKIT_FEATURE(ENABLE_BATTERY_STATUS "Enable battery status api" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_BLOB "Enable blob slice" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_CHANNEL_MESSAGING "Enable channel messaging" DEFAULT ON)
-WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT ON)
+WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DETAILS "Enable HTML5 Details and Summary elements" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_DEVICE_ORIENTATION "Enable device orientation" DEFAULT OFF)
index 4c34e61..0f17353 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * Scripts/build-webkit: Disabled ENABLE_DATALIST.
+
 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
 
         Sigh... this isn't going well. I can't even reproduce this issue locally.
index cf4a8e9..712be91 100755 (executable)
@@ -187,7 +187,7 @@ my @features = (
       define => "ENABLE_SQL_DATABASE", default => 1, value => \$sqlDatabaseSupport },
 
     { option => "datalist", desc => "Toggle HTML5 datalist support",
-      define => "ENABLE_DATALIST", default => 1, value => \$datalistSupport },
+      define => "ENABLE_DATALIST", default => 0, value => \$datalistSupport },
 
     { option => "data-transfer-items", desc => "Toggle HTML5 data transfer items support",
       define => "ENABLE_DATA_TRANSFER_ITEMS", default => 0, value => \$dataTransferItemsSupport },
index b0d3370..79a61de 100644 (file)
@@ -1,3 +1,12 @@
+2012-04-03  Keishi Hattori  <keishi@webkit.org>
+
+        Disable ENABLE_DATALIST for now
+        https://bugs.webkit.org/show_bug.cgi?id=82871
+
+        Reviewed by Kent Tamura.
+
+        * win/tools/vsprops/FeatureDefines.vsprops: Disabled ENABLE_DATALIST.
+
 2012-03-30  Keishi Hattori  <keishi@webkit.org>
 
         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
index 187c0fb..c4983ee 100644 (file)
@@ -78,7 +78,7 @@
        />
   <UserMacro
                Name="ENABLE_DATALIST"
-               Value="ENABLE_DATALIST"
+               Value=""
                PerformEnvironmentSet="true"
        />
   <UserMacro