REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jan 2020 13:27:46 +0000 (13:27 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jan 2020 13:27:46 +0000 (13:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=206454

Reviewed by Tim Horton.

Source/WebKit:

Since r253636 only platforms defining HAVE_NSCURSOR claim to support setting the cursor.

* WebProcess/WebCoreSupport/WebChromeClient.h: Do not implement supportsSettingCursor() for GTK port either.

LayoutTests:

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

index 28f5df2..075a256 100644 (file)
@@ -1,3 +1,12 @@
+2020-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
+        https://bugs.webkit.org/show_bug.cgi?id=206454
+
+        Reviewed by Tim Horton.
+
+        * platform/gtk/TestExpectations:
+
 2020-01-30  Noam Rosenthal  <noam@webkit.org>
 
         REGRESSION (r254406): Gmail.com star/favorite icons are not rendering
index 2b21cd2..d85c8a1 100644 (file)
@@ -124,9 +124,6 @@ webkit.org/b/98925 fast/viewport/viewport-legacy-xhtmlmp.html [ Skip ]
 # WebKitGTK+ uses different keyboard accelerators than Safari (via Chromium).
 fast/events/option-tab.html [ WontFix Failure ]
 
-webkit.org/b/206454 fast/events/mouse-cursor-change.html [ Failure ]
-webkit.org/b/206454 fast/events/mouse-cursor-no-mousemove.html [ Failure ]
-
 # These tests expect a TIFF decoder (via Chromium).
 # These pass while they're marked as WontFix - check it.
 fast/images/embed-image.html [ WontFix Pass ]
index e6b617c..829bdb3 100644 (file)
@@ -1,3 +1,14 @@
+2020-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
+        https://bugs.webkit.org/show_bug.cgi?id=206454
+
+        Reviewed by Tim Horton.
+
+        Since r253636 only platforms defining HAVE_NSCURSOR claim to support setting the cursor.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.h: Do not implement supportsSettingCursor() for GTK port either.
+
 2020-01-29  Tim Horton  <timothy_horton@apple.com>
 
         REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location
index e746753..a8a4cca 100644 (file)
@@ -195,7 +195,7 @@ private:
 
     void setCursor(const WebCore::Cursor&) final;
     void setCursorHiddenUntilMouseMoves(bool) final;
-#if !HAVE(NSCURSOR)
+#if !HAVE(NSCURSOR) && !PLATFORM(GTK)
     bool supportsSettingCursor() final { return false; }
 #endif