[MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
authoraboya@igalia.com <aboya@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2019 18:05:13 +0000 (18:05 +0000)
committeraboya@igalia.com <aboya@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2019 18:05:13 +0000 (18:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196352

Reviewed by Xabier Rodriguez-Calvar.

MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
branch is never reached.

This patch does not introduce behavior changes.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::doSeek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

index 15136a8..93414cc 100644 (file)
@@ -1,3 +1,18 @@
+2019-03-28  Alicia Boya GarcĂ­a  <aboya@igalia.com>
+
+        [MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
+        https://bugs.webkit.org/show_bug.cgi?id=196352
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
+        branch is never reached.
+
+        This patch does not introduce behavior changes.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::doSeek):
+
 2019-03-28  Simon Fraser  <simon.fraser@apple.com>
 
         [macOS WK2] Overlays on instagram.com are shifted if you click on a photo after scrolling
index aeab396..45277f8 100644 (file)
@@ -591,11 +591,6 @@ bool MediaPlayerPrivateGStreamer::doSeek(const MediaTime& position, float rate,
     // Default values for rate >= 0.
     MediaTime startTime = position, endTime = MediaTime::invalidTime();
 
-    // TODO: Should do more than that, need to notify the media source
-    // and probably flush the pipeline at least.
-    if (isMediaSource())
-        return true;
-
     if (rate < 0) {
         startTime = MediaTime::zeroTime();
         // If we are at beginning of media, start from the end to