iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jul 2018 00:40:22 +0000 (00:40 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jul 2018 00:40:22 +0000 (00:40 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187363
<rdar://problem/41106306>

Patch by Olivia Barnett <obarnett@apple.com> on 2018-07-05
Reviewed by Tim Horton.

Added extra check to prevent keyboard scrolling when the select box is open.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _scrollOffsetForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

index 6758b8f..3395cc0 100644 (file)
@@ -1,3 +1,16 @@
+2018-07-05  Olivia Barnett  <obarnett@apple.com>
+
+        iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
+        https://bugs.webkit.org/show_bug.cgi?id=187363
+        <rdar://problem/41106306>
+
+        Reviewed by Tim Horton.
+
+        Added extra check to prevent keyboard scrolling when the select box is open.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _scrollOffsetForEvent:]):
+
 2018-07-05  Timothy Hatcher  <timothy@apple.com>
 
         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
index 3d6a3c8..94cc519 100644 (file)
@@ -3655,6 +3655,9 @@ static NSString *contentTypeFromFieldName(WebCore::AutofillFieldName fieldName)
 
     if (_page->editorState().isContentEditable)
         return std::nullopt;
+    
+    if (_assistedNodeInformation.elementType == InputType::Select)
+        return std::nullopt;
 
     NSString *charactersIgnoringModifiers = event.charactersIgnoringModifiers;
     if (!charactersIgnoringModifiers.length)