Always call CompletionHandlers after r240909
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2019 22:52:18 +0000 (22:52 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2019 22:52:18 +0000 (22:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194823

Patch by Alex Christensen <achristensen@webkit.org> on 2019-02-20
Reviewed by Ryosuke Niwa.

* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/loader/PolicyChecker.cpp

index cb8e95b..7a6b613 100644 (file)
@@ -1,3 +1,14 @@
+2019-02-20  Alex Christensen  <achristensen@webkit.org>
+
+        Always call CompletionHandlers after r240909
+        https://bugs.webkit.org/show_bug.cgi?id=194823
+
+        Reviewed by Ryosuke Niwa.
+
+        * loader/PolicyChecker.cpp:
+        (WebCore::PolicyChecker::checkNavigationPolicy):
+        (WebCore::PolicyChecker::checkNewWindowPolicy):
+
 2019-02-20  Andy Estes  <aestes@apple.com>
 
         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
index d591e01..8b91e1c 100644 (file)
@@ -193,7 +193,7 @@ void PolicyChecker::checkNavigationPolicy(ResourceRequest&& request, const Resou
          blobURLLifetimeExtension = WTFMove(blobURLLifetimeExtension), requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
 
         if (!responseIdentifier.isValidFor(requestIdentifier))
-            return;
+            return function({ }, nullptr, NavigationPolicyDecision::IgnoreLoad);
 
         m_delegateIsDecidingNavigationPolicy = false;
 
@@ -234,7 +234,7 @@ void PolicyChecker::checkNewWindowPolicy(NavigationAction&& navigationAction, Re
         requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
 
         if (!responseIdentifier.isValidFor(requestIdentifier))
-            return;
+            return function({ }, nullptr, { }, { }, ShouldContinue::No);
 
         switch (policyAction) {
         case PolicyAction::Download: