Remove deprecated parts of media stream spec
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Apr 2017 19:59:26 +0000 (19:59 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Apr 2017 19:59:26 +0000 (19:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=169879

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-10
Reviewed by Jon Lee.

Removing MediaStreamTrackState 'new' value which was unused.
Removing MediaStreamTrack _readonly attribute which was unused.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readonly): Deleted.
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
* platform/mediastream/MediaStreamTrackPrivate.h:
* platform/mediastream/RealtimeMediaSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
Source/WebCore/Modules/mediastream/MediaStreamTrack.h
Source/WebCore/Modules/mediastream/MediaStreamTrack.idl
Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
Source/WebCore/platform/mediastream/RealtimeMediaSource.h

index a7c010f..7c0ef40 100644 (file)
@@ -1,3 +1,22 @@
+2017-04-10  Youenn Fablet  <youenn@apple.com>
+
+        Remove deprecated parts of media stream spec
+        https://bugs.webkit.org/show_bug.cgi?id=169879
+
+        Reviewed by Jon Lee.
+
+        Removing MediaStreamTrackState 'new' value which was unused.
+        Removing MediaStreamTrack _readonly attribute which was unused.
+
+        * Modules/mediastream/MediaStreamTrack.cpp:
+        (WebCore::MediaStreamTrack::readonly): Deleted.
+        * Modules/mediastream/MediaStreamTrack.h:
+        * Modules/mediastream/MediaStreamTrack.idl:
+        * platform/mediastream/MediaStreamTrackPrivate.cpp:
+        (WebCore::MediaStreamTrackPrivate::readonly): Deleted.
+        * platform/mediastream/MediaStreamTrackPrivate.h:
+        * platform/mediastream/RealtimeMediaSource.h:
+
 2017-04-10  Ryan Haddad  <ryanhaddad@apple.com>
 
         Unreviewed, rolling out r215175.
index d34b5da..03ed872 100644 (file)
@@ -98,11 +98,6 @@ bool MediaStreamTrack::muted() const
     return m_private->muted();
 }
 
-bool MediaStreamTrack::readonly() const
-{
-    return m_private->readonly();
-}
-
 auto MediaStreamTrack::readyState() const -> State
 {
     return ended() ? State::Ended : State::Live;
index 5a09800..cbc412e 100644 (file)
@@ -64,9 +64,8 @@ public:
     void setEnabled(bool);
 
     bool muted() const;
-    bool readonly() const;
 
-    enum class State { New, Live, Ended };
+    enum class State { Live, Ended };
     State readyState() const;
 
     bool ended() const;
index 7f47791..08c592d 100644 (file)
@@ -24,7 +24,7 @@
  */
 
 // FIXME 169871: remove "new"
-enum MediaStreamTrackState { "new", "live", "ended" };
+enum MediaStreamTrackState { "live", "ended" };
 
 [
     ActiveDOMObject,
@@ -53,9 +53,6 @@ enum MediaStreamTrackState { "new", "live", "ended" };
     Promise<void> applyConstraints(optional MediaTrackConstraints constraints);
 
     attribute EventHandler onoverconstrained;
-
-    // FIXME 169871: legacy or remove?
-    readonly attribute boolean _readonly;
 };
 
 [
index 8624f8b..d4c2db1 100644 (file)
@@ -80,11 +80,6 @@ bool MediaStreamTrackPrivate::muted() const
     return m_source->muted();
 }
 
-bool MediaStreamTrackPrivate::readonly() const
-{
-    return m_source->readonly();
-}
-
 bool MediaStreamTrackPrivate::isCaptureTrack() const
 {
     return m_source->isCaptureSource();
index 6b87f88..699bc5c 100644 (file)
@@ -71,7 +71,6 @@ public:
     bool muted() const;
     void setMuted(bool muted) { m_source->setMuted(muted); }
 
-    bool readonly() const;
     bool isCaptureTrack() const;
 
     bool enabled() const { return m_isEnabled; }
index a8e223c..411ba82 100644 (file)
@@ -63,7 +63,6 @@ void RealtimeMediaSource::reset()
 {
     m_stopped = false;
     m_muted = false;
-    m_readonly = false;
 }
 
 void RealtimeMediaSource::addObserver(RealtimeMediaSource::Observer& observer)
@@ -147,11 +146,6 @@ void RealtimeMediaSource::audioSamplesAvailable(const MediaTime& time, const Pla
         observer->audioSamplesAvailable(time, audioData, description, numberOfFrames);
 }
 
-bool RealtimeMediaSource::readonly() const
-{
-    return m_readonly;
-}
-
 void RealtimeMediaSource::stop(Observer* callingObserver)
 {
     if (stopped())
index 4b5690c..07b021f 100644 (file)
@@ -133,9 +133,6 @@ public:
     virtual bool enabled() const { return m_enabled; }
     virtual void setEnabled(bool);
 
-    virtual bool readonly() const;
-    virtual void setReadonly(bool readonly) { m_readonly = readonly; }
-
     virtual bool isCaptureSource() const { return false; }
 
     WEBCORE_EXPORT void addObserver(Observer&);
@@ -228,7 +225,6 @@ private:
 
     bool m_echoCancellation { false };
     bool m_stopped { false };
-    bool m_readonly { false };
     bool m_pendingSettingsDidChangeNotification { false };
     bool m_suppressNotifications { true };
 };