Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jul 2018 07:48:51 +0000 (07:48 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jul 2018 07:48:51 +0000 (07:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187317

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-06
Reviewed by Ryosuke Niwa.

This function is called with a new custom element or the fallback HTMLUnknownElement element
so we rename it didCreateCustomOrFallbackElement.

No new tests, behavior unchanged.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
(WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.
* html/parser/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/parser/HTMLDocumentParser.cpp
Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Source/WebCore/html/parser/HTMLTreeBuilder.h

index cc2fc24..cf44220 100644 (file)
@@ -1,3 +1,22 @@
+2018-07-06  Frederic Wang  <fwang@igalia.com>
+
+        Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
+        https://bugs.webkit.org/show_bug.cgi?id=187317
+
+        Reviewed by Ryosuke Niwa.
+
+        This function is called with a new custom element or the fallback HTMLUnknownElement element
+        so we rename it didCreateCustomOrFallbackElement.
+
+        No new tests, behavior unchanged.
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
+        (WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.
+        * html/parser/HTMLTreeBuilder.h:
+
 2018-07-05  Ryosuke Niwa  <rniwa@webkit.org>
 
         REGRESSION(r233496): macOS Sierra hits debug assertions in TrackListBase::suspend
index dcf49e9..34a12a2 100644 (file)
@@ -200,7 +200,7 @@ void HTMLDocumentParser::runScriptsForPausedTreeBuilder()
         // https://html.spec.whatwg.org/#create-an-element-for-the-token
         auto& elementInterface = constructionData->elementInterface.get();
         auto newElement = elementInterface.constructElementWithFallback(*document(), constructionData->name);
-        m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
+        m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData);
         return;
     }
 
index 4b7fc8f..e40f9a8 100644 (file)
@@ -873,7 +873,7 @@ inline void HTMLTreeBuilder::insertGenericHTMLElement(AtomicHTMLToken&& token)
     m_customElementToConstruct = m_tree.insertHTMLElementOrFindCustomElementInterface(WTFMove(token));
 }
 
-void HTMLTreeBuilder::didCreateCustomOrCallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
+void HTMLTreeBuilder::didCreateCustomOrFallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
 {
     m_tree.insertCustomElement(WTFMove(element), data.name, WTFMove(data.attributes));
 }
index aeccab4..c563aba 100644 (file)
@@ -66,7 +66,7 @@ public:
     RefPtr<ScriptElement> takeScriptToProcess(TextPosition& scriptStartPosition);
 
     std::unique_ptr<CustomElementConstructionData> takeCustomElementConstructionData() { return WTFMove(m_customElementToConstruct); }
-    void didCreateCustomOrCallbackElement(Ref<Element>&&, CustomElementConstructionData&);
+    void didCreateCustomOrFallbackElement(Ref<Element>&&, CustomElementConstructionData&);
 
     // Done, close any open tags, etc.
     void finished();