Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the...
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Apr 2020 04:27:28 +0000 (04:27 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Apr 2020 04:27:28 +0000 (04:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=210838

Reviewed by Joseph Pecoraro.

* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
Include `WI.ShaderProgram` in the list of displayable represented objects.

* UserInterface/Base/Main.js:
(WI.tabContentViewClassForRepresentedObject):
* UserInterface/Views/GraphicsTabContentView.js:
(WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
Update the list of represented objects that are displayable by the Graphics Tab.

* UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview > section > .header):
(.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
Drive-by: add a top border to the first section when overscrolling.
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Base/Main.js
Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css
Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css
Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js

index 251655a..f456e64 100644 (file)
@@ -1,3 +1,29 @@
+2020-04-21  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=210838
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/CanvasSidebarPanel.js:
+        (WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
+        Include `WI.ShaderProgram` in the list of displayable represented objects.
+
+        * UserInterface/Base/Main.js:
+        (WI.tabContentViewClassForRepresentedObject):
+        * UserInterface/Views/GraphicsTabContentView.js:
+        (WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
+        Update the list of represented objects that are displayable by the Graphics Tab.
+
+        * UserInterface/Views/GraphicsOverviewContentView.css:
+        (.content-view.graphics-overview > section > .header):
+        (.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
+        Drive-by: add a top border to the first section when overscrolling.
+
+        * UserInterface/Views/CanvasOverviewContentView.css:
+        (.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
+        Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.
+
 2020-04-20  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
index fed4a86..9120c07 100644 (file)
@@ -1397,7 +1397,12 @@ WI.tabContentViewClassForRepresentedObject = function(representedObject)
         || representedObject instanceof WI.AuditTestCaseResult || representedObject instanceof WI.AuditTestGroupResult)
         return WI.AuditTabContentView;
 
-    if (representedObject instanceof WI.Canvas || representedObject instanceof WI.ShaderProgram || representedObject instanceof WI.Recording || representedObject instanceof WI.Animation)
+    if (representedObject instanceof WI.CanvasCollection
+        || representedObject instanceof WI.Canvas
+        || representedObject instanceof WI.Recording
+        || representedObject instanceof WI.ShaderProgram
+        || representedObject instanceof WI.AnimationCollection
+        || representedObject instanceof WI.Animation)
         return WI.GraphicsTabContentView;
 
     return null;
index fa2ab4c..e233299 100644 (file)
 
 .content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view {
     position: static;
+    z-index: 0;
 }
 
 .content-view.canvas-overview > .content-view.canvas > footer {
index 603f5ae..f6e22ca 100644 (file)
@@ -238,6 +238,7 @@ WI.CanvasSidebarPanel = class CanvasSidebarPanel extends WI.NavigationSidebarPan
     canShowRepresentedObject(representedObject)
     {
         return representedObject instanceof WI.Canvas
+            || representedObject instanceof WI.ShaderProgram
             || representedObject instanceof WI.Recording;
     }
 
index 3d663e6..5ee513c 100644 (file)
     display: flex;
     align-items: center;
     position: sticky;
-    top: 0;
+    top: -1px;
     z-index: 1;
     min-height: var(--navigation-bar-height);
+    margin-top: -1px;
     -webkit-padding-start: 8px;
     background-color: hsl(0, 0%, 97%);
-    border-bottom: 1px solid var(--border-color);
-}
-
-.content-view.graphics-overview > section:not(:first-of-type) > .header {
     border-top: 1px solid var(--border-color);
+    border-bottom: 1px solid var(--border-color);
 }
 
 .content-view.graphics-overview > section > .header > h1 {
index 3b20a77..d794df4 100644 (file)
@@ -112,9 +112,7 @@ WI.GraphicsTabContentView = class GraphicsTabContentView extends WI.ContentBrows
     {
         return representedObject instanceof WI.CanvasCollection
             || representedObject instanceof WI.Canvas
-            || representedObject instanceof WI.RecordingCollection
             || representedObject instanceof WI.Recording
-            || representedObject instanceof WI.ShaderProgramCollection
             || representedObject instanceof WI.ShaderProgram
             || representedObject instanceof WI.AnimationCollection
             || representedObject instanceof WI.Animation;