Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the...
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 14 Apr 2013 00:28:18 +0000 (00:28 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 14 Apr 2013 00:28:18 +0000 (00:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=114476

Reviewed by Gyuyoung Kim.

* code-review.js:
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/bugs.webkit.org/ChangeLog
Websites/bugs.webkit.org/code-review.js
Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl
Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl
Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl

index b142e08..6e3bd03 100644 (file)
@@ -1,3 +1,15 @@
+2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
+        https://bugs.webkit.org/show_bug.cgi?id=114476
+
+        Reviewed by Gyuyoung Kim.
+
+        * code-review.js:
+        * template/en/custom/attachment/edit.html.tmpl:
+        * template/en/custom/attachment/list.html.tmpl:
+        * template/en/custom/attachment/reviewform.html.tmpl:
+
 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
 
         Make old EWS bubbles less opaque to disambiguate two set of bubbles.
index d08a320..9045eb0 100644 (file)
@@ -536,7 +536,7 @@ var CODE_REVIEW_UNITTEST;
   }
 
   window.addEventListener('message', function(e) {
-    if (e.origin != 'https://webkit-commit-queue.appspot.com')
+    if (e.origin != 'https://webkit-queues.appspot.com')
       return;
 
     if (e.data.height) {
@@ -546,7 +546,6 @@ var CODE_REVIEW_UNITTEST;
   }, false);
 
   function handleStatusBubbleLoad(e) {
-    e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
     e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.appspot.com');
   }
 
@@ -574,15 +573,6 @@ var CODE_REVIEW_UNITTEST;
       var details = $(data);
       addFlagsForAttachment(details);
 
-      var statusBubble = document.createElement('iframe');
-      statusBubble.className = 'statusBubble';
-      statusBubble.src  = 'https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id;
-      statusBubble.scrolling = 'no';
-      statusBubble.style.opacity = '0.3';
-      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
-      statusBubble.onload = handleStatusBubbleLoad;
-      $('#statusBubbleContainer').append(statusBubble);
-
       statusBubble = document.createElement('iframe');
       statusBubble.className = 'statusBubble';
       statusBubble.src  = 'https://webkit-queues.appspot.com/status-bubble/' + attachment_id;
index c732955..2c24df0 100644 (file)
         <b><small>Bot Status:</small></b>
 
         <div class="statusBubble">
-          <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
-                  style="width: 380px; height: 40px; border: none; opacity: 0.3;" scrolling="no">
-          </iframe>
           <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
-                  style="width: 380px; height: 40px; border: none;" scrolling="no">
+                  style="width: 400px; height: 40px; border: none;" scrolling="no">
           </iframe>
         </div>
         <br>
index b3dac2e..3cdc170 100644 (file)
               [% END %]
             [% END %]
           <div class="statusBubble">
-            <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
-                    style="width: 380px; height: 20px; border: none; opacity: 0.3" scrolling="no">
-            </iframe>
             <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
-                    style="width: 380px; height: 20px; border: none;" scrolling="no">
+                    style="width: 400px; height: 20px; border: none;" scrolling="no">
             </iframe>
           </div>
           [% END %]
index b05e8db..7b210a6 100644 (file)
     <tr>
     <td>
       <div class="statusBubble" style="margin-left: 30px;">
-        <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
-                style="width: 380px; height: 20px; border: none; opacity: 0.3" scrolling="no">
-        </iframe>
         <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
-                style="width: 380px; height: 20px; border: none;" scrolling="no">
+                style="width: 400px; height: 20px; border: none;" scrolling="no">
         </iframe>
       </div>
     </td>