WebRTC tests gardening
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Apr 2017 18:22:38 +0000 (18:22 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Apr 2017 18:22:38 +0000 (18:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170508

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-08
Reviewed by Eric Carlson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Changing webrtc enabling for ios.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

* platform/ios-wk1/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/ios-wk2/TestExpectations
LayoutTests/platform/ios/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

index a04eb12..053b7d0 100644 (file)
@@ -1,5 +1,16 @@
 2017-04-08  Youenn Fablet  <youenn@apple.com>
 
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios-wk1/TestExpectations:
+        * platform/ios-wk2/TestExpectations:
+        * platform/ios/TestExpectations:
+
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
         MediaStreamTrack id should be preserved by PeerConnection
         https://bugs.webkit.org/show_bug.cgi?id=170624
 
index 9ff6a18..648af8e 100644 (file)
@@ -10,6 +10,7 @@ editing/input/focus-change-with-marked-text.html [ Pass ]
 # Skip WebRTC for now in WK1
 imported/w3c/web-platform-tests/webrtc [ Skip ]
 webrtc [ Skip ]
+fast/events/constructors/media-stream-event-constructor.html
 
 # <rdar://problem/6501130> LayoutTests: Enable editing tests after we support editing
 editing/deleting/4922367.html
index 9c4a417..3373d8b 100644 (file)
@@ -1842,6 +1842,10 @@ fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
 
+#See webkit.org/b/170508
+webrtc/video.html [ Failure ]
+webrtc/video-with-receiver.html [ Failure ]
+
 # started to fail after new snapshotting in r202532
 webkit.org/b/150942 animations/multiple-backgrounds.html [ Pass ImageOnlyFailure ]
 compositing/contents-scale/rasterization-scale.html [ ImageOnlyFailure ]
@@ -1921,9 +1925,6 @@ fast/css/deferred-parsing/hover-test.html [ Skip ]
 
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
-imported/w3c/web-platform-tests/webrtc [ Skip ]
-webrtc [ Skip ]
-
 # Skipped because there is no key to show the context menu
 fast/events/context-activated-by-key-event.html [ Skip ]
 
index 142c36a..a9cb22b 100644 (file)
@@ -59,9 +59,6 @@ fast/history/page-cache-closed-audiocontext.html
 fast/history/page-cache-running-audiocontext.html
 fast/history/page-cache-suspended-audiocontext.html
 
-# WebRTC tests are skipped on iOS for now.
-fast/events/constructors/media-stream-event-constructor.html
-
 # No wheel events on iOS
 fast/scrolling/iframe-scrollable-after-back.html [ Skip ]
 fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
index 88671c1..3991c14 100644 (file)
@@ -1,3 +1,12 @@
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-04-07  Keith Miller  <keith_miller@apple.com>
 
         WebAssembly: Fix issue with BrTable targeting a Loop
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 905d079..0b9c509 100644 (file)
@@ -1,5 +1,14 @@
 2017-04-08  Youenn Fablet  <youenn@apple.com>
 
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * Configurations/FeatureDefines.xcconfig: Changing webrtc enabling for ios.
+
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
         MediaStreamTrack id should be preserved by PeerConnection
         https://bugs.webkit.org/show_bug.cgi?id=170624
 
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index e606999..cc3c6de 100644 (file)
@@ -1,3 +1,12 @@
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-04-07  Zan Dobersek  <zdobersek@igalia.com>
 
         [GCrypt] Implement raw and JWK imports and exports for EC keys
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index cb591dd..87009ea 100644 (file)
@@ -1,3 +1,12 @@
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
 
         Unreviewed, rolling out r215046.
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 7333b09..5a18e8f 100644 (file)
@@ -1,3 +1,12 @@
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-04-08  Chris Dumez  <cdumez@apple.com>
 
         Timer's nextFireInterval() / repeatInterval() should return Seconds
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 9d79c60..11b7195 100644 (file)
@@ -1,3 +1,12 @@
+2017-04-08  Youenn Fablet  <youenn@apple.com>
+
+        WebRTC tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+
+        Reviewed by Eric Carlson.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-04-07  Keith Miller  <keith_miller@apple.com>
 
         Add a PriorityQueue class
index a00dddb..50ca059 100644 (file)
@@ -184,9 +184,14 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_10_Production = ;
+ENABLE_WEB_RTC_ios_10_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_10_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;