Improve Document.h compile time - reduce includes of ScriptCallStack.h
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 16 Aug 2012 01:41:37 +0000 (01:41 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 16 Aug 2012 01:41:37 +0000 (01:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=94161

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-15
Reviewed by Eric Seidel.

ScriptCallStack.h no longer included from ScriptExecutionContext. It's
relatively expensive to compile and gets compiled a ton because
Document.h indirectly includes it.

No new tests. Functionality should remain the same

* Modules/indexeddb/IDBDatabase.cpp:
* Modules/indexeddb/IDBIndex.cpp:
* Modules/indexeddb/IDBObjectStore.cpp:
* bindings/js/ScriptController.cpp:
* dom/ScriptElement.cpp:
* dom/ScriptExecutionContext.h:
(WebCore):
* fileapi/Blob.cpp:
* fileapi/WebKitBlobBuilder.cpp:
* html/HTMLTrackElement.cpp:
* loader/TextTrackLoader.cpp:
* page/DOMSecurityPolicy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
Source/WebCore/Modules/indexeddb/IDBIndex.cpp
Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
Source/WebCore/bindings/js/ScriptController.cpp
Source/WebCore/dom/ScriptElement.cpp
Source/WebCore/dom/ScriptExecutionContext.h
Source/WebCore/fileapi/Blob.cpp
Source/WebCore/fileapi/WebKitBlobBuilder.cpp
Source/WebCore/html/HTMLTrackElement.cpp
Source/WebCore/loader/TextTrackLoader.cpp
Source/WebCore/page/DOMSecurityPolicy.cpp

index 1eb8bc9..7bc5936 100644 (file)
@@ -1,3 +1,29 @@
+2012-08-15  Nikhil Bhargava  <nbhargava@google.com>
+
+        Improve Document.h compile time - reduce includes of ScriptCallStack.h
+        https://bugs.webkit.org/show_bug.cgi?id=94161
+
+        Reviewed by Eric Seidel.
+
+        ScriptCallStack.h no longer included from ScriptExecutionContext. It's
+        relatively expensive to compile and gets compiled a ton because
+        Document.h indirectly includes it.
+
+        No new tests. Functionality should remain the same
+
+        * Modules/indexeddb/IDBDatabase.cpp:
+        * Modules/indexeddb/IDBIndex.cpp:
+        * Modules/indexeddb/IDBObjectStore.cpp:
+        * bindings/js/ScriptController.cpp:
+        * dom/ScriptElement.cpp:
+        * dom/ScriptExecutionContext.h:
+        (WebCore):
+        * fileapi/Blob.cpp:
+        * fileapi/WebKitBlobBuilder.cpp:
+        * html/HTMLTrackElement.cpp:
+        * loader/TextTrackLoader.cpp:
+        * page/DOMSecurityPolicy.cpp:
+
 2012-08-15  Alec Flett  <alecflett@chromium.org>
 
         IndexedDB: IDB*::keyPath should return IDBKeyPath, not IDBAny
index b94ffe0..85ba8df 100644 (file)
@@ -43,6 +43,7 @@
 #include "IDBTransaction.h"
 #include "IDBVersionChangeEvent.h"
 #include "IDBVersionChangeRequest.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include <limits>
 
index eae4884..1e02d90 100644 (file)
@@ -37,6 +37,7 @@
 #include "IDBRequest.h"
 #include "IDBTracing.h"
 #include "IDBTransaction.h"
+#include "ScriptCallStack.h"
 
 namespace WebCore {
 
index 20b371b..c30a253 100644 (file)
@@ -41,6 +41,7 @@
 #include "IDBKeyRange.h"
 #include "IDBTracing.h"
 #include "IDBTransaction.h"
+#include "ScriptCallStack.h"
 #include "SerializedScriptValue.h"
 #include <wtf/UnusedParam.h>
 
index 9fa8542..95f039b 100644 (file)
@@ -36,6 +36,7 @@
 #include "Page.h"
 #include "PageGroup.h"
 #include "PluginView.h"
+#include "ScriptCallStack.h"
 #include "ScriptSourceCode.h"
 #include "ScriptValue.h"
 #include "ScriptableDocumentParser.h"
index 9c1654e..62e8230 100644 (file)
@@ -38,6 +38,7 @@
 #include "IgnoreDestructiveWriteCountIncrementer.h"
 #include "MIMETypeRegistry.h"
 #include "Page.h"
+#include "ScriptCallStack.h"
 #include "ScriptRunner.h"
 #include "ScriptSourceCode.h"
 #include "ScriptValue.h"
index 238fa6d..e746803 100644 (file)
@@ -31,7 +31,6 @@
 #include "ActiveDOMObject.h"
 #include "ConsoleTypes.h"
 #include "KURL.h"
-#include "ScriptCallStack.h"
 #include "SecurityContext.h"
 #include "Supplementable.h"
 #include <wtf/Forward.h>
@@ -54,6 +53,7 @@ class EventListener;
 class EventQueue;
 class EventTarget;
 class MessagePort;
+class ScriptCallStack;
 
 #if ENABLE(BLOB)
 class PublicURLManager;
index 1b90712..431f176 100644 (file)
@@ -34,6 +34,7 @@
 #include "BlobURL.h"
 #include "File.h"
 #include "HistogramSupport.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include "ThreadableBlobRegistry.h"
 
index da7ff5e..c08e5fa 100644 (file)
@@ -37,6 +37,7 @@
 #include "File.h"
 #include "HistogramSupport.h"
 #include "LineEnding.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include "TextEncoding.h"
 #include <wtf/ArrayBuffer.h>
index a0c20bf..b31662c 100644 (file)
@@ -34,6 +34,7 @@
 #include "HTMLNames.h"
 #include "Logging.h"
 #include "RuntimeEnabledFeatures.h"
+#include "ScriptCallStack.h"
 #include "ScriptEventListener.h"
 
 using namespace std;
index 7cb9c69..8355a4a 100644 (file)
@@ -35,6 +35,7 @@
 #include "Document.h"
 #include "Logging.h"
 #include "ResourceHandle.h"
+#include "ScriptCallStack.h"
 #include "SecurityOrigin.h"
 #include "SharedBuffer.h"
 #include "WebVTTParser.h"
index ca50483..7a48f52 100644 (file)
@@ -30,6 +30,7 @@
 #include "ContextDestructionObserver.h"
 #include "DOMStringList.h"
 #include "Frame.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include <wtf/text/TextPosition.h>
 #include <wtf/text/WTFString.h>