[GTK] accessibility/editable-webarea-context-menu-point.html is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Dec 2012 08:04:49 +0000 (08:04 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Dec 2012 08:04:49 +0000 (08:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=98364

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Tools:

The test is failing because the clickPoint values remain unchanged. The
values remain unchanged because ATK lacks a means to keep track of this
information.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
(AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details

LayoutTests:

This test seems to be Mac-specific. Therefore, move the test to that
platform and remove the skips from the other platforms.

* platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
* platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
* platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium/TestExpectations
LayoutTests/platform/efl-wk2/TestExpectations
LayoutTests/platform/gtk-wk2/TestExpectations
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt [moved from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt with 100% similarity]
LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html [moved from LayoutTests/accessibility/editable-webarea-context-menu-point.html with 92% similarity]
LayoutTests/platform/win/TestExpectations
LayoutTests/platform/wincairo/TestExpectations
Tools/ChangeLog
Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

index 39cff3d..9f07843 100644 (file)
@@ -1,3 +1,22 @@
+2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] accessibility/editable-webarea-context-menu-point.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98364
+
+        Reviewed by Chris Fleizach.
+
+        This test seems to be Mac-specific. Therefore, move the test to that
+        platform and remove the skips from the other platforms.
+
+        * platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
+        * platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
+        * platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html
+
 2012-12-09  Takashi Sakamoto  <tasak@google.com>
 
         [Shadow DOM]: reset-style-inheritance doesn't work for insertion point
index 1835df5..5829809 100644 (file)
@@ -1405,7 +1405,6 @@ crbug.com/10322 accessibility/aria-used-on-image-maps.html [ Skip ]
 crbug.com/10322 accessibility/button-press-action.html [ Skip ]
 crbug.com/10322 accessibility/deleting-iframe-destroys-axcache.html [ Skip ]
 crbug.com/10322 accessibility/document-attributes.html [ Skip ]
-crbug.com/10322 accessibility/editable-webarea-context-menu-point.html [ Skip ]
 crbug.com/10322 accessibility/iframe-bastardization.html [ Skip ]
 crbug.com/10322 accessibility/image-link.html [ Skip ]
 crbug.com/10322 accessibility/image-map-update-parent-crash.html [ Skip ]
index 16bee7c..da98841 100644 (file)
@@ -232,7 +232,6 @@ accessibility/canvas-accessibilitynodeobject.html [ Skip ]
 accessibility/canvas-fallback-content-2.html [ Skip ]
 accessibility/canvas-fallback-content.html [ Skip ]
 accessibility/disabled-controls-not-focusable.html [ Skip ]
-accessibility/editable-webarea-context-menu-point.html [ Skip ]
 accessibility/ellipsis-text.html [ Skip ]
 accessibility/file-upload-button-with-axpress.html [ Skip ]
 accessibility/hidden-legend.html [ Skip ]
index 9c2a816..3a538c6 100644 (file)
@@ -50,7 +50,6 @@ Bug(GTK) http/tests/security/resources/drag-drop-allowed.html [ Skip ]
 # [GTK] Implement drag and drop support in WebKit2
 # https://bugs.webkit.org/show_bug.cgi?id=63706
 # Implement EditingCallbacks deletegates in the WebKitTestRunner
-webkit.org/b/63706 accessibility/editable-webarea-context-menu-point.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/4947130.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/dataTransfer-setData-getData.html [ Failure Timeout ]
 webkit.org/b/63706 editing/pasteboard/drag-and-drop-image-contenteditable.html [ Failure Timeout ]
index f02601c..202a0e0 100644 (file)
@@ -744,7 +744,6 @@ webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]
 webkit.org/b/98360 accessibility/aria-used-on-image-maps.html [ Failure ]
 webkit.org/b/98361 accessibility/button-press-action.html [ Failure ]
 webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
-webkit.org/b/98364 accessibility/editable-webarea-context-menu-point.html [ Failure ]
 webkit.org/b/98365 accessibility/ellipsis-text.html [ Failure ]
 webkit.org/b/98369 accessibility/language-attribute.html [ Failure ]
 webkit.org/b/98370 accessibility/loading-iframe-sends-notification.html [ Failure ]
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../fast/js/resources/js-test-pre.js"></script>
+<script src="../../../fast/js/resources/js-test-pre.js"></script>
 </head>
 <body id="body" contenteditable>
 This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
@@ -49,6 +49,6 @@ This tests that the click point, used for opening context menus, changes based o
 
 </script>
 
-<script src="../fast/js/resources/js-test-post.js"></script>
+<script src="../../../fast/js/resources/js-test-post.js"></script>
 </body>
 </html>
index 4d05098..ed28e0e 100644 (file)
@@ -618,7 +618,6 @@ accessibility/aria-text-role.html
 accessibility/aria-used-on-image-maps.html
 accessibility/button-press-action.html
 accessibility/document-attributes.html
-accessibility/editable-webarea-context-menu-point.html
 accessibility/hidden-legend.html
 accessibility/ignore-spacer-elements.html
 accessibility/image-link.html
index 46cc1c9..a7d0cd1 100644 (file)
@@ -1146,7 +1146,6 @@ accessibility/aria-text-role.html
 accessibility/aria-used-on-image-maps.html
 accessibility/button-press-action.html
 accessibility/document-attributes.html
-accessibility/editable-webarea-context-menu-point.html
 accessibility/hidden-legend.html
 accessibility/ignore-spacer-elements.html
 accessibility/image-link.html
index 345532c..2323788 100644 (file)
@@ -1,3 +1,18 @@
+2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] accessibility/editable-webarea-context-menu-point.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98364
+
+        Reviewed by Chris Fleizach.
+
+        The test is failing because the clickPoint values remain unchanged. The
+        values remain unchanged because ATK lacks a means to keep track of this
+        information.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
+        (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
+
 2012-12-09  Alejandro PiƱeiro  <apinheiro@igalia.com>
 
         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
index 9d204d4..6ad4026 100644 (file)
@@ -478,11 +478,13 @@ double AccessibilityUIElement::height()
 
 double AccessibilityUIElement::clickPointX()
 {
+    // Note: This is not something we have in ATK.
     return 0.f;
 }
 
 double AccessibilityUIElement::clickPointY()
 {
+    // Note: This is not something we have in ATK.
     return 0.f;
 }