Avoid mixed content when expanding context in code review tool

https://bugs.webkit.org/show_bug.cgi?id=106060

Patch by James Robinson <jamesr@chromium.org> on 2013-01-03
Reviewed by Tony Chang.

Example failure: "The page at https://bugs.webkit.org/attachment.cgi?id=181222&action=review displayed insecure
content from http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/page/EventHandler.cpp?p=138617." This
loads from "//svn.webkit.org/..." so the protocol matches.

* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 98ff4db..d7d2db0 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,16 @@
+2013-01-03  James Robinson  <jamesr@chromium.org>
+
+        Avoid mixed content when expanding context in code review tool
+        https://bugs.webkit.org/show_bug.cgi?id=106060
+
+        Reviewed by Tony Chang.
+
+        Example failure: "The page at https://bugs.webkit.org/attachment.cgi?id=181222&action=review displayed insecure
+        content from http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/page/EventHandler.cpp?p=138617." This
+        loads from "//svn.webkit.org/..." so the protocol matches.
+
+        * code-review.js:
+
 2013-01-02  Ojan Vafai  <ojan@chromium.org>
 
         REGRESSION: Review tool sometimes doesn't include some comments in preview & posts

diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index d2d4bf3..7458baf 100644 (file)
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -506,7 +506,7 @@ div:focus {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=47"></script>
+<script src="code-review.js?version=48"></script>
 </head>
 EOF
 

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 4f61878..16b5d65 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -69,7 +69,7 @@ var CODE_REVIEW_UNITTEST;
   var files = {};
   var original_file_contents = {};
   var patched_file_contents = {};
-  var WEBKIT_BASE_DIR = "http://svn.webkit.org/repository/webkit/trunk/";
+  var WEBKIT_BASE_DIR = "//svn.webkit.org/repository/webkit/trunk/";
   var SIDE_BY_SIDE_DIFFS_KEY = 'sidebysidediffs';
   var g_displayed_draft_comments = false;
   var g_next_line_id = 0;