[Xcode] Never build yasm with ASAN
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Oct 2018 16:07:18 +0000 (16:07 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Oct 2018 16:07:18 +0000 (16:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190327

Reviewed by Youenn Fablet.

Source/ThirdParty/libwebrtc:

* Configurations/yasm.xcconfig: Set WK_ASAN_DISALLOWED to YES.

Tools:

* asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
  the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/ThirdParty/libwebrtc/ChangeLog
Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig
Tools/ChangeLog
Tools/asan/asan.xcconfig

index 93773e0..4092d74 100644 (file)
@@ -1,5 +1,14 @@
 2018-10-06  Dan Bernstein  <mitz@apple.com>
 
+        [Xcode] Never build yasm with ASAN
+        https://bugs.webkit.org/show_bug.cgi?id=190327
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/yasm.xcconfig: Set WK_ASAN_DISALLOWED to YES.
+
+2018-10-06  Dan Bernstein  <mitz@apple.com>
+
         Fixed iOS device production builds after r236896.
 
         * Configurations/yasm.xcconfig: Excluding all sources when building for an iOS device meant
index cb9f60e..4726dfe 100644 (file)
@@ -19,3 +19,5 @@ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macos*] = *_neon.c arm_cpudetect.c *_arm.c sad.c;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphonesimulator*] = *_neon.c arm_cpudetect.c *_arm.c sad.c;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphoneos*] = *_sse2.c *_ssse3.c *_sse4.c *_avx2.c *_avx.c *_sse2.asm.o *_sse3.asm.o;
+
+WK_ASAN_DISALLOWED = YES;
index 93f0ca6..a71ec9d 100644 (file)
@@ -1,3 +1,13 @@
+2018-10-06  Dan Bernstein  <mitz@apple.com>
+
+        [Xcode] Never build yasm with ASAN
+        https://bugs.webkit.org/show_bug.cgi?id=190327
+
+        Reviewed by Youenn Fablet.
+
+        * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
+          the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
+
 2018-10-05  Chris Dumez  <cdumez@apple.com>
 
         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
index 2f669e9..3f04836 100644 (file)
@@ -11,7 +11,9 @@ GCC_OPTIMIZATION_LEVEL_Debug = 0;
 GCC_OPTIMIZATION_LEVEL_Production = 1;
 GCC_OPTIMIZATION_LEVEL_Release = 1;
 
-CLANG_ADDRESS_SANITIZER=YES
+CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_DISALLOWED));
+CLANG_ADDRESS_SANITIZER_ = YES;
+CLANG_ADDRESS_SANITIZER_NO = YES;
 
 ASAN_OTHER_CFLAGS = -fno-omit-frame-pointer -g;
 ASAN_OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CFLAGS);