Update service worker test and expectation after revision 246363
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Jun 2019 15:07:18 +0000 (15:07 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Jun 2019 15:07:18 +0000 (15:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198808

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
Make sure the fetch load finishes so that removing the frame does not cancel the fetch.

LayoutTests:

* TestExpectations:
Skip timing out test in Debug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html

index 0639f0d..3d68309 100644 (file)
@@ -1,3 +1,13 @@
+2019-06-13  Youenn Fablet  <youenn@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * TestExpectations:
+        Skip timing out test in Debug
+
 2019-06-13  Miguel Gomez  <magomez@igalia.com>
 
         Unreviewed GTK+ gardening. Update expectations after r246397.
index 70c85b2..8420200 100644 (file)
@@ -213,6 +213,7 @@ imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-usin
 imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-not-allowed.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Skip ]
+[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Skip ]
 
 # Newly imported service worker tests that are flaky.
 imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https.html [ Pass Failure ]
@@ -281,7 +282,6 @@ imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-res
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-order.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Slow ]
-[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/multiple-update.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html [ Slow ]
index 9534b3f..b515fbb 100644 (file)
@@ -1,3 +1,14 @@
+2019-06-13  Youenn Fablet  <youenn@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
+        Make sure the fetch load finishes so that removing the frame does not cancel the fetch.
+
 2019-06-12  Youenn Fablet  <youenn@apple.com>
 
         Update WPT service workers test up to 0df7c68
index ae64fcb..d9147f8 100644 (file)
@@ -44,10 +44,12 @@ async function do_test(url) {
   assert_equals(response, 'messageHandlerInitialized');
 
   // Start a fetch.
-  frame.contentWindow.fetch(url);
+  const fetchPromise = frame.contentWindow.fetch(url);
 
   // Receive the test result from the service worker.
-  return wait_for_message();
+  const result = wait_for_message();
+  await fetchPromise.then(()=> {}, () => {});
+  return result;
 };
 
 promise_test(async (t) => {