[mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Apr 2017 06:38:37 +0000 (06:38 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Apr 2017 06:38:37 +0000 (06:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170953

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-04-25
Reviewed by Brian Burg.

* http/tests/inspector/network/resource-sizes-disk-cache.html:
* http/tests/inspector/network/resource-sizes-network.html:
Read the entire data to ensure the load is complete before we notify the frontend.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
Unflake these tests, they should be more reliable now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/inspector/network/resource-sizes-disk-cache.html
LayoutTests/http/tests/inspector/network/resource-sizes-network.html
LayoutTests/platform/mac-wk1/TestExpectations
LayoutTests/platform/mac-wk2/TestExpectations

index 9cafb1f..935dd58 100644 (file)
@@ -1,3 +1,18 @@
+2017-04-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=170953
+
+        Reviewed by Brian Burg.
+
+        * http/tests/inspector/network/resource-sizes-disk-cache.html:
+        * http/tests/inspector/network/resource-sizes-network.html:
+        Read the entire data to ensure the load is complete before we notify the frontend.
+
+        * platform/mac-wk1/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        Unflake these tests, they should be more reliable now.
+
 2017-04-25  Youenn Fablet  <youenn@apple.com>
 
         fast/mediastream/RTCPeerConnection-icecandidate-event.html is flaky
index 75094cb..28be574 100644 (file)
@@ -7,7 +7,7 @@
 <script src="resources/resource-size-test.js"></script>
 <script>
 function loadAndTriggerInspector(url) {
-    fetch(url).then(() => {
+    fetch(url).then((response) => response.blob()).then(() => {
         TestPage.dispatchEventToFrontend("LoadComplete");
     });
 }
index f579cfd..8bbf8c4 100644 (file)
@@ -18,6 +18,8 @@ function triggerNetworkLoadWithRequestData() {
             "X-Header-2": headerString512Bytes, // 512 + 10 + ":" + "\r\n" whitespace
         },
         body: headerString512Bytes + headerString512Bytes + "abc" // (512 + 512 + 3) = 1027.
+    }).then((response) => {
+        return response.text();
     }).then(() => {
         TestPage.dispatchEventToFrontend("LoadComplete");
     });
index 4b5ec6e..61c4186 100644 (file)
@@ -313,8 +313,6 @@ imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html [ Failur
 imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html [ Failure ]
 http/tests/inspector/network/resource-request-headers.html [ Failure ]
 
-webkit.org/b/170953 http/tests/inspector/network/resource-sizes-network.html [ Pass Failure ]
-
 webkit.org/b/164491 [ Yosemite ElCapitan ] fast/visual-viewport/rtl-zoomed-rects.html [ Failure ]
 
 webkit.org/b/164933 http/tests/misc/link-rel-icon-beforeload.html [ Failure ]
index 8272afd..50abb92 100644 (file)
@@ -543,8 +543,6 @@ webkit.org/b/160445 [ Sierra+ ] http/tests/security/contentSecurityPolicy/upgrad
 
 webkit.org/b/159447 [ Debug ] inspector/debugger/tail-deleted-frames-from-vm-entry.html [ Pass Failure ]
 
-webkit.org/b/170971 http/tests/inspector/network/resource-sizes-disk-cache.html [ Pass Failure ]
-
 webkit.org/b/167607 [ Debug ] http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html [ Pass Timeout ]
 
 webkit.org/b/159884 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Pass Failure ]