Fix API tests after r235139
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Aug 2018 23:50:29 +0000 (23:50 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Aug 2018 23:50:29 +0000 (23:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188805

Apparently the call to didChangeBackForwardList with no changes was observable.  We should rename, but I'm restoring existing behavior for now.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::goToItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebBackForwardList.cpp

index 897dd05..a438231 100644 (file)
@@ -1,3 +1,13 @@
+2018-08-21  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API tests after r235139
+        https://bugs.webkit.org/show_bug.cgi?id=188805
+
+        Apparently the call to didChangeBackForwardList with no changes was observable.  We should rename, but I'm restoring existing behavior for now.
+
+        * UIProcess/WebBackForwardList.cpp:
+        (WebKit::WebBackForwardList::goToItem):
+
 2018-08-21  John Wilander  <wilander@apple.com>
 
         Storage Access API: The call to ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal() should send eTLD+1s, not full host names
index decb48a..98aec98 100644 (file)
@@ -201,6 +201,7 @@ void WebBackForwardList::goToItem(WebBackForwardListItem& item)
     m_currentIndex = targetIndex;
 
     LOG(BackForward, "(Back/Forward) WebBackForwardList %p going to item %s, is now at index %zu", this, item.itemID().logString(), targetIndex);
+    m_page->didChangeBackForwardList(nullptr, { });
 }
 
 WebBackForwardListItem* WebBackForwardList::currentItem() const