Add a comment to make my test from r244139 less mysterious.
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Apr 2019 17:41:32 +0000 (17:41 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Apr 2019 17:41:32 +0000 (17:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196744

As suggested by Darin Adler.

* TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm

index 9e36bfc..08ea44a 100644 (file)
@@ -1,3 +1,13 @@
+2019-04-17  Alex Christensen  <achristensen@webkit.org>
+
+        Add a comment to make my test from r244139 less mysterious.
+        https://bugs.webkit.org/show_bug.cgi?id=196744
+
+        As suggested by Darin Adler.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
+        (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+
 2019-04-17  Chris Dumez  <cdumez@apple.com>
 
         Remember device orientation permission for the duration of the browsing session
index 5ef3c83..3294d52 100644 (file)
@@ -37,6 +37,9 @@
 - (void)webProcessPlugIn:(WKWebProcessPlugInController *)plugInController didCreateBrowserContextController:(WKWebProcessPlugInBrowserContextController *)browserContextController
 {
     dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0.5 * NSEC_PER_SEC), dispatch_get_main_queue(), [retainedPage = retainPtr(browserContextController)] { });
+
+    // Instantiate a _WKRemoteObjectRegistry to test that its existence does not conflict with the existence
+    // of the _WKRemoteObjectRegistry from the other WebPage that will be in this process.
     [browserContextController _remoteObjectRegistry];
 }