[WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an...
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 May 2016 00:00:06 +0000 (00:00 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 May 2016 00:00:06 +0000 (00:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157497
<rdar://problem/25872773>

Reviewed by Anders Carlsson.

* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
r198578 fixed this for WebKit2, but forgot about WebKit1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebImmediateActionController.mm

index 160dd78..0ea9faf 100644 (file)
@@ -1,3 +1,15 @@
+2016-05-09  Tim Horton  <timothy_horton@apple.com>
+
+        [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
+        https://bugs.webkit.org/show_bug.cgi?id=157497
+        <rdar://problem/25872773>
+
+        Reviewed by Anders Carlsson.
+
+        * WebView/WebImmediateActionController.mm:
+        (-[WebImmediateActionController _defaultAnimationController]):
+        r198578 fixed this for WebKit2, but forgot about WebKit1.
+
 2016-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
 
         [OS X] Migrate our Font classes entirely off of NSFont
index e34e7e4..94f72f4 100644 (file)
@@ -278,7 +278,7 @@ using namespace WebCore;
             _type = WebImmediateActionLinkPreview;
 
             RefPtr<Range> linkRange = rangeOfContents(*_hitTestResult.URLElement());
-            auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionDefault, TextIndicatorPresentationTransition::FadeIn);
+            auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges, TextIndicatorPresentationTransition::FadeIn);
             if (indicator)
                 [_webView _setTextIndicator:*indicator withLifetime:TextIndicatorWindowLifetime::Permanent];