WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
authorjberlin@webkit.org <jberlin@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 May 2012 01:12:57 +0000 (01:12 +0000)
committerjberlin@webkit.org <jberlin@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 May 2012 01:12:57 +0000 (01:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=64313

Reviewed by Jon Honeycutt.

Tools:

Add it.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Make sure to generate the binding.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setDefersLoading):
Call WKBundlePageSetDefersLoading.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

* platform/wk2/Skipped:
Remove a test that uses setDefersLoading from the WK2 Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/wk2/Skipped
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h

index 95cee64..63609c9 100644 (file)
@@ -1,5 +1,15 @@
 2012-05-22  Jessie Berlin  <jberlin@apple.com>
 
+        WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=64313
+
+        Reviewed by Jon Honeycutt.
+
+        * platform/wk2/Skipped:
+        Remove a test that uses setDefersLoading from the WK2 Skipped list.
+
+2012-05-22  Jessie Berlin  <jberlin@apple.com>
+
         [Mac WK2] platform/mac-wk2/plugins/mouse-events-scaled.html failing
         https://bugs.webkit.org/show_bug.cgi?id=87182
 
index c8735d3..daaea75 100644 (file)
@@ -790,10 +790,6 @@ editing/pasteboard/drag-files-to-editable-element.html
 # https://bugs.webkit.org/show_bug.cgi?id=63806
 http/tests/cache/history-only-cached-subresource-loads-max-age-https.html
 
-# WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
-# https://bugs.webkit.org/show_bug.cgi?id=64313
-loader/load-defer-resume-crash.html
-
 # [WK2] New tests introduced in 100895 fail
 # https://bugs.webkit.org/show_bug.cgi?id=73913
 http/tests/security/referrer-policy-https-always.html
index b95dfa4..cbf5f38 100644 (file)
@@ -1,3 +1,20 @@
+2012-05-22  Jessie Berlin  <jberlin@apple.com>
+
+        WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=64313
+
+        Reviewed by Jon Honeycutt.
+
+        Add it.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
+        Make sure to generate the binding.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR::LayoutTestController::setDefersLoading):
+        Call WKBundlePageSetDefersLoading.
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+
 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
 
         [Chromium-Android] Run DumpRenderTree as an apk (python part)
index c3f9046..5e52ee8 100644 (file)
@@ -127,6 +127,8 @@ module WTR {
         void setWillSendRequestReturnsNull(in boolean flag);
         
         void setShouldStayOnPageAfterHandlingBeforeUnload(in boolean flag);
+
+        void setDefersLoading(in boolean flag);
         
         // Focus testing.
         void addChromeInputField(in object callback);
index 6ec6f5f..250fa5c 100644 (file)
@@ -543,6 +543,11 @@ void LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload(bool sho
     InjectedBundle::shared().postNewBeforeUnloadReturnValue(!shouldStayOnPage);
 }
 
+void LayoutTestController::setDefersLoading(bool shouldDeferLoading)
+{
+    WKBundlePageSetDefersLoading(InjectedBundle::shared().page()->page(), shouldDeferLoading);
+}
+
 void LayoutTestController::setPageVisibility(JSStringRef state)
 {
     WebCore::PageVisibilityState visibilityState = WebCore::PageVisibilityStateVisible;
index d9a34d6..8ca09f6 100644 (file)
@@ -184,6 +184,8 @@ public:
     void setTextDirection(JSStringRef);
 
     void setShouldStayOnPageAfterHandlingBeforeUnload(bool);
+
+    void setDefersLoading(bool);
     
     bool globalFlag() const { return m_globalFlag; }
     void setGlobalFlag(bool value) { m_globalFlag = value; }