2010-09-12 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Sep 2010 06:43:31 +0000 (06:43 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Sep 2010 06:43:31 +0000 (06:43 +0000)
        Reviewed by Eric Seidel.

        Remove FIXME now that the HTML5 spec has been updated
        https://bugs.webkit.org/show_bug.cgi?id=45634

        Add tests recommended by Hixie.

        * fast/parser/form-pointer-1-expected.txt: Added.
        * fast/parser/form-pointer-1.html: Added.
        * fast/parser/form-pointer-2-expected.txt: Added.
        * fast/parser/form-pointer-2.html: Added.
        * fast/parser/form-pointer-3-expected.txt: Added.
        * fast/parser/form-pointer-3.html: Added.
        * fast/parser/form-pointer-4-expected.txt: Added.
        * fast/parser/form-pointer-4.html: Added.
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FIXME now that the HTML5 spec has been updated
        https://bugs.webkit.org/show_bug.cgi?id=45634

        The spec changed to say what we do here so this FIXME isn't needed
        anymore.

        Tests: fast/parser/form-pointer-1.html
               fast/parser/form-pointer-2.html
               fast/parser/form-pointer-3.html
               fast/parser/form-pointer-4.html

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/parser/form-pointer-1-expected.txt [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-1.html [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-2-expected.txt [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-2.html [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-3-expected.txt [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-3.html [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-4-expected.txt [new file with mode: 0644]
LayoutTests/fast/parser/form-pointer-4.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/html/parser/HTMLTreeBuilder.cpp

index 4339b0d..f917e1f 100644 (file)
@@ -1,3 +1,21 @@
+2010-09-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove FIXME now that the HTML5 spec has been updated
+        https://bugs.webkit.org/show_bug.cgi?id=45634
+
+        Add tests recommended by Hixie.
+
+        * fast/parser/form-pointer-1-expected.txt: Added.
+        * fast/parser/form-pointer-1.html: Added.
+        * fast/parser/form-pointer-2-expected.txt: Added.
+        * fast/parser/form-pointer-2.html: Added.
+        * fast/parser/form-pointer-3-expected.txt: Added.
+        * fast/parser/form-pointer-3.html: Added.
+        * fast/parser/form-pointer-4-expected.txt: Added.
+        * fast/parser/form-pointer-4.html: Added.
+
 2010-09-12  Robin Qiu  <robin.qiu@torchmobile.com.cn>
 
         Reviewed by Antonio Gomes.
diff --git a/LayoutTests/fast/parser/form-pointer-1-expected.txt b/LayoutTests/fast/parser/form-pointer-1-expected.txt
new file mode 100644 (file)
index 0000000..69cfc5a
--- /dev/null
@@ -0,0 +1,2 @@
+PASS
+
diff --git a/LayoutTests/fast/parser/form-pointer-1.html b/LayoutTests/fast/parser/form-pointer-1.html
new file mode 100644 (file)
index 0000000..b475fc4
--- /dev/null
@@ -0,0 +1,10 @@
+<script>
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
+</script>
+<table>
+<form onsubmit="document.write('PASS'); return false">
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-2-expected.txt b/LayoutTests/fast/parser/form-pointer-2-expected.txt
new file mode 100644 (file)
index 0000000..660b40f
--- /dev/null
@@ -0,0 +1 @@
+ PASS
diff --git a/LayoutTests/fast/parser/form-pointer-2.html b/LayoutTests/fast/parser/form-pointer-2.html
new file mode 100644 (file)
index 0000000..d4965cc
--- /dev/null
@@ -0,0 +1,11 @@
+<script>
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
+</script>
+<table>
+<form onsubmit="document.write('PASS'); return false">
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-3-expected.txt b/LayoutTests/fast/parser/form-pointer-3-expected.txt
new file mode 100644 (file)
index 0000000..370cf91
--- /dev/null
@@ -0,0 +1,2 @@
+
+ PASS PASS
diff --git a/LayoutTests/fast/parser/form-pointer-3.html b/LayoutTests/fast/parser/form-pointer-3.html
new file mode 100644 (file)
index 0000000..8a487de
--- /dev/null
@@ -0,0 +1,14 @@
+<script>
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
+</script>
+<form onsubmit="document.writeln('PASS'); return false">
+<table>
+<form onsubmit="document.writeln('FAIL'); return false">
+<input type=submit>
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+document.getElementsByTagName('input')[1].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-4-expected.txt b/LayoutTests/fast/parser/form-pointer-4-expected.txt
new file mode 100644 (file)
index 0000000..a6cc104
--- /dev/null
@@ -0,0 +1,2 @@
+
+ ALPHA BETA BETA
diff --git a/LayoutTests/fast/parser/form-pointer-4.html b/LayoutTests/fast/parser/form-pointer-4.html
new file mode 100644 (file)
index 0000000..dc92f4d
--- /dev/null
@@ -0,0 +1,17 @@
+<script>
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
+</script>
+<form onsubmit="document.writeln('ALPHA'); return false">
+<table>
+<input type=submit>
+</form>
+<form onsubmit="document.writeln('BETA'); return false">
+<input type=submit>
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+document.getElementsByTagName('input')[1].click();
+document.getElementsByTagName('input')[2].click();
+</script>
index 39d65b3..1731c7e 100644 (file)
@@ -1,3 +1,21 @@
+2010-09-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove FIXME now that the HTML5 spec has been updated
+        https://bugs.webkit.org/show_bug.cgi?id=45634
+
+        The spec changed to say what we do here so this FIXME isn't needed
+        anymore.
+
+        Tests: fast/parser/form-pointer-1.html
+               fast/parser/form-pointer-2.html
+               fast/parser/form-pointer-3.html
+               fast/parser/form-pointer-4.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processStartTagForInTable):
+
 2010-09-12  Robin Qiu  <robin.qiu@torchmobile.com.cn>
 
         Reviewed by Antonio Gomes.
index 7cd9f34..1f1e58b 100644 (file)
@@ -1132,8 +1132,6 @@ void HTMLTreeBuilder::processStartTagForInTable(AtomicHTMLToken& token)
         parseError(token);
         if (m_tree.form())
             return;
-        // FIXME: This deviates from the spec:
-        //        http://www.w3.org/Bugs/Public/show_bug.cgi?id=10216
         m_tree.insertHTMLFormElement(token, true);
         m_tree.openElements()->pop();
         return;