Update autoscroll test to lift at the end and be less flakey
authormegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Apr 2019 04:18:25 +0000 (04:18 +0000)
committermegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Apr 2019 04:18:25 +0000 (04:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197084

Test not lifting at the end caused issues for other tests.
Also the positions were a bit too exact and caused the
test to be flakey. These new positions should result in more consistent
behaviour.

Reviewed by Tim Horton.

* fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html

index a256ff6..8eb01a2 100644 (file)
@@ -1,3 +1,17 @@
+2019-04-18  Megan Gardner  <megan_gardner@apple.com>
+
+        Update autoscroll test to lift at the end and be less flakey
+        https://bugs.webkit.org/show_bug.cgi?id=197084
+
+        Test not lifting at the end caused issues for other tests.
+        Also the positions were a bit too exact and caused the
+        test to be flakey. These new positions should result in more consistent
+        behaviour.
+
+        Reviewed by Tim Horton.
+
+        * fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:
+
 2019-04-18  Justin Fan  <justin_fan@apple.com>
 
         [WebGPU] Implement API default values
index b842f4a..f44b7df 100644 (file)
@@ -28,8 +28,9 @@
             await didShowKeyboard();
             await longPressAndHoldAtPoint(tapPointX, tapPointY);
             await continueTouchAndDragFromPointToPoint(tapPointX, tapPointY, dragX, tapPointY);
-            await holdAtPoint(dragX, tapPointY, 2.0);
-            await continueTouchAndDragFromPointToPoint(dragX, tapPointY, dragX + 5, tapPointY);
+            await holdAtPoint(dragX, tapPointY + 20, 1.0);
+            await continueTouchAndDragFromPointToPoint(dragX, tapPointY + 20, dragX + 5, tapPointY + 20);
+            await liftUpAtPoint(dragX + 5, tapPointY + 20);
             if (scrollBox.scrollLeft > 0)
                 output += 'PASS: Text Box has been scrolled.';
             else