+2014-01-20 Joseph Pecoraro <pecoraro@apple.com>
+
+ Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
+ https://bugs.webkit.org/show_bug.cgi?id=127206
+
+ Reviewed by Anders Carlsson.
+
+ Let clang-modernize add overrides.
+
+ * inspector/DOMEditor.cpp:
+ * inspector/InspectorApplicationCacheAgent.h:
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorCanvasAgent.h:
+ * inspector/InspectorConsoleAgent.h:
+ * inspector/InspectorDOMAgent.h:
+ * inspector/InspectorDOMDebuggerAgent.h:
+ * inspector/InspectorDOMStorageAgent.h:
+ * inspector/InspectorDatabaseAgent.cpp:
+ * inspector/InspectorDatabaseAgent.h:
+ * inspector/InspectorDebuggerAgent.h:
+ * inspector/InspectorFrontendHost.cpp:
+ * inspector/InspectorHeapProfilerAgent.cpp:
+ (WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
+ (WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
+ * inspector/InspectorHeapProfilerAgent.h:
+ * inspector/InspectorHistory.cpp:
+ * inspector/InspectorIndexedDBAgent.cpp:
+ * inspector/InspectorIndexedDBAgent.h:
+ * inspector/InspectorInputAgent.h:
+ * inspector/InspectorLayerTreeAgent.h:
+ * inspector/InspectorMemoryAgent.h:
+ * inspector/InspectorPageAgent.h:
+ * inspector/InspectorProfilerAgent.cpp:
+ * inspector/InspectorProfilerAgent.h:
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorRuntimeAgent.h:
+ * inspector/InspectorStyleSheet.h:
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/InspectorWorkerAgent.cpp:
+ * inspector/InspectorWorkerAgent.h:
+ * inspector/PageConsoleAgent.h:
+ * inspector/PageDebuggerAgent.h:
+ * inspector/PageRuntimeAgent.h:
+ * inspector/WorkerConsoleAgent.h:
+ * inspector/WorkerDebuggerAgent.cpp:
+ * inspector/WorkerInspectorController.cpp:
+ * inspector/WorkerRuntimeAgent.h:
+
2014-01-20 Zan Dobersek <zdobersek@igalia.com>
Move WebAudio source code to std::unique_ptr
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_anchorNode = m_node->nextSibling();
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
return m_parentNode->removeChild(m_node.get(), ec);
}
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
if (m_node->parentNode()) {
m_removeChildAction = adoptPtr(new RemoveChildAction(m_node->parentNode(), m_node.get()));
return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
if (!m_parentNode->removeChild(m_node.get(), ec))
return false;
return true;
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
if (m_removeChildAction && !m_removeChildAction->redo(ec))
return false;
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_value = m_element->getAttribute(m_name);
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
m_element->setAttribute(m_name, m_value, ec);
return true;
}
- virtual bool redo(ExceptionCode&)
+ virtual bool redo(ExceptionCode&) override
{
m_element->removeAttribute(m_name);
return true;
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_hadAttribute = m_element->hasAttribute(m_name);
if (m_hadAttribute)
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
if (m_hadAttribute)
m_element->setAttribute(m_name, m_oldValue, ec);
return true;
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
m_element->setAttribute(m_name, m_value, ec);
return true;
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_oldHTML = createMarkup(m_node.get());
DOMPatchSupport domPatchSupport(m_domEditor.get(), &m_node->document());
return !ec;
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
return m_history->undo(ec);
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
return m_history->redo(ec);
}
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_oldText = m_textNode->wholeText();
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
m_textNode->replaceWholeText(m_oldText, ec);
return true;
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
m_textNode->replaceWholeText(m_text, ec);
return true;
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
return m_parentNode->replaceChild(m_oldNode, m_newNode.get(), ec);
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
return m_parentNode->replaceChild(m_newNode, m_oldNode.get(), ec);
}
{
}
- virtual bool perform(ExceptionCode& ec)
+ virtual bool perform(ExceptionCode& ec) override
{
m_oldValue = m_node->nodeValue();
return redo(ec);
}
- virtual bool undo(ExceptionCode& ec)
+ virtual bool undo(ExceptionCode& ec) override
{
m_node->setNodeValue(m_oldValue, ec);
return !ec;
}
- virtual bool redo(ExceptionCode& ec)
+ virtual bool redo(ExceptionCode& ec) override
{
m_node->setNodeValue(m_value, ec);
return !ec;
void updateApplicationCacheStatus(Frame*);
void networkStateChanged();
- virtual void enable(ErrorString*);
- virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result);
- virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL);
- virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&);
+ virtual void enable(ErrorString*) override;
+ virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result) override;
+ virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL) override;
+ virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&) override;
private:
PassRefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);
bool forcePseudoState(Element*, CSSSelector::PseudoType);
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void discardAgent();
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
+ virtual void discardAgent() override;
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
void reset();
void mediaQueryResultChanged();
void didCreateNamedFlow(Document*, WebKitNamedFlow*);
void didRegisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
void didUnregisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement);
- virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&);
- virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes);
- virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries);
- virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos);
- virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result);
- virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result);
- virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text);
- virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
- virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
- virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
- virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result);
- virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses);
- virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result);
+ virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&) override;
+ virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes) override;
+ virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries) override;
+ virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos) override;
+ virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result) override;
+ virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result) override;
+ virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text) override;
+ virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
+ virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
+ virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
+ virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result) override;
+ virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses) override;
+ virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result) override;
private:
class StyleSheetAction;
PassRefPtr<Inspector::TypeBuilder::CSS::NamedFlow> buildObjectForNamedFlow(ErrorString*, WebKitNamedFlow*, int documentNodeId);
// InspectorDOMAgent::DOMListener implementation
- virtual void didRemoveDocument(Document*);
- virtual void didRemoveDOMNode(Node*);
- virtual void didModifyDOMAttr(Element*);
+ virtual void didRemoveDocument(Document*) override;
+ virtual void didRemoveDOMNode(Node*) override;
+ virtual void didModifyDOMAttr(Element*) override;
// InspectorCSSAgent::Listener implementation
- virtual void styleSheetChanged(InspectorStyleSheet*);
+ virtual void styleSheetChanged(InspectorStyleSheet*) override;
void resetPseudoStates();
#endif
// Called from the front-end.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
- virtual void hasUninstrumentedCanvases(ErrorString*, bool*);
- virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
- virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
- virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
- virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&);
- virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
- virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&);
- virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
+ virtual void hasUninstrumentedCanvases(ErrorString*, bool*) override;
+ virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
+ virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
+ virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
+ virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&) override;
+ virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
+ virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&) override;
+ virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
private:
InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, JSC::ExecState*);
InspectorConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*);
virtual ~InspectorConsoleAgent();
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void clearMessages(ErrorString*);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void clearMessages(ErrorString*) override;
bool enabled() const { return m_enabled; }
void reset();
void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
void addStartProfilingMessageToConsole(const String& title, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
#endif
- virtual void setMonitoringXHREnabled(ErrorString*, bool enabled);
+ virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override;
virtual void addInspectedNode(ErrorString*, int nodeId) = 0;
- virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId);
+ virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override;
virtual bool isWorkerAgent() = 0;
void reset();
// Methods called from the frontend for DOM nodes inspection.
- virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId);
- virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result);
- virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root);
- virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth);
- virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value);
- virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name);
- virtual void removeAttribute(ErrorString*, int elementId, const String& name);
- virtual void removeNode(ErrorString*, int nodeId);
- virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId);
- virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML);
- virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML);
- virtual void setNodeValue(ErrorString*, int nodeId, const String& value);
- virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray);
- virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount);
- virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&);
- virtual void discardSearchResults(ErrorString*, const String& searchId);
- virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result);
- virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig);
- virtual void requestNode(ErrorString*, const String& objectId, int* nodeId);
- virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId);
- virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId);
- virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup);
- virtual void hideHighlight(ErrorString*);
- virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
- virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
- virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId);
- virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor);
-
- virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId);
- virtual void undo(ErrorString*);
- virtual void redo(ErrorString*);
- virtual void markUndoableState(ErrorString*);
- virtual void focus(ErrorString*, int nodeId);
+ virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
+ virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result) override;
+ virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root) override;
+ virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
+ virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
+ virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
+ virtual void removeAttribute(ErrorString*, int elementId, const String& name) override;
+ virtual void removeNode(ErrorString*, int nodeId) override;
+ virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
+ virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
+ virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
+ virtual void setNodeValue(ErrorString*, int nodeId, const String& value) override;
+ virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray) override;
+ virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount) override;
+ virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&) override;
+ virtual void discardSearchResults(ErrorString*, const String& searchId) override;
+ virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result) override;
+ virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig) override;
+ virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
+ virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
+ virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId) override;
+ virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup) override;
+ virtual void hideHighlight(ErrorString*) override;
+ virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
+ virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
+ virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId) override;
+ virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor) override;
+
+ virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
+ virtual void undo(ErrorString*) override;
+ virtual void redo(ErrorString*) override;
+ virtual void markUndoableState(ErrorString*) override;
+ virtual void focus(ErrorString*, int nodeId) override;
void getEventListeners(Node*, Vector<EventListenerInfo>& listenersArray, bool includeAncestors);
virtual ~InspectorDOMDebuggerAgent();
// DOMDebugger API
- virtual void setXHRBreakpoint(ErrorString*, const String& url);
- virtual void removeXHRBreakpoint(ErrorString*, const String& url);
- virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type);
- virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type);
+ virtual void setXHRBreakpoint(ErrorString*, const String& url) override;
+ virtual void removeXHRBreakpoint(ErrorString*, const String& url) override;
+ virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
+ virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
// InspectorInstrumentation API
void willInsertDOMNode(Node* parent);
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void discardAgent();
+ virtual void discardAgent() override;
private:
// InspectorDebuggerAgent::Listener implementation.
- virtual void debuggerWasEnabled();
- virtual void debuggerWasDisabled();
- virtual void stepInto();
- virtual void didPause();
+ virtual void debuggerWasEnabled() override;
+ virtual void debuggerWasDisabled() override;
+ virtual void stepInto() override;
+ virtual void didPause() override;
void disable();
void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, Inspector::InspectorObject* description);
virtual void willDestroyFrontendAndBackend() override;
// Called from the front-end.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items);
- virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value);
- virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items) override;
+ virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value) override;
+ virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key) override;
// Called from the injected script.
String storageId(Storage*);
virtual ~StatementCallback() { }
- virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet)
+ virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
{
SQLResultSetRowList* rowList = resultSet->rows();
virtual ~StatementErrorCallback() { }
- virtual bool handleEvent(SQLTransaction*, SQLError* error)
+ virtual bool handleEvent(SQLTransaction*, SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
virtual ~TransactionCallback() { }
- virtual bool handleEvent(SQLTransaction* transaction)
+ virtual bool handleEvent(SQLTransaction* transaction) override
{
if (!m_requestCallback->isActive())
return true;
virtual ~TransactionErrorCallback() { }
- virtual bool handleEvent(SQLError* error)
+ virtual bool handleEvent(SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
virtual ~TransactionSuccessCallback() { }
- virtual bool handleEvent() { return false; }
+ virtual bool handleEvent() override { return false; }
private:
TransactionSuccessCallback() { }
void clearResources();
// Called from the front-end.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names);
- virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names) override;
+ virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>) override;
// Called from the injected script.
String databaseId(Database*);
void addMessageToConsole(MessageSource, MessageType);
// Part of the protocol.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void setBreakpointsActive(ErrorString*, bool active);
-
- virtual void setBreakpointByUrl(ErrorString*, int lineNumber, const String* optionalURL, const String* optionalURLRegex, const int* optionalColumnNumber, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::Location>>& locations, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
- virtual void setBreakpoint(ErrorString*, const RefPtr<Inspector::InspectorObject>& location, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Debugger::Location>& actualLocation, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
- virtual void removeBreakpoint(ErrorString*, const String& breakpointIdentifier);
- virtual void continueToLocation(ErrorString*, const RefPtr<Inspector::InspectorObject>& location);
-
- virtual void searchInContent(ErrorString*, const String& scriptID, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
- virtual void getScriptSource(ErrorString*, const String& scriptID, String* scriptSource);
- virtual void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<Inspector::TypeBuilder::Debugger::FunctionDetails>&);
- virtual void pause(ErrorString*);
- virtual void resume(ErrorString*);
- virtual void stepOver(ErrorString*);
- virtual void stepInto(ErrorString*);
- virtual void stepOut(ErrorString*);
- virtual void setPauseOnExceptions(ErrorString*, const String& pauseState);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void setBreakpointsActive(ErrorString*, bool active) override;
+
+ virtual void setBreakpointByUrl(ErrorString*, int lineNumber, const String* optionalURL, const String* optionalURLRegex, const int* optionalColumnNumber, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::Location>>& locations, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers) override;
+ virtual void setBreakpoint(ErrorString*, const RefPtr<Inspector::InspectorObject>& location, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Debugger::Location>& actualLocation, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers) override;
+ virtual void removeBreakpoint(ErrorString*, const String& breakpointIdentifier) override;
+ virtual void continueToLocation(ErrorString*, const RefPtr<Inspector::InspectorObject>& location) override;
+
+ virtual void searchInContent(ErrorString*, const String& scriptID, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&) override;
+ virtual void getScriptSource(ErrorString*, const String& scriptID, String* scriptSource) override;
+ virtual void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<Inspector::TypeBuilder::Debugger::FunctionDetails>&) override;
+ virtual void pause(ErrorString*) override;
+ virtual void resume(ErrorString*) override;
+ virtual void stepOver(ErrorString*) override;
+ virtual void stepInto(ErrorString*) override;
+ virtual void stepOut(ErrorString*) override;
+ virtual void setPauseOnExceptions(ErrorString*, const String& pauseState) override;
virtual void evaluateOnCallFrame(ErrorString*,
const String& callFrameId,
const String& expression,
const bool* returnByValue,
const bool* generatePreview,
RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
- virtual void setOverlayMessage(ErrorString*, const String*);
+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
+ virtual void setOverlayMessage(ErrorString*, const String*) override;
void schedulePauseOnNextStatement(Inspector::InspectorDebuggerFrontendDispatcher::Reason::Enum breakReason, PassRefPtr<Inspector::InspectorObject> data);
void cancelPauseOnNextStatement();
virtual void enable();
virtual void disable();
- virtual void didPause(JSC::ExecState*, const Deprecated::ScriptValue& callFrames, const Deprecated::ScriptValue& exception);
- virtual void didContinue();
+ virtual void didPause(JSC::ExecState*, const Deprecated::ScriptValue& callFrames, const Deprecated::ScriptValue& exception) override;
+ virtual void didContinue() override;
void didClearGlobalObject();
private:
contextMenuCleared();
}
- virtual void populateContextMenu(ContextMenu* menu)
+ virtual void populateContextMenu(ContextMenu* menu) override
{
for (size_t i = 0; i < m_items.size(); ++i)
menu->appendItem(m_items[i]);
}
- virtual void contextMenuItemSelected(ContextMenuItem* item)
+ virtual void contextMenuItemSelected(ContextMenuItem* item) override
{
if (m_frontendHost) {
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
}
}
- virtual void contextMenuCleared()
+ virtual void contextMenuCleared() override
{
if (m_frontendHost) {
Deprecated::ScriptFunctionCall function(m_frontendApiObject, "contextMenuCleared", WebCore::functionCallHandlerFromAnyThread);
public:
OutputStream(InspectorHeapProfilerFrontendDispatcher* frontend, unsigned uid)
: m_frontendDispatcher(frontend), m_uid(uid) { }
- void Write(const String& chunk) { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
- void Close() { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
+ void Write(const String& chunk) override { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
+ void Close() override { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
private:
InspectorHeapProfilerFrontendDispatcher* m_frontendDispatcher;
int m_uid;
public:
explicit HeapSnapshotProgress(InspectorHeapProfilerFrontendDispatcher* frontend)
: m_frontendDispatcher(frontend) { }
- void Start(int totalWork)
+ void Start(int totalWork) override
{
m_totalWork = totalWork;
}
- void Worked(int workDone)
+ void Worked(int workDone) override
{
if (m_frontendDispatcher)
m_frontendDispatcher->reportHeapSnapshotProgress(workDone, m_totalWork);
}
- void Done() { }
+ void Done() override { }
bool isCanceled() { return false; }
private:
InspectorHeapProfilerFrontendDispatcher* m_frontendDispatcher;
InspectorHeapProfilerAgent(InstrumentingAgents*, PageInjectedScriptManager*);
virtual ~InspectorHeapProfilerAgent();
- virtual void collectGarbage(ErrorString*);
- virtual void clearProfiles(ErrorString*) { resetState(); }
+ virtual void collectGarbage(ErrorString*) override;
+ virtual void clearProfiles(ErrorString*) override { resetState(); }
void resetState();
- virtual void hasHeapProfiler(ErrorString*, bool*);
+ virtual void hasHeapProfiler(ErrorString*, bool*) override;
- virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::HeapProfiler::ProfileHeader>>&);
- virtual void getHeapSnapshot(ErrorString*, int uid);
- virtual void removeProfile(ErrorString*, int uid);
+ virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::HeapProfiler::ProfileHeader>>&) override;
+ virtual void getHeapSnapshot(ErrorString*, int uid) override;
+ virtual void removeProfile(ErrorString*, int uid) override;
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress);
+ virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;
- virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId);
+ virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;
private:
typedef HashMap<unsigned, RefPtr<ScriptHeapSnapshot>> IdToHeapSnapshotMap;
public:
UndoableStateMark() : InspectorHistory::Action("[UndoableState]") { }
- virtual bool perform(ExceptionCode&) { return true; }
+ virtual bool perform(ExceptionCode&) override { return true; }
- virtual bool undo(ExceptionCode&) { return true; }
+ virtual bool undo(ExceptionCode&) override { return true; }
- virtual bool redo(ExceptionCode&) { return true; }
+ virtual bool redo(ExceptionCode&) override { return true; }
- virtual bool isUndoableStateMark() { return true; }
+ virtual bool isUndoableStateMark() override { return true; }
};
}
virtual ~DatabaseLoader() { }
- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
{
#if PLATFORM(MAC)
ASSERT_UNUSED(prpDatabase, prpDatabase);
#endif // PLATFORM(MAC)
}
- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
private:
DatabaseLoader(ScriptExecutionContext* context, PassRefPtr<RequestDatabaseCallback> requestCallback)
: ExecutableWithDatabase(context)
virtual ~DataLoader() { }
- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
{
RefPtr<IDBDatabase> idbDatabase = prpDatabase;
if (!requestCallback()->isActive())
idbRequest->addEventListener(eventNames().successEvent, openCursorCallback, false);
}
- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
DataLoader(ScriptExecutionContext* scriptExecutionContext, PassRefPtr<RequestDataCallback> requestCallback, const InjectedScript& injectedScript, const String& objectStoreName, const String& indexName, PassRefPtr<IDBKeyRange> idbKeyRange, int skipCount, unsigned pageSize)
: ExecutableWithDatabase(scriptExecutionContext)
, m_requestCallback(requestCallback)
{
}
- virtual void execute(PassRefPtr<IDBDatabase> prpDatabase)
+ virtual void execute(PassRefPtr<IDBDatabase> prpDatabase) override
{
RefPtr<IDBDatabase> idbDatabase = prpDatabase;
if (!requestCallback()->isActive())
idbTransaction->addEventListener(eventNames().completeEvent, ClearObjectStoreListener::create(m_requestCallback), false);
}
- virtual RequestCallback* requestCallback() { return m_requestCallback.get(); }
+ virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
private:
const String m_objectStoreName;
RefPtr<ClearObjectStoreCallback> m_requestCallback;
virtual void willDestroyFrontendAndBackend() override;
// Called from the front-end.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void requestDatabaseNames(ErrorString*, const String& securityOrigin, PassRefPtr<RequestDatabaseNamesCallback>);
- virtual void requestDatabase(ErrorString*, const String& securityOrigin, const String& databaseName, PassRefPtr<RequestDatabaseCallback>);
- virtual void requestData(ErrorString*, const String& securityOrigin, const String& databaseName, const String& objectStoreName, const String& indexName, int skipCount, int pageSize, const RefPtr<Inspector::InspectorObject>* keyRange, PassRefPtr<RequestDataCallback>);
- virtual void clearObjectStore(ErrorString*, const String& in_securityOrigin, const String& in_databaseName, const String& in_objectStoreName, PassRefPtr<ClearObjectStoreCallback>);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void requestDatabaseNames(ErrorString*, const String& securityOrigin, PassRefPtr<RequestDatabaseNamesCallback>) override;
+ virtual void requestDatabase(ErrorString*, const String& securityOrigin, const String& databaseName, PassRefPtr<RequestDatabaseCallback>) override;
+ virtual void requestData(ErrorString*, const String& securityOrigin, const String& databaseName, const String& objectStoreName, const String& indexName, int skipCount, int pageSize, const RefPtr<Inspector::InspectorObject>* keyRange, PassRefPtr<RequestDataCallback>) override;
+ virtual void clearObjectStore(ErrorString*, const String& in_securityOrigin, const String& in_databaseName, const String& in_objectStoreName, PassRefPtr<ClearObjectStoreCallback>) override;
private:
Inspector::InjectedScriptManager* m_injectedScriptManager;
virtual void willDestroyFrontendAndBackend() override;
// Methods called from the frontend for simulating input.
- virtual void dispatchKeyEvent(ErrorString*, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const int* macCharCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey);
- virtual void dispatchMouseEvent(ErrorString*, const String& type, int x, int y, const int* modifiers, const double* timestamp, const String* button, const int* clickCount);
+ virtual void dispatchKeyEvent(ErrorString*, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const int* macCharCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey) override;
+ virtual void dispatchMouseEvent(ErrorString*, const String& type, int x, int y, const int* modifiers, const double* timestamp, const String* button, const int* clickCount) override;
private:
Page* m_page;
void pseudoElementDestroyed(PseudoElement*);
// Called from the front-end.
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void layersForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::LayerTree::Layer>>&);
- virtual void reasonsForCompositingLayer(ErrorString*, const String& layerId, RefPtr<Inspector::TypeBuilder::LayerTree::CompositingReasons>&);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void layersForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::LayerTree::Layer>>&) override;
+ virtual void reasonsForCompositingLayer(ErrorString*, const String& layerId, RefPtr<Inspector::TypeBuilder::LayerTree::CompositingReasons>&) override;
private:
// RenderLayer-related methods.
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void getDOMCounters(ErrorString*, int* documents, int* nodes, int* jsEventListeners);
+ virtual void getDOMCounters(ErrorString*, int* documents, int* nodes, int* jsEventListeners) override;
private:
RefPtr<Inspector::InspectorMemoryBackendDispatcher> m_backendDispatcher;
static Inspector::TypeBuilder::Page::ResourceType::Enum cachedResourceTypeJson(const CachedResource&);
// Page API for InspectorFrontend
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void addScriptToEvaluateOnLoad(ErrorString*, const String& source, String* result);
- virtual void removeScriptToEvaluateOnLoad(ErrorString*, const String& identifier);
- virtual void reload(ErrorString*, const bool* optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad);
- virtual void navigate(ErrorString*, const String& url);
- virtual void getCookies(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::Cookie>>& cookies);
- virtual void deleteCookie(ErrorString*, const String& cookieName, const String& url);
- virtual void getResourceTree(ErrorString*, RefPtr<Inspector::TypeBuilder::Page::FrameResourceTree>&);
- virtual void getResourceContent(ErrorString*, const String& frameId, const String& url, String* content, bool* base64Encoded);
- virtual void searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
- virtual void searchInResources(ErrorString*, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::SearchResult>>&);
- virtual void setDocumentContent(ErrorString*, const String& frameId, const String& html);
- virtual void setShowPaintRects(ErrorString*, bool show);
- virtual void canShowDebugBorders(ErrorString*, bool*);
- virtual void setShowDebugBorders(ErrorString*, bool show);
- virtual void canShowFPSCounter(ErrorString*, bool*);
- virtual void setShowFPSCounter(ErrorString*, bool show);
- virtual void canContinuouslyPaint(ErrorString*, bool*);
- virtual void setContinuousPaintingEnabled(ErrorString*, bool enabled);
- virtual void getScriptExecutionStatus(ErrorString*, Inspector::InspectorPageBackendDispatcherHandler::Result::Enum*);
- virtual void setScriptExecutionDisabled(ErrorString*, bool);
- virtual void setTouchEmulationEnabled(ErrorString*, bool);
- virtual void setEmulatedMedia(ErrorString*, const String&);
- virtual void getCompositingBordersVisible(ErrorString*, bool* out_param);
- virtual void setCompositingBordersVisible(ErrorString*, bool);
- virtual void snapshotNode(ErrorString*, int nodeId, String* outDataURL);
- virtual void snapshotRect(ErrorString*, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL);
- virtual void handleJavaScriptDialog(ErrorString*, bool accept, const String* promptText);
- virtual void archive(ErrorString*, String* data);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void addScriptToEvaluateOnLoad(ErrorString*, const String& source, String* result) override;
+ virtual void removeScriptToEvaluateOnLoad(ErrorString*, const String& identifier) override;
+ virtual void reload(ErrorString*, const bool* optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad) override;
+ virtual void navigate(ErrorString*, const String& url) override;
+ virtual void getCookies(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::Cookie>>& cookies) override;
+ virtual void deleteCookie(ErrorString*, const String& cookieName, const String& url) override;
+ virtual void getResourceTree(ErrorString*, RefPtr<Inspector::TypeBuilder::Page::FrameResourceTree>&) override;
+ virtual void getResourceContent(ErrorString*, const String& frameId, const String& url, String* content, bool* base64Encoded) override;
+ virtual void searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&) override;
+ virtual void searchInResources(ErrorString*, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::SearchResult>>&) override;
+ virtual void setDocumentContent(ErrorString*, const String& frameId, const String& html) override;
+ virtual void setShowPaintRects(ErrorString*, bool show) override;
+ virtual void canShowDebugBorders(ErrorString*, bool*) override;
+ virtual void setShowDebugBorders(ErrorString*, bool show) override;
+ virtual void canShowFPSCounter(ErrorString*, bool*) override;
+ virtual void setShowFPSCounter(ErrorString*, bool show) override;
+ virtual void canContinuouslyPaint(ErrorString*, bool*) override;
+ virtual void setContinuousPaintingEnabled(ErrorString*, bool enabled) override;
+ virtual void getScriptExecutionStatus(ErrorString*, Inspector::InspectorPageBackendDispatcherHandler::Result::Enum*) override;
+ virtual void setScriptExecutionDisabled(ErrorString*, bool) override;
+ virtual void setTouchEmulationEnabled(ErrorString*, bool) override;
+ virtual void setEmulatedMedia(ErrorString*, const String&) override;
+ virtual void getCompositingBordersVisible(ErrorString*, bool* out_param) override;
+ virtual void setCompositingBordersVisible(ErrorString*, bool) override;
+ virtual void snapshotNode(ErrorString*, int nodeId, String* outDataURL) override;
+ virtual void snapshotRect(ErrorString*, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL) override;
+ virtual void handleJavaScriptDialog(ErrorString*, bool accept, const String* promptText) override;
+ virtual void archive(ErrorString*, String* data) override;
// InspectorInstrumentation API
void didClearWindowObjectInWorld(Frame*, DOMWrapperWorld&);
virtual ~PageProfilerAgent() { }
private:
- virtual void recompileScript()
+ virtual void recompileScript() override
{
PageScriptDebugServer::shared().recompileAllJSFunctionsSoon();
}
- virtual void startProfiling(const String& title)
+ virtual void startProfiling(const String& title) override
{
ScriptProfiler::startForPage(m_inspectedPage, title);
}
- virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title)
+ virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title) override
{
return ScriptProfiler::stopForPage(m_inspectedPage, title);
}
virtual ~WorkerProfilerAgent() { }
private:
- virtual void recompileScript() { }
+ virtual void recompileScript() override { }
- virtual void startProfiling(const String& title)
+ virtual void startProfiling(const String& title) override
{
ScriptProfiler::startForWorkerGlobalScope(m_workerGlobalScope, title);
}
- virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title)
+ virtual PassRefPtr<ScriptProfile> stopProfiling(const String& title) override
{
return ScriptProfiler::stopForWorkerGlobalScope(m_workerGlobalScope, title);
}
public:
OutputStream(InspectorProfilerFrontendDispatcher* frontend, unsigned uid)
: m_frontendDispatcher(frontend), m_uid(uid) { }
- void Write(const String& chunk) { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
- void Close() { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
+ void Write(const String& chunk) override { m_frontendDispatcher->addHeapSnapshotChunk(m_uid, chunk); }
+ void Close() override { m_frontendDispatcher->finishHeapSnapshot(m_uid); }
private:
InspectorProfilerFrontendDispatcher* m_frontendDispatcher;
int m_uid;
public:
explicit HeapSnapshotProgress(InspectorProfilerFrontendDispatcher* frontend)
: m_frontendDispatcher(frontend) { }
- void Start(int totalWork)
+ void Start(int totalWork) override
{
m_totalWork = totalWork;
}
- void Worked(int workDone)
+ void Worked(int workDone) override
{
if (m_frontendDispatcher)
m_frontendDispatcher->reportHeapSnapshotProgress(workDone, m_totalWork);
}
- void Done() { }
+ void Done() override { }
bool isCanceled() { return false; }
private:
InspectorProfilerFrontendDispatcher* m_frontendDispatcher;
void addProfile(PassRefPtr<ScriptProfile> prpProfile, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
void addStartProfilingMessageToConsole(const String& title, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
- virtual void collectGarbage(ErrorString*);
- virtual void clearProfiles(ErrorString*) { resetState(); }
+ virtual void collectGarbage(ErrorString*) override;
+ virtual void clearProfiles(ErrorString*) override { resetState(); }
void resetState();
virtual void recompileScript() = 0;
- virtual void isSampling(ErrorString*, bool*);
- virtual void hasHeapProfiler(ErrorString*, bool*);
+ virtual void isSampling(ErrorString*, bool*) override;
+ virtual void hasHeapProfiler(ErrorString*, bool*) override;
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void start(ErrorString* = 0);
- virtual void stop(ErrorString* = 0);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void start(ErrorString* = 0) override;
+ virtual void stop(ErrorString* = 0) override;
void disable();
void enable(bool skipRecompile);
bool enabled() const { return m_enabled; }
String getCurrentUserInitiatedProfileName(bool incrementProfileNumber = false);
- virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Profiler::ProfileHeader>>&);
- virtual void getCPUProfile(ErrorString*, int uid, RefPtr<Inspector::TypeBuilder::Profiler::CPUProfile>&);
- virtual void getHeapSnapshot(ErrorString*, int uid);
- virtual void removeProfile(ErrorString*, const String& type, int uid);
+ virtual void getProfileHeaders(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Profiler::ProfileHeader>>&) override;
+ virtual void getCPUProfile(ErrorString*, int uid, RefPtr<Inspector::TypeBuilder::Profiler::CPUProfile>&) override;
+ virtual void getHeapSnapshot(ErrorString*, int uid) override;
+ virtual void removeProfile(ErrorString*, const String& type, int uid) override;
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress);
+ virtual void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;
void toggleRecordButton(bool isProfiling);
- virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
- virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId);
+ virtual void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;
protected:
InspectorProfilerAgent(InstrumentingAgents*, InspectorConsoleAgent*, PageInjectedScriptManager*);
void setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize);
// Called from frontend
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void setExtraHTTPHeaders(ErrorString*, const RefPtr<Inspector::InspectorObject>&);
- virtual void getResponseBody(ErrorString*, const String& requestId, String* content, bool* base64Encoded);
-
- virtual void replayXHR(ErrorString*, const String& requestId);
-
- virtual void canClearBrowserCache(ErrorString*, bool*);
- virtual void clearBrowserCache(ErrorString*);
- virtual void canClearBrowserCookies(ErrorString*, bool*);
- virtual void clearBrowserCookies(ErrorString*);
- virtual void setCacheDisabled(ErrorString*, bool cacheDisabled);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void setExtraHTTPHeaders(ErrorString*, const RefPtr<Inspector::InspectorObject>&) override;
+ virtual void getResponseBody(ErrorString*, const String& requestId, String* content, bool* base64Encoded) override;
+
+ virtual void replayXHR(ErrorString*, const String& requestId) override;
+
+ virtual void canClearBrowserCache(ErrorString*, bool*) override;
+ virtual void clearBrowserCache(ErrorString*) override;
+ virtual void canClearBrowserCookies(ErrorString*, bool*) override;
+ virtual void clearBrowserCookies(ErrorString*) override;
+ virtual void setCacheDisabled(ErrorString*, bool cacheDisabled) override;
private:
void enable();
virtual ~InspectorRuntimeAgent();
// Part of the protocol.
- virtual void enable(ErrorString*) { m_enabled = true; }
- virtual void disable(ErrorString*) { m_enabled = false; }
- virtual void parse(ErrorString*, const String& expression, Inspector::TypeBuilder::Runtime::SyntaxErrorType::Enum* result, Inspector::TypeBuilder::OptOutput<String>* message, RefPtr<Inspector::TypeBuilder::Runtime::ErrorRange>&);
+ virtual void enable(ErrorString*) override { m_enabled = true; }
+ virtual void disable(ErrorString*) override { m_enabled = false; }
+ virtual void parse(ErrorString*, const String& expression, Inspector::TypeBuilder::Runtime::SyntaxErrorType::Enum* result, Inspector::TypeBuilder::OptOutput<String>* message, RefPtr<Inspector::TypeBuilder::Runtime::ErrorRange>&) override;
virtual void evaluate(ErrorString*,
const String& expression,
const String* objectGroup,
const bool* returnByValue,
const bool* generatePreview,
RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
virtual void callFunctionOn(ErrorString*,
const String& objectId,
const String& expression,
const bool* returnByValue,
const bool* generatePreview,
RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result,
- Inspector::TypeBuilder::OptOutput<bool>* wasThrown);
- virtual void releaseObject(ErrorString*, const String& objectId);
- virtual void getProperties(ErrorString*, const String& objectId, const bool* ownProperties, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalProperties);
- virtual void releaseObjectGroup(ErrorString*, const String& objectGroup);
- virtual void run(ErrorString*);
+ Inspector::TypeBuilder::OptOutput<bool>* wasThrown) override;
+ virtual void releaseObject(ErrorString*, const String& objectId) override;
+ virtual void getProperties(ErrorString*, const String& objectId, const bool* ownProperties, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalProperties) override;
+ virtual void releaseObjectGroup(ErrorString*, const String& objectGroup) override;
+ virtual void run(ErrorString*) override;
#if ENABLE(JAVASCRIPT_DEBUGGER)
void setScriptDebugServer(ScriptDebugServer*);
static PassRefPtr<InspectorStyleSheetForInlineStyle> create(InspectorPageAgent*, const String& id, PassRefPtr<Element>, Inspector::TypeBuilder::CSS::StyleSheetOrigin::Enum, Listener*);
void didModifyElementAttribute();
- virtual bool getText(String* result) const;
- virtual CSSStyleDeclaration* styleForId(const InspectorCSSId& id) const { ASSERT_UNUSED(id, !id.ordinal()); return inlineStyle(); }
+ virtual bool getText(String* result) const override;
+ virtual CSSStyleDeclaration* styleForId(const InspectorCSSId& id) const override { ASSERT_UNUSED(id, !id.ordinal()); return inlineStyle(); }
protected:
InspectorStyleSheetForInlineStyle(InspectorPageAgent*, const String& id, PassRefPtr<Element>, Inspector::TypeBuilder::CSS::StyleSheetOrigin::Enum, Listener*);
- virtual Document* ownerDocument() const;
- virtual RefPtr<CSSRuleSourceData> ruleSourceDataFor(CSSStyleDeclaration* style) const { ASSERT_UNUSED(style, style == inlineStyle()); return m_ruleSourceData; }
- virtual unsigned ruleIndexByStyle(CSSStyleDeclaration*) const { return 0; }
- virtual bool ensureParsedDataReady();
- virtual PassRefPtr<InspectorStyle> inspectorStyleForId(const InspectorCSSId&);
- virtual void rememberInspectorStyle(RefPtr<InspectorStyle>) { }
- virtual void forgetInspectorStyle(CSSStyleDeclaration*) { }
+ virtual Document* ownerDocument() const override;
+ virtual RefPtr<CSSRuleSourceData> ruleSourceDataFor(CSSStyleDeclaration* style) const override { ASSERT_UNUSED(style, style == inlineStyle()); return m_ruleSourceData; }
+ virtual unsigned ruleIndexByStyle(CSSStyleDeclaration*) const override { return 0; }
+ virtual bool ensureParsedDataReady() override;
+ virtual PassRefPtr<InspectorStyle> inspectorStyleForId(const InspectorCSSId&) override;
+ virtual void rememberInspectorStyle(RefPtr<InspectorStyle>) override { }
+ virtual void forgetInspectorStyle(CSSStyleDeclaration*) override { }
// Also accessed by friend class InspectorStyle.
- virtual bool setStyleText(CSSStyleDeclaration*, const String&, ExceptionCode&);
- virtual PassOwnPtr<Vector<size_t>> lineEndings() const;
+ virtual bool setStyleText(CSSStyleDeclaration*, const String&, ExceptionCode&) override;
+ virtual PassOwnPtr<Vector<size_t>> lineEndings() const override;
private:
CSSStyleDeclaration* inlineStyle() const;
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void start(ErrorString*, const int* maxCallStackDepth, const bool* includeDomCounters);
- virtual void stop(ErrorString*);
- virtual void canMonitorMainThread(ErrorString*, bool*);
- virtual void supportsFrameInstrumentation(ErrorString*, bool*);
+ virtual void start(ErrorString*, const int* maxCallStackDepth, const bool* includeDomCounters) override;
+ virtual void stop(ErrorString*) override;
+ virtual void canMonitorMainThread(ErrorString*, bool*) override;
+ virtual void supportsFrameInstrumentation(ErrorString*, bool*) override;
int id() const { return m_id; }
private:
// WorkerGlobalScopeProxy::PageInspector implementation
- virtual void dispatchMessageFromWorker(const String& message)
+ virtual void dispatchMessageFromWorker(const String& message) override
{
RefPtr<InspectorValue> value = InspectorValue::parseJSON(message);
if (!value)
void workerGlobalScopeTerminated(WorkerGlobalScopeProxy*);
// Called from InspectorBackendDispatcher
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
- virtual void canInspectWorkers(ErrorString*, bool*);
- virtual void connectToWorker(ErrorString*, int workerId);
- virtual void disconnectFromWorker(ErrorString*, int workerId);
- virtual void sendMessageToWorker(ErrorString*, int workerId, const RefPtr<Inspector::InspectorObject>& message);
- virtual void setAutoconnectToWorkers(ErrorString*, bool value);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void canInspectWorkers(ErrorString*, bool*) override;
+ virtual void connectToWorker(ErrorString*, int workerId) override;
+ virtual void disconnectFromWorker(ErrorString*, int workerId) override;
+ virtual void sendMessageToWorker(ErrorString*, int workerId, const RefPtr<Inspector::InspectorObject>& message) override;
+ virtual void setAutoconnectToWorkers(ErrorString*, bool value) override;
private:
void createWorkerFrontendChannelsForExistingWorkers();
virtual bool isWorkerAgent() override { return false; }
private:
- virtual void clearMessages(ErrorString*);
- virtual void addInspectedNode(ErrorString*, int nodeId);
+ virtual void clearMessages(ErrorString*) override;
+ virtual void addInspectedNode(ErrorString*, int nodeId) override;
InspectorDOMAgent* m_inspectorDOMAgent;
};
void didClearMainFrameWindowObject();
protected:
- virtual void enable();
- virtual void disable();
+ virtual void enable() override;
+ virtual void disable() override;
private:
- virtual void startListeningScriptDebugServer();
- virtual void stopListeningScriptDebugServer();
- virtual PageScriptDebugServer& scriptDebugServer();
- virtual void muteConsole();
- virtual void unmuteConsole();
+ virtual void startListeningScriptDebugServer() override;
+ virtual void stopListeningScriptDebugServer() override;
+ virtual PageScriptDebugServer& scriptDebugServer() override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void setOverlayMessage(ErrorString*, const String*);
+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void setOverlayMessage(ErrorString*, const String*) override;
InspectorPageAgent* m_pageAgent;
InspectorOverlay* m_overlay;
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
- virtual void enable(ErrorString*);
- virtual void disable(ErrorString*);
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
void didCreateMainWorldContext(Frame*);
void didCreateIsolatedContext(Frame*, JSC::ExecState*, SecurityOrigin*);
private:
- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void muteConsole();
- virtual void unmuteConsole();
+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
void reportExecutionContextCreation();
void notifyContextCreated(const String& frameId, JSC::ExecState*, SecurityOrigin*, bool isPageContext);
virtual bool isWorkerAgent() override { return true; }
private:
- virtual void addInspectedNode(ErrorString*, int nodeId);
+ virtual void addInspectedNode(ErrorString*, int nodeId) override;
};
} // namespace WebCore
: m_thread(thread)
, m_workerGlobalScope(workerGlobalScope) { }
virtual ~RunInspectorCommandsTask() { }
- virtual void run()
+ virtual void run() override
{
// Process all queued debugger commands. It is safe to use m_workerGlobalScope here
// because it is alive if RunWorkerLoop is not terminated, otherwise it will
: m_workerGlobalScope(workerGlobalScope) { }
virtual ~PageInspectorProxy() { }
private:
- virtual bool sendMessageToFrontend(const String& message)
+ virtual bool sendMessageToFrontend(const String& message) override
{
m_workerGlobalScope.thread()->workerReportingProxy().postMessageToPageInspector(message);
return true;
virtual void willDestroyFrontendAndBackend() override;
// Protocol commands.
- virtual void run(ErrorString*);
+ virtual void run(ErrorString*) override;
#if ENABLE(JAVASCRIPT_DEBUGGER)
void pauseWorkerGlobalScope(WorkerGlobalScope*);
#endif // ENABLE(JAVASCRIPT_DEBUGGER)
private:
- virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId);
- virtual void muteConsole();
- virtual void unmuteConsole();
+ virtual Inspector::InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
WorkerGlobalScope* m_workerGlobalScope;
RefPtr<Inspector::InspectorRuntimeBackendDispatcher> m_backendDispatcher;
bool m_paused;
git://git.webkit.org / WebKit-https.git / commitdiff