LeaksViewer fails to present recent results list if current build is still updating svn
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Oct 2013 18:56:15 +0000 (18:56 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Oct 2013 18:56:15 +0000 (18:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122670

Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@157311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js
Tools/ChangeLog

index 33fd00c..691b033 100644 (file)
@@ -37,9 +37,12 @@ RecentBuildsLoader.prototype = {
             var builds = [];
             Object.keys(data).forEach(function(buildNumber) {
                 var build = data[buildNumber];
+                var svnRevisionProperty = build.properties.first(function(property) { return property[0] === "got_revision"; });
+                if (!svnRevisionProperty)
+                    continue;
 
                 var buildInfo = {
-                    revision: parseInt(build.properties.first(function(property) { return property[0] === "got_revision"; })[1], 10),
+                    revision: parseInt(svnRevisionProperty[1], 10),
                     leakCount: 0,
                     url: null,
                 };
index dc4cd78..c3c7f5f 100644 (file)
@@ -1,3 +1,13 @@
+2013-10-11  Alexey Proskuryakov  <ap@apple.com>
+
+        LeaksViewer fails to present recent results list if current build is still updating svn
+        https://bugs.webkit.org/show_bug.cgi?id=122670
+
+        Reviewed by Adam Roben.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
+        (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
+
 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
 
         Unreviewed build fix for --64-bit target.