Rebaseline media/modern-media-controls/mute-button
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 11 Jun 2017 21:43:54 +0000 (21:43 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 11 Jun 2017 21:43:54 +0000 (21:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=173205

Reviewed by Jon Lee.

We now use SVG assets, so let the test reflect that.

* media/modern-media-controls/mute-button/mute-button-expected.txt:
* media/modern-media-controls/mute-button/mute-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@218072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt
LayoutTests/media/modern-media-controls/mute-button/mute-button.html
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations

index 187a55b..c800579 100644 (file)
@@ -1,5 +1,19 @@
 2017-06-11  Antoine Quint  <graouts@apple.com>
 
+        Rebaseline media/modern-media-controls/mute-button
+        https://bugs.webkit.org/show_bug.cgi?id=173205
+
+        Reviewed by Jon Lee.
+
+        We now use SVG assets, so let the test reflect that.
+
+        * media/modern-media-controls/mute-button/mute-button-expected.txt:
+        * media/modern-media-controls/mute-button/mute-button.html:
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2017-06-11  Antoine Quint  <graouts@apple.com>
+
         Remove media/modern-media-controls/macos-media-controls
         https://bugs.webkit.org/show_bug.cgi?id=173204
 
index f1cdc17..878f2b5 100644 (file)
@@ -4,14 +4,13 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
 PASS muteButton.element.localName is "button"
-PASS muteButton.element.classList.contains("icon") is true
 PASS muteButton.element.classList.contains("mute") is true
 PASS muteButton.iconName is Icons.Volume
 PASS muteButton.muted is false
 PASS mutedButton.muted is true
 PASS mutedButton.iconName is Icons.VolumeMuted
-PASS muteButton.element.style.webkitMaskImage.includes("macOS/volume@") became true
-PASS mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@") became true
+PASS muteButton.image.element.style.webkitMaskImage.includes("macOS/VolumeHi.svg") became true
+PASS mutedButton.image.element.style.webkitMaskImage.includes("macOS/Mute.svg") became true
 PASS successfullyParsed is true
 
 TEST COMPLETE
index b0d045d..b075a3f 100644 (file)
@@ -11,7 +11,6 @@ description("Testing the <code>MuteButton</code> class.");
 const muteButton = new MuteButton({ layoutTraits: LayoutTraits.macOS });
 
 shouldBeEqualToString("muteButton.element.localName", "button");
-shouldBeTrue('muteButton.element.classList.contains("icon")');
 shouldBeTrue('muteButton.element.classList.contains("mute")');
 shouldBe("muteButton.iconName", "Icons.Volume");
 shouldBeFalse("muteButton.muted");
@@ -21,8 +20,8 @@ mutedButton.muted = true;
 shouldBeTrue("mutedButton.muted");
 shouldBe("mutedButton.iconName", "Icons.VolumeMuted");
 
-shouldBecomeEqual('muteButton.element.style.webkitMaskImage.includes("macOS/volume@")', "true", () => {
-    shouldBecomeEqual('mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@")', "true", finishJSTest);
+shouldBecomeEqual('muteButton.image.element.style.webkitMaskImage.includes("macOS/VolumeHi.svg")', "true", () => {
+    shouldBecomeEqual('mutedButton.image.element.style.webkitMaskImage.includes("macOS/Mute.svg")', "true", finishJSTest);
 });
 
 </script>
index 55379aa..8f6cd17 100644 (file)
@@ -68,6 +68,7 @@ media/modern-media-controls/icon-service [ Pass ]
 media/modern-media-controls/invalid-placard [ Pass ]
 media/modern-media-controls/layout-item [ Pass ]
 media/modern-media-controls/layout-node [ Pass ]
+media/modern-media-controls/mute-button [ Pass ]
 
 # AirPlay cannot be tested on iOS
 webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
index 176c460..6f2c1e9 100644 (file)
@@ -1563,6 +1563,7 @@ media/modern-media-controls/layout-item [ Pass ]
 media/modern-media-controls/layout-node [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
+media/modern-media-controls/mute-button [ Pass ]
 media/modern-media-controls/volume-up-support [ Pass ]
 
 # These tests are iOS-specific