Web Inspector: nuke background events collection (dead feature)
authorpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Aug 2011 13:41:51 +0000 (13:41 +0000)
committerpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Aug 2011 13:41:51 +0000 (13:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

Source/WebCore:

* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/EventsCollector.cpp: Removed.
* inspector/EventsCollector.h: Removed.
* inspector/Inspector.json:
* inspector/InspectorFrontendProxy.cpp: Removed.
* inspector/InspectorFrontendProxy.h: Removed.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):

LayoutTests:

* http/tests/inspector/network-test.js:
* http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
* http/tests/inspector/network/network-clear-after-disabled.html: Removed.
* http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
* http/tests/inspector/network/network-close-load-open.html: Removed.
* http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
* http/tests/inspector/network/network-open-load-reopen.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22 files changed:
LayoutTests/ChangeLog
LayoutTests/http/tests/inspector/network-test.js
LayoutTests/http/tests/inspector/network/network-clear-after-disabled-expected.txt [deleted file]
LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html [deleted file]
LayoutTests/http/tests/inspector/network/network-close-load-open-expected.txt [deleted file]
LayoutTests/http/tests/inspector/network/network-close-load-open.html [deleted file]
LayoutTests/http/tests/inspector/network/network-open-load-reopen-expected.txt [deleted file]
LayoutTests/http/tests/inspector/network/network-open-load-reopen.html [deleted file]
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/WebCore.gypi
Source/WebCore/WebCore.pro
Source/WebCore/WebCore.vcproj/WebCore.vcproj
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/inspector/EventsCollector.cpp [deleted file]
Source/WebCore/inspector/EventsCollector.h [deleted file]
Source/WebCore/inspector/Inspector.json
Source/WebCore/inspector/InspectorFrontendProxy.cpp [deleted file]
Source/WebCore/inspector/InspectorFrontendProxy.h [deleted file]
Source/WebCore/inspector/InspectorResourceAgent.cpp
Source/WebCore/inspector/InspectorResourceAgent.h
Source/WebCore/inspector/front-end/NetworkPanel.js

index 9d84d5f..87b5331 100644 (file)
@@ -1,3 +1,18 @@
+2011-08-16  Pavel Feldman  <pfeldman@google.com>
+
+        Web Inspector: nuke background events collection (dead feature)
+        https://bugs.webkit.org/show_bug.cgi?id=66296
+
+        Reviewed by Yury Semikhatsky.
+
+        * http/tests/inspector/network-test.js:
+        * http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
+        * http/tests/inspector/network/network-clear-after-disabled.html: Removed.
+        * http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
+        * http/tests/inspector/network/network-close-load-open.html: Removed.
+        * http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
+        * http/tests/inspector/network/network-open-load-reopen.html: Removed.
+
 2011-08-16  Steve Block  <steveblock@google.com>
 
         Set failing expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg
index 1f402d3..1413084 100644 (file)
@@ -1,19 +1,5 @@
 var initialize_NetworkTest = function() {
 
-InspectorTest.enableBackgroundEventCollection = function()
-{
-    if (!WebInspector.panels.network._networkLogView._backgroundCollectionEnabled)
-        WebInspector.panels.network._networkLogView._toggleBackgroundEventsCollection();
-    else
-        throw "BackgroundEventCollection already enabled.";
-}
-
-InspectorTest.disableBackgroundEventCollection = function ()
-{
-    if (WebInspector.panels.network._networkLogView._backgroundCollectionEnabled)
-        WebInspector.panels.network._networkLogView._toggleBackgroundEventsCollection();
-}
-
 InspectorTest.dumpNetworkResources = function()
 {
     var resources = WebInspector.panels.network.resources.slice();
diff --git a/LayoutTests/http/tests/inspector/network/network-clear-after-disabled-expected.txt b/LayoutTests/http/tests/inspector/network/network-clear-after-disabled-expected.txt
deleted file mode 100644 (file)
index 8294332..0000000
+++ /dev/null
@@ -1,6 +0,0 @@
-Test that reopening clears network panel in background events collection disabled mode. Bug 58064 Bug 58652
-
-
-Reopened frontend 2 times
-resources count = 0
-
diff --git a/LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html b/LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html
deleted file mode 100644 (file)
index 11ecc8f..0000000
+++ /dev/null
@@ -1,63 +0,0 @@
-<html>
-<head>
-<script src="../inspector-test.js"></script>
-<script src="../network-test.js"></script>
-<script>
-
-function loadImagesAndReopenFrontend(size)
-{
-    var image = document.createElement("img");
-    image.setAttribute("src", "resources/resource.php?type=image&size=" + size);
-    image.onload = resourceLoaded;
-    document.body.appendChild(image);
-
-    var image2 = document.createElement("img");
-    image2.onload = resourceLoaded;
-    image2.setAttribute("src", "resources/resource.php?type=image&size=" + size + "&gzip=true");
-    document.body.appendChild(image2);
-}
-
-var loadedResourceCount = 0;
-function resourceLoaded()
-{
-    loadedResourceCount++;
-    if (loadedResourceCount % 2 === 0)
-        reopenFrontend();
-}
-
-function test()
-{
-    try {
-        InspectorTest.evaluateInPage("frontendReopeningCount", frontendReopeningCountReceiver);
-    } catch (e) {
-        InspectorTest.disableBackgroundEventCollection();
-        throw e;
-    }
-
-    function frontendReopeningCountReceiver(stepNumber) {
-        if (stepNumber.description === "0") {
-            InspectorTest.enableBackgroundEventCollection();
-            InspectorTest.evaluateInPage("loadImagesAndReopenFrontend(400)");
-        } else if (stepNumber._description === "1") {
-            InspectorTest.disableBackgroundEventCollection();
-            InspectorTest.evaluateInPage("loadImagesAndReopenFrontend(600)");
-        } else {
-            InspectorTest.addResult("Reopened frontend " + stepNumber._description + " times");
-            InspectorTest.dumpNetworkResources();
-            InspectorTest.completeTest();
-        }
-    }
-}
-
-</script>
-
-</head>
-
-<body onload="runTest()">
-<p>
-Test that reopening clears network panel in background events collection disabled mode.
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58064">Bug 58064</a>
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58652">Bug 58652</a>
-</p>
-</body>
-</html>
diff --git a/LayoutTests/http/tests/inspector/network/network-close-load-open-expected.txt b/LayoutTests/http/tests/inspector/network/network-close-load-open-expected.txt
deleted file mode 100644 (file)
index afdc64f..0000000
+++ /dev/null
@@ -1,7 +0,0 @@
-Test that when background event collection is enabled network panel correctly collects events with closed frontend. Bug 58064 Bug 58652
-
-
-resources count = 2
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&size=400
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&size=400&gzip=true
-
diff --git a/LayoutTests/http/tests/inspector/network/network-close-load-open.html b/LayoutTests/http/tests/inspector/network/network-close-load-open.html
deleted file mode 100644 (file)
index 0437d79..0000000
+++ /dev/null
@@ -1,61 +0,0 @@
-<html>
-<head>
-<script src="../inspector-test.js"></script>
-<script src="../network-test.js"></script>
-<script>
-
-function loadImagesAndOpenFrontend()
-{
-    var image = document.createElement("img");
-    image.setAttribute("src", "resources/resource.php?type=image&size=400");
-    image.onload = resourceLoaded;
-    document.body.appendChild(image);
-
-    var image2 = document.createElement("img");
-    image2.onload = resourceLoaded;
-    image2.setAttribute("src", "resources/resource.php?type=image&size=400&gzip=true");
-    document.body.appendChild(image2);
-}
-
-var loadedResourceCount = 0;
-function resourceLoaded()
-{
-    loadedResourceCount++;
-    if (loadedResourceCount === 2)
-        openFrontendAndIncrement();
-}
-
-function test()
-{
-    try {
-        InspectorTest.evaluateInPage("frontendReopeningCount", frontendReopeningCountReceiver);
-    } catch (e) {
-        InspectorTest.disableBackgroundEventCollection();
-        throw e;
-    }
-
-    function frontendReopeningCountReceiver(stepNumber) {
-        if (stepNumber._description === "0") {
-            InspectorTest.enableBackgroundEventCollection();
-            InspectorTest.evaluateInPage("closeFrontend(loadImagesAndOpenFrontend)");
-        } else {
-            InspectorTest.dumpNetworkResources();
-            // Switch off before completeTest.
-            InspectorTest.disableBackgroundEventCollection();
-            InspectorTest.completeTest();
-        }
-    }
-}
-
-</script>
-
-</head>
-
-<body onload="runTest()">
-<p>
-Test that when background event collection is enabled network panel correctly collects events with closed frontend.
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58064">Bug 58064</a>
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58652">Bug 58652</a>
-</p>
-</body>
-</html>
diff --git a/LayoutTests/http/tests/inspector/network/network-open-load-reopen-expected.txt b/LayoutTests/http/tests/inspector/network/network-open-load-reopen-expected.txt
deleted file mode 100644 (file)
index 08107ea..0000000
+++ /dev/null
@@ -1,8 +0,0 @@
-Test that when background event collection is enabled network panel correctly restores network log after the frontend reopening. Bug 58064 Bug 58652
-
-
-Reopened frontend 1 times
-resources count = 2
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&size=500
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&size=500&gzip=true
-
diff --git a/LayoutTests/http/tests/inspector/network/network-open-load-reopen.html b/LayoutTests/http/tests/inspector/network/network-open-load-reopen.html
deleted file mode 100644 (file)
index 28eae1c..0000000
+++ /dev/null
@@ -1,61 +0,0 @@
-<html>
-<head>
-<script src="../inspector-test.js"></script>
-<script src="../network-test.js"></script>
-<script>
-
-function loadImagesAndReopenFrontend()
-{
-    var image = document.createElement("img");
-    image.setAttribute("src", "resources/resource.php?type=image&size=500");
-    image.onload = resourceLoaded;
-    document.body.appendChild(image);
-
-    var image2 = document.createElement("img");
-    image2.onload = resourceLoaded;
-    image2.setAttribute("src", "resources/resource.php?type=image&size=500&gzip=true");
-    document.body.appendChild(image2);
-}
-
-var loadedResourceCount = 0;
-function resourceLoaded()
-{
-    if (++loadedResourceCount === 2)
-        reopenFrontend();
-}
-
-function test()
-{
-    try {
-        InspectorTest.evaluateInPage("frontendReopeningCount", frontendReopeningCountReceiver);
-    } catch (e) {
-        InspectorTest.disableBackgroundEventCollection();
-        throw e;
-    }
-
-    function frontendReopeningCountReceiver(stepNumber) {
-        if (stepNumber._description === "0") {
-            InspectorTest.enableBackgroundEventCollection();
-            InspectorTest.evaluateInPage("loadImagesAndReopenFrontend()");
-        } else {
-            InspectorTest.addResult("Reopened frontend " + stepNumber._description + " times");
-            InspectorTest.dumpNetworkResources();
-            // Switch off before completeTest.
-            InspectorTest.disableBackgroundEventCollection();
-            InspectorTest.completeTest();
-        }
-    }
-}
-
-</script>
-
-</head>
-
-<body onload="runTest()">
-<p>
-Test that when background event collection is enabled network panel correctly restores network log after the frontend reopening.
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58064">Bug 58064</a>
-<a href="https://bugs.webkit.org/show_bug.cgi?id=58652">Bug 58652</a>
-</p>
-</body>
-</html>
index 03546f7..0efa502 100644 (file)
@@ -845,7 +845,6 @@ SET(WebCore_SOURCES
 
     inspector/ConsoleMessage.cpp
     inspector/DOMNodeHighlighter.cpp
-    inspector/EventsCollector.cpp
     inspector/IdentifiersFactory.cpp
     inspector/InjectedScript.cpp
     inspector/InjectedScriptHost.cpp
@@ -866,7 +865,6 @@ SET(WebCore_SOURCES
     inspector/InspectorDebuggerAgent.cpp
     inspector/InspectorFrontendClientLocal.cpp
     inspector/InspectorFrontendHost.cpp
-    inspector/InspectorFrontendProxy.cpp
     inspector/InspectorInstrumentation.cpp
     inspector/InspectorProfilerAgent.cpp
     inspector/InspectorResourceAgent.cpp
index 40eaf95..a95e5b0 100644 (file)
@@ -1,3 +1,28 @@
+2011-08-16  Pavel Feldman  <pfeldman@google.com>
+
+        Web Inspector: nuke background events collection (dead feature)
+        https://bugs.webkit.org/show_bug.cgi?id=66296
+
+        Reviewed by Yury Semikhatsky.
+
+        * CMakeLists.txt:
+        * WebCore.gypi:
+        * WebCore.pro:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * inspector/EventsCollector.cpp: Removed.
+        * inspector/EventsCollector.h: Removed.
+        * inspector/Inspector.json:
+        * inspector/InspectorFrontendProxy.cpp: Removed.
+        * inspector/InspectorFrontendProxy.h: Removed.
+        * inspector/InspectorResourceAgent.cpp:
+        (WebCore::InspectorResourceAgent::setFrontend):
+        (WebCore::InspectorResourceAgent::clearFrontend):
+        (WebCore::InspectorResourceAgent::InspectorResourceAgent):
+        * inspector/InspectorResourceAgent.h:
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkLogView):
+
 2011-08-16  Lindsay Mathieson   <lindsay.mathieson@gmail.com>
 
         [Qt] Missing spell check support
index de40592..8cd9fa0 100644 (file)
             'inspector/ConsoleMessage.h',
             'inspector/DOMNodeHighlighter.cpp',
             'inspector/DOMNodeHighlighter.h',
-            'inspector/EventsCollector.cpp',
-            'inspector/EventsCollector.h',
             'inspector/IdentifiersFactory.cpp',
             'inspector/IdentifiersFactory.h',
             'inspector/InjectedScript.cpp',
             'inspector/InspectorFrontendClientLocal.cpp',
             'inspector/InspectorFrontendHost.cpp',
             'inspector/InspectorFrontendHost.h',
-            'inspector/InspectorFrontendProxy.cpp',
-            'inspector/InspectorFrontendProxy.h',
             'inspector/InspectorInstrumentation.cpp',
             'inspector/InspectorInstrumentation.h',
             'inspector/InspectorPageAgent.cpp',
index b763037..177fb35 100644 (file)
@@ -812,7 +812,6 @@ SOURCES += \
     html/shadow/TextControlInnerElements.cpp \
     inspector/ConsoleMessage.cpp \
     inspector/DOMNodeHighlighter.cpp \
-    inspector/EventsCollector.cpp \
     inspector/IdentifiersFactory.cpp \
     inspector/InjectedScript.cpp \
     inspector/InjectedScriptHost.cpp \
@@ -832,7 +831,6 @@ SOURCES += \
     inspector/InspectorDOMStorageResource.cpp \
     inspector/InspectorFrontendClientLocal.cpp \
     inspector/InspectorFrontendHost.cpp \
-    inspector/InspectorFrontendProxy.cpp \
     inspector/InspectorInstrumentation.cpp \
     inspector/InspectorPageAgent.cpp \
     inspector/InspectorProfilerAgent.cpp \
@@ -1783,7 +1781,6 @@ HEADERS += \
     html/shadow/DetailsMarkerControl.h \
     inspector/ConsoleMessage.h \
     inspector/DOMNodeHighlighter.h \
-    inspector/EventsCollector.h \
     inspector/IdentifiersFactory.h \
     inspector/InjectedScript.h \
     inspector/InjectedScriptHost.h \
@@ -1805,7 +1802,6 @@ HEADERS += \
     inspector/InspectorFrontendClient.h \
     inspector/InspectorFrontendClientLocal.h \
     inspector/InspectorFrontendHost.h \
-    inspector/InspectorFrontendProxy.h \
     inspector/InspectorInstrumentation.h \
     inspector/InspectorPageAgent.h \
     inspector/InspectorProfilerAgent.h \
index 6e8d58f..cacc4df 100755 (executable)
                                >
                        </File>
                        <File
-                               RelativePath="..\inspector\EventsCollector.cpp"
-                               >
-                       </File>
-                       <File
-                               RelativePath="..\inspector\EventsCollector.h"
-                               >
-                       </File>
-                       <File
                                RelativePath="..\inspector\IdentifiersFactory.cpp"
                                >
                        </File>
                                >
                        </File>
                        <File
-                               RelativePath="..\inspector\InspectorFrontendProxy.cpp"
-                               >
-                       </File>
-                       <File
-                               RelativePath="..\inspector\InspectorFrontendProxy.h"
-                               >
-                       </File>
-                       <File
                                RelativePath="..\inspector\InspectorInstrumentation.cpp"
                                >
                        </File>
index 6c04c4f..3db4e6c 100644 (file)
                20D629261253690B00081543 /* InspectorInstrumentation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 20D629241253690B00081543 /* InspectorInstrumentation.cpp */; };
                20D629271253690B00081543 /* InspectorInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = 20D629251253690B00081543 /* InspectorInstrumentation.h */; };
                227777601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */ = {isa = PBXBuildFile; fileRef = 2277775F1345DEA9008EA455 /* InspectorFrontendChannel.h */; settings = {ATTRIBUTES = (Private, ); }; };
-               22777B4A134A018C008EA455 /* EventsCollector.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 22777B48134A018C008EA455 /* EventsCollector.cpp */; };
-               22777B4B134A018C008EA455 /* EventsCollector.h in Headers */ = {isa = PBXBuildFile; fileRef = 22777B49134A018C008EA455 /* EventsCollector.h */; settings = {ATTRIBUTES = (Private, ); }; };
-               22777B4E134A01A8008EA455 /* InspectorFrontendProxy.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 22777B4C134A01A8008EA455 /* InspectorFrontendProxy.cpp */; };
-               22777B4F134A01A8008EA455 /* InspectorFrontendProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 22777B4D134A01A8008EA455 /* InspectorFrontendProxy.h */; settings = {ATTRIBUTES = (Private, ); }; };
                22885E641301AE4C00526E68 /* JSDOMImplementationCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 22885E631301AE4C00526E68 /* JSDOMImplementationCustom.cpp */; };
                228C284510D82500009D0D0E /* ScriptWrappable.h in Headers */ = {isa = PBXBuildFile; fileRef = 228C284410D82500009D0D0E /* ScriptWrappable.h */; settings = {ATTRIBUTES = (Private, ); }; };
                2292B27C1356669400CF11EF /* ImageBufferDataCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2292B27B1356669400CF11EF /* ImageBufferDataCG.cpp */; };
                20D629241253690B00081543 /* InspectorInstrumentation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorInstrumentation.cpp; sourceTree = "<group>"; };
                20D629251253690B00081543 /* InspectorInstrumentation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorInstrumentation.h; sourceTree = "<group>"; };
                2277775F1345DEA9008EA455 /* InspectorFrontendChannel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorFrontendChannel.h; sourceTree = "<group>"; };
-               22777B48134A018C008EA455 /* EventsCollector.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EventsCollector.cpp; sourceTree = "<group>"; };
-               22777B49134A018C008EA455 /* EventsCollector.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EventsCollector.h; sourceTree = "<group>"; };
-               22777B4C134A01A8008EA455 /* InspectorFrontendProxy.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorFrontendProxy.cpp; sourceTree = "<group>"; };
-               22777B4D134A01A8008EA455 /* InspectorFrontendProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorFrontendProxy.h; sourceTree = "<group>"; };
                22885E631301AE4C00526E68 /* JSDOMImplementationCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMImplementationCustom.cpp; sourceTree = "<group>"; };
                228C284410D82500009D0D0E /* ScriptWrappable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScriptWrappable.h; sourceTree = "<group>"; };
                2292B27B1356669400CF11EF /* ImageBufferDataCG.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ImageBufferDataCG.cpp; sourceTree = "<group>"; };
                                41F0618C0F5F069800A07EAC /* ConsoleMessage.h */,
                                4F1442261339FD6200E0D6F8 /* DOMNodeHighlighter.cpp */,
                                4F1442271339FD6200E0D6F8 /* DOMNodeHighlighter.h */,
-                               22777B48134A018C008EA455 /* EventsCollector.cpp */,
-                               22777B49134A018C008EA455 /* EventsCollector.h */,
                                5913A23F13D49EBA00F5B05C /* IdentifiersFactory.cpp */,
                                5913A24013D49EBA00F5B05C /* IdentifiersFactory.h */,
                                F3644AFD1119805900E0D537 /* InjectedScript.cpp */,
                                7A0E770B10C00A8800A0276E /* InspectorFrontendHost.cpp */,
                                7A0E770C10C00A8800A0276E /* InspectorFrontendHost.h */,
                                7A0E770D10C00A8800A0276E /* InspectorFrontendHost.idl */,
-                               22777B4C134A01A8008EA455 /* InspectorFrontendProxy.cpp */,
-                               22777B4D134A01A8008EA455 /* InspectorFrontendProxy.h */,
                                20D629241253690B00081543 /* InspectorInstrumentation.cpp */,
                                20D629251253690B00081543 /* InspectorInstrumentation.h */,
                                4F6FDD621341DEDD001F8EE3 /* InspectorPageAgent.cpp */,
                                1CA19E160DC255CA0065A994 /* EventLoop.h in Headers */,
                                939885C408B7E3D100E707C4 /* EventNames.h in Headers */,
                                8F67561B1288B17B0047ACA3 /* EventQueue.h in Headers */,
-                               22777B4B134A018C008EA455 /* EventsCollector.h in Headers */,
                                E0FEF372B17C53EAC1C1FBEE /* EventSource.h in Headers */,
                                E12EDB7B0B308A78002704B6 /* EventTarget.h in Headers */,
                                BC60D8F30D2A11E000B9918F /* ExceptionBase.h in Headers */,
                                F344C7141125B82C00F26EEE /* InspectorFrontendClient.h in Headers */,
                                F344C75311294D9D00F26EEE /* InspectorFrontendClientLocal.h in Headers */,
                                7A0E770F10C00A8800A0276E /* InspectorFrontendHost.h in Headers */,
-                               22777B4F134A01A8008EA455 /* InspectorFrontendProxy.h in Headers */,
                                20D629271253690B00081543 /* InspectorInstrumentation.h in Headers */,
                                4F6FDD651341DEDD001F8EE3 /* InspectorPageAgent.h in Headers */,
                                9F0D6B2F121BFEBA006C0288 /* InspectorProfilerAgent.h in Headers */,
                                1CA19E050DC255950065A994 /* EventLoopMac.mm in Sources */,
                                939885C308B7E3D100E707C4 /* EventNames.cpp in Sources */,
                                8F67561C1288B17B0047ACA3 /* EventQueue.cpp in Sources */,
-                               22777B4A134A018C008EA455 /* EventsCollector.cpp in Sources */,
                                E0FEF372B27C53EAC1C1FBEE /* EventSource.cpp in Sources */,
                                E12EDBEA0B308E0B002704B6 /* EventTarget.cpp in Sources */,
                                BC60D8F20D2A11E000B9918F /* ExceptionBase.cpp in Sources */,
                                4F4F5FFB11CBD2E100A186BF /* InspectorFrontend.cpp in Sources */,
                                F344C75811294FF600F26EEE /* InspectorFrontendClientLocal.cpp in Sources */,
                                7A0E770E10C00A8800A0276E /* InspectorFrontendHost.cpp in Sources */,
-                               22777B4E134A01A8008EA455 /* InspectorFrontendProxy.cpp in Sources */,
                                20D629261253690B00081543 /* InspectorInstrumentation.cpp in Sources */,
                                4F6FDD641341DEDD001F8EE3 /* InspectorPageAgent.cpp in Sources */,
                                9F0D6B2E121BFEBA006C0288 /* InspectorProfilerAgent.cpp in Sources */,
diff --git a/Source/WebCore/inspector/EventsCollector.cpp b/Source/WebCore/inspector/EventsCollector.cpp
deleted file mode 100644 (file)
index 7391a26..0000000
+++ /dev/null
@@ -1,64 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- */
-
-#include "config.h"
-#include "EventsCollector.h"
-
-#if ENABLE(INSPECTOR)
-
-#include "InspectorFrontendChannel.h"
-#include "PlatformString.h"
-
-namespace WebCore {
-
-EventsCollector::EventsCollector()
-    : m_totalLength(0)
-{
-}
-
-void EventsCollector::addEvent(const String& message)
-{
-    m_totalLength += message.length();
-    m_events.append(message);
-    while (m_totalLength > maxCapacity) {
-        m_totalLength -= m_events[0].length();
-        m_events.remove(0);
-    }
-}
-
-void EventsCollector::clear()
-{
-    m_events.clear();
-}
-
-void EventsCollector::sendCollectedEvents(InspectorFrontendChannel* receiver)
-{
-    for (Vector<String>::iterator it = m_events.begin(); it != m_events.end(); ++it)
-        receiver->sendMessageToFrontend(*it);
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(INSPECTOR)
diff --git a/Source/WebCore/inspector/EventsCollector.h b/Source/WebCore/inspector/EventsCollector.h
deleted file mode 100644 (file)
index e26e10b..0000000
+++ /dev/null
@@ -1,55 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- */
-
-#ifndef EventsCollector_h
-#define EventsCollector_h
-
-#if ENABLE(INSPECTOR)
-
-#include <wtf/Forward.h>
-#include <wtf/Vector.h>
-
-namespace WebCore {
-
-class InspectorFrontendChannel;
-
-class EventsCollector {
-public:
-    EventsCollector();
-    ~EventsCollector() { }
-    void addEvent(const String& message);
-    void clear();
-    void sendCollectedEvents(InspectorFrontendChannel*);
-private:
-    static const size_t maxCapacity = 1024*1024; // 1 Mb
-    size_t m_totalLength;
-    Vector<String> m_events;
-};
-
-} // namespace WebCore
-
-#endif // !defined(EventsCollector_h)
-
-#endif // ENABLE(INSPECTOR)
index 0a0febc..1b2cb37 100644 (file)
                 ]
             },
             {
-                "name": "setBackgroundEventsCollectionEnabled",
-                "description": "Toggles background network event collection.",
-                "parameters": [
-                    { "name": "enabled", "type": "boolean", "description": "true - enable collection, false - disable" }
-                ]
-            },
-            {
-                "name": "isBackgroundEventsCollectionEnabled",
-                "returns": [
-                    { "name": "enabled", "type": "boolean" }
-                ]
-            },
-            {
                 "name": "getResourceContent",
                 "description": "Returns content of the given resource.",
                 "parameters": [
                 "name": "resourceMarkedAsCached",
                 "description": "Fired when request is known to be served from disk cache.",
                 "parameters": [
-                    { "name": "requestId", "$ref": "RequestId", "description": "Request identifier." },
+                    { "name": "requestId", "$ref": "RequestId", "description": "Request identifier." }
                 ]
             },
             {
diff --git a/Source/WebCore/inspector/InspectorFrontendProxy.cpp b/Source/WebCore/inspector/InspectorFrontendProxy.cpp
deleted file mode 100644 (file)
index ba0562a..0000000
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "InspectorFrontendProxy.h"
-
-#if ENABLE(INSPECTOR)
-
-#include "EventsCollector.h"
-#include "PlatformString.h"
-
-namespace WebCore {
-
-InspectorFrontendProxy::InspectorFrontendProxy(EventsCollector* collector)
-{
-    m_receiver = 0;
-    m_collector = collector;
-}
-
-InspectorFrontendProxy::InspectorFrontendProxy(EventsCollector* collector, InspectorFrontendChannel* nextChannel)
-{
-    m_collector = collector;
-    m_receiver = nextChannel;
-}
-
-void InspectorFrontendProxy::setInspectorFrontendChannel(InspectorFrontendChannel* receiver)
-{
-    m_receiver = receiver;
-}
-
-InspectorFrontendChannel* InspectorFrontendProxy::inspectorFrontendChannel()
-{
-    return m_receiver;
-}
-
-void InspectorFrontendProxy::setEventsCollector(EventsCollector* collector)
-{
-    m_collector = collector;
-}
-
-bool InspectorFrontendProxy::sendMessageToFrontend(const String& message)
-{
-    m_collector->addEvent(message);
-    if (m_receiver)
-        return m_receiver->sendMessageToFrontend(message);
-    return false;
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(INSPECTOR)
diff --git a/Source/WebCore/inspector/InspectorFrontendProxy.h b/Source/WebCore/inspector/InspectorFrontendProxy.h
deleted file mode 100644 (file)
index 51f84e3..0000000
+++ /dev/null
@@ -1,58 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- */
-
-#ifndef InspectorFrontendProxy_h
-#define InspectorFrontendProxy_h
-
-#if ENABLE(INSPECTOR)
-
-#include "InspectorFrontendChannel.h"
-#include <wtf/Forward.h>
-
-namespace WebCore {
-
-class EventsCollector;
-
-class InspectorFrontendProxy : public InspectorFrontendChannel {
-public:
-    explicit InspectorFrontendProxy(EventsCollector*);
-    InspectorFrontendProxy(EventsCollector*, InspectorFrontendChannel* nextChannel);
-    virtual ~InspectorFrontendProxy() { }
-
-    void setInspectorFrontendChannel(InspectorFrontendChannel*);
-    InspectorFrontendChannel* inspectorFrontendChannel();
-    void setEventsCollector(EventsCollector*);
-    virtual bool sendMessageToFrontend(const String& message);
-
-private:
-    InspectorFrontendChannel* m_receiver;
-    EventsCollector* m_collector;
-};
-
-} // namespace WebCore
-
-#endif // ENABLE(INSPECTOR)
-
-#endif // !defined(InspectorFrontendProxy_h)
index cbfbd01..f808ef1 100644 (file)
 #include "CachedResourceLoader.h"
 #include "Document.h"
 #include "DocumentLoader.h"
-#include "EventsCollector.h"
 #include "Frame.h"
 #include "FrameLoader.h"
 #include "HTTPHeaderMap.h"
 #include "IdentifiersFactory.h"
 #include "InspectorClient.h"
 #include "InspectorFrontend.h"
-#include "InspectorFrontendChannel.h"
-#include "InspectorFrontendProxy.h"
 #include "InspectorPageAgent.h"
 #include "InspectorState.h"
 #include "InspectorValues.h"
@@ -75,33 +72,19 @@ namespace WebCore {
 namespace ResourceAgentState {
 static const char resourceAgentEnabled[] = "resourceAgentEnabled";
 static const char extraRequestHeaders[] = "extraRequestHeaders";
-static const char backgroundEventsCollectionEnabled[] = "backgroundEventsCollectionEnabled";
 static const char cacheDisabled[] = "cacheDisabled";
 }
 
 void InspectorResourceAgent::setFrontend(InspectorFrontend* frontend)
 {
     m_frontend = frontend->network();
-    if (isBackgroundEventsCollectionEnabled()) {
-        // Insert Message Proxy in receiver chain.
-        InspectorFrontendChannel* client = m_frontend->getInspectorFrontendChannel();
-        m_inspectorFrontendProxy->setInspectorFrontendChannel(client);
-        m_frontend->setInspectorFrontendChannel(m_inspectorFrontendProxy.get());
-        m_eventsCollector->sendCollectedEvents(client);
-    }
 }
 
 void InspectorResourceAgent::clearFrontend()
 {
-    if (isBackgroundEventsCollectionEnabled()) {
-        m_frontend = m_mockFrontend.get();
-        m_inspectorFrontendProxy->setInspectorFrontendChannel(0);
-        m_frontend->setInspectorFrontendChannel(m_inspectorFrontendProxy.get());
-    } else {
-        m_frontend = 0;
-        ErrorString error;
-        disable(&error);
-    }
+    m_frontend = 0;
+    ErrorString error;
+    disable(&error);
     m_userAgentOverride = "";
 }
 
@@ -448,37 +431,6 @@ void InspectorResourceAgent::didCloseWebSocket(unsigned long identifier)
 }
 #endif // ENABLE(WEB_SOCKETS)
 
-void InspectorResourceAgent::isBackgroundEventsCollectionEnabled(ErrorString*, bool* enabled)
-{
-    (*enabled) = isBackgroundEventsCollectionEnabled();
-}
-
-bool InspectorResourceAgent::isBackgroundEventsCollectionEnabled()
-{
-    return m_state->getBoolean(ResourceAgentState::backgroundEventsCollectionEnabled);
-}
-
-void InspectorResourceAgent::setBackgroundEventsCollectionEnabled(ErrorString*, bool enabled)
-{
-    if (enabled == isBackgroundEventsCollectionEnabled())
-        return;
-    if (enabled) {
-        if (!m_eventsCollector)
-            initializeBackgroundCollection();
-        // Insert Message Proxy in receiver chain.
-        ASSERT(m_frontend);
-        InspectorFrontendChannel* client = m_frontend->getInspectorFrontendChannel();
-        m_inspectorFrontendProxy->setInspectorFrontendChannel(client);
-        m_frontend->setInspectorFrontendChannel(m_inspectorFrontendProxy.get());
-    } else {
-        // Take out Message Proxy from receiver chain.
-        m_frontend->setInspectorFrontendChannel(m_inspectorFrontendProxy->inspectorFrontendChannel());
-        m_inspectorFrontendProxy->setInspectorFrontendChannel(0);
-        m_eventsCollector->clear();
-    }
-    return m_state->setBoolean(ResourceAgentState::backgroundEventsCollectionEnabled, enabled);
-}
-
 // called from Internals for layout test purposes.
 void InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize)
 {
@@ -514,14 +466,6 @@ void InspectorResourceAgent::setExtraHeaders(ErrorString*, PassRefPtr<InspectorO
     m_state->setObject(ResourceAgentState::extraRequestHeaders, headers);
 }
 
-void InspectorResourceAgent::initializeBackgroundCollection()
-{
-    m_eventsCollector = adoptPtr(new EventsCollector());
-    m_inspectorFrontendProxy = adoptPtr(new InspectorFrontendProxy(m_eventsCollector.get()));
-    // Create mock frontend, so we can collect network events.
-    m_mockFrontend = adoptPtr(new InspectorFrontend::Network(m_inspectorFrontendProxy.get()));
-}
-
 void InspectorResourceAgent::getResourceContent(ErrorString* errorString, const String& requestId, String* content, bool* base64Encoded)
 {
     NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);
@@ -578,17 +522,11 @@ InspectorResourceAgent::InspectorResourceAgent(InstrumentingAgents* instrumentin
     , m_pageAgent(pageAgent)
     , m_client(client)
     , m_state(state)
+    , m_frontend(0)
     , m_resourcesData(adoptPtr(new NetworkResourcesData()))
     , m_loadingXHRSynchronously(false)
     , m_isRecalculatingStyle(false)
 {
-    if (isBackgroundEventsCollectionEnabled()) {
-        initializeBackgroundCollection();
-        // Create mock frontend, so we can collect network events.
-        m_frontend = m_mockFrontend.get();
-        enable();
-    } else
-        m_frontend = 0;
 }
 
 } // namespace WebCore
index cfdeb9e..9378bbb 100644 (file)
@@ -48,12 +48,10 @@ namespace WebCore {
 class CachedResource;
 class Document;
 class DocumentLoader;
-class EventsCollector;
 class Frame;
 class InspectorArray;
 class InspectorClient;
 class InspectorFrontend;
-class InspectorFrontendProxy;
 class InspectorObject;
 class InspectorPageAgent;
 class InspectorState;
@@ -119,9 +117,6 @@ public:
     void didCloseWebSocket(unsigned long identifier);
 #endif
 
-    void isBackgroundEventsCollectionEnabled(ErrorString*, bool* enabled);
-    void setBackgroundEventsCollectionEnabled(ErrorString*, bool enabled);
-
     // called from Internals for layout test purposes.
     void setResourcesDataSizeLimitsFromInternals(int maximumResourcesContentSize, int maximumSingleResourceContentSize);
 
@@ -140,18 +135,13 @@ public:
 private:
     InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*, InspectorState*);
 
-    bool isBackgroundEventsCollectionEnabled();
     void enable();
-    void initializeBackgroundCollection();
 
     InstrumentingAgents* m_instrumentingAgents;
     InspectorPageAgent* m_pageAgent;
     InspectorClient* m_client;
     InspectorState* m_state;
     InspectorFrontend::Network* m_frontend;
-    OwnPtr<EventsCollector> m_eventsCollector;
-    OwnPtr<InspectorFrontendProxy> m_inspectorFrontendProxy;
-    OwnPtr<InspectorFrontend::Network> m_mockFrontend;
     String m_userAgentOverride;
     OwnPtr<NetworkResourcesData> m_resourcesData;
     bool m_loadingXHRSynchronously;
index c9bcf5f..82bb311 100644 (file)
 
 WebInspector.NetworkLogView = function(parent)
 {
-    function eventsCollectionEnabled(error, enabled)
-    {
-        this._backgroundCollectionEnabled = enabled;
-    }
-    NetworkAgent.isBackgroundEventsCollectionEnabled(eventsCollectionEnabled.bind(this));
-
     // FIXME: some of the styles should be loaded on demand by components that need them.
     var styles = [
         "inspectorCommon.css",
@@ -1065,12 +1059,6 @@ WebInspector.NetworkLogView.prototype = {
             NetworkAgent.clearBrowserCookies();
     },
 
-    _toggleBackgroundEventsCollection: function(resource)
-    {
-        this._backgroundCollectionEnabled = !this._backgroundCollectionEnabled;
-        NetworkAgent.setBackgroundEventsCollectionEnabled(this._backgroundCollectionEnabled);
-    },
-
     _updateOffscreenRows: function(e)
     {
         var dataTableBody = this._dataGrid.dataTableBody;