[Mac] tag the video layers with descriptive name to aid debugging
authoreric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Apr 2014 02:52:01 +0000 (02:52 +0000)
committereric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Apr 2014 02:52:01 +0000 (02:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=132371

Reviewed by Darin Adler.

Source/WebCore:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Set the AVPlayerLayer
    name in a debug build.

Source/WebKit2:
* WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): Set the
    fullscreen host layer name in a debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm

index 18bfb4b..2aa1c17 100644 (file)
@@ -1,3 +1,14 @@
+2014-04-29  Eric Carlson  <eric.carlson@apple.com>
+
+        [Mac] tag the video layers with descriptive name to aid debugging
+        https://bugs.webkit.org/show_bug.cgi?id=132371
+
+        Reviewed by Darin Adler.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Set the AVPlayerLayer
+            name in a debug build.
+
 2014-04-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
 
         [GTK][cmake] CMake variable (non)expansion causing 'File name too long' build error.
index ae7204a..5fd37c3 100644 (file)
@@ -534,7 +534,7 @@ void MediaPlayerPrivateAVFoundationObjC::createVideoLayer()
         [m_videoLayer.get() setPlayer:m_avPlayer.get()];
         [m_videoLayer.get() setBackgroundColor:cachedCGColor(Color::black, ColorSpaceDeviceRGB)];
 #ifndef NDEBUG
-        [m_videoLayer.get() setName:@"Video layer"];
+        [m_videoLayer.get() setName:@"MediaPlayerPrivate AVPlayerLayer"];
 #endif
         updateVideoLayerGravity();
         LOG(Media, "MediaPlayerPrivateAVFoundationObjC::createVideoLayer(%p) - returning %p", this, m_videoLayer.get());
index 7a33f9e..1caa9ba 100644 (file)
@@ -1,3 +1,14 @@
+2014-04-29  Eric Carlson  <eric.carlson@apple.com>
+
+        [Mac] tag the video layers with descriptive name to aid debugging
+        https://bugs.webkit.org/show_bug.cgi?id=132371
+
+        Reviewed by Darin Adler.
+
+        * WebProcess/ios/WebVideoFullscreenManager.mm:
+        (WebKit::WebVideoFullscreenManager::enterFullscreenForNode): Set the 
+            fullscreen host layer name in a debug build.
+
 2014-04-29  Brady Eidson  <beidson@apple.com>
 
         Handle selection services menu.
index b6b2803..f6c1a7b 100644 (file)
@@ -95,6 +95,9 @@ void WebVideoFullscreenManager::enterFullscreenForNode(Node* node)
     setMediaElement(toHTMLMediaElement(node));
 
     PlatformLayer* videoLayer = [CALayer layer];
+#ifndef NDEBUG
+    [videoLayer setName:@"Web video fullscreen manager layer"];
+#endif
     m_layerHostingContext = LayerHostingContext::createForExternalHostingProcess();
     m_layerHostingContext->setRootLayer(videoLayer);
     setVideoFullscreenLayer(videoLayer);