https://bugs.webkit.org/show_bug.cgi?id=184406
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Remove the protected default constructor, for good measure.
* platform/graphics/wayland/PlatformDisplayWayland.h:
Source/WebKit:
* WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::create): Fix a log message (drive-by).
(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay): Fix the leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2018-04-09 Michael Catanzaro <mcatanzaro@igalia.com>
+
+ [GTK] WaylandCompositorDisplay leaks its wl_display
+ https://bugs.webkit.org/show_bug.cgi?id=184406
+
+ Reviewed by Carlos Garcia Campos.
+
+ Remove the protected default constructor, for good measure.
+
+ * platform/graphics/wayland/PlatformDisplayWayland.h:
+
2018-04-08 Fujii Hironori <Hironori.Fujii@sony.com>
[CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
Type type() const override { return PlatformDisplay::Type::Wayland; }
protected:
- PlatformDisplayWayland() = default;
void initialize(struct wl_display*);
virtual void registryGlobal(const char* interface, uint32_t name);
+2018-04-09 Michael Catanzaro <mcatanzaro@igalia.com>
+
+ [GTK] WaylandCompositorDisplay leaks its wl_display
+ https://bugs.webkit.org/show_bug.cgi?id=184406
+
+ Reviewed by Carlos Garcia Campos.
+
+ * WebProcess/gtk/WaylandCompositorDisplay.cpp:
+ (WebKit::WaylandCompositorDisplay::create): Fix a log message (drive-by).
+ (WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay): Fix the leak.
+
2018-04-08 Zan Dobersek <zdobersek@igalia.com>
Non-Cocoa ports use default directory for ServiceWorker data during testing
struct wl_display* display = wl_display_connect(displayName.utf8().data());
if (!display) {
- WTFLogAlways("PlatformDisplayWayland initialization: failed to connect to the Wayland display: %s", displayName.utf8().data());
+ WTFLogAlways("WaylandCompositorDisplay initialization: failed to connect to the Wayland display: %s", displayName.utf8().data());
return nullptr;
}
}
WaylandCompositorDisplay::WaylandCompositorDisplay(struct wl_display* display)
+ : PlatformDisplayWayland(display, NativeDisplayOwned::Yes)
{
- initialize(display);
PlatformDisplay::setSharedDisplayForCompositing(*this);
}