Yellow highlight has gray background color when invoking Lookup on an address in...
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Apr 2015 23:13:01 +0000 (23:13 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Apr 2015 23:13:01 +0000 (23:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138737
<rdar://problem/18904429>

Reviewed by Simon Fraser.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
Other RenderObjects don't paint box decorations in the selection painting phase,
so RenderReplaced probably shouldn't either. This fixes the case where, when doing
selection-only painting of a bit of text over top of a RenderReplaced, the RenderReplaced
would paint its background, filling the previously transparent bitmap with an unwanted color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderReplaced.cpp

index 0a87fe3..63a71bb 100644 (file)
@@ -1,3 +1,18 @@
+2015-04-23  Tim Horton  <timothy_horton@apple.com>
+
+        Yellow highlight has gray background color when invoking Lookup on an address in a Google Maps drop down
+        https://bugs.webkit.org/show_bug.cgi?id=138737
+        <rdar://problem/18904429>
+
+        Reviewed by Simon Fraser.
+
+        * rendering/RenderReplaced.cpp:
+        (WebCore::RenderReplaced::paint):
+        Other RenderObjects don't paint box decorations in the selection painting phase,
+        so RenderReplaced probably shouldn't either. This fixes the case where, when doing
+        selection-only painting of a bit of text over top of a RenderReplaced, the RenderReplaced
+        would paint its background, filling the previously transparent bitmap with an unwanted color.
+
 2015-04-23  Roger Fong  <roger_fong@apple.com>
 
         Update media timeline controls when video is paused..
index bd88084..fed5b63 100644 (file)
@@ -142,7 +142,7 @@ void RenderReplaced::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
     
     LayoutPoint adjustedPaintOffset = paintOffset + location();
     
-    if (hasBoxDecorations() && (paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseSelection)) 
+    if (hasBoxDecorations() && paintInfo.phase == PaintPhaseForeground)
         paintBoxDecorations(paintInfo, adjustedPaintOffset);
     
     if (paintInfo.phase == PaintPhaseMask) {