Reviewed by Ken.
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Nov 2004 22:08:42 +0000 (22:08 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Nov 2004 22:08:42 +0000 (22:08 +0000)
        - fixed <rdar://problem/3880075> leak in CSSStyleDeclarationImpl::copyPropertiesInSet,
        seen often in Mail and Blot

        * khtml/css/css_valueimpl.cpp:
        (CSSStyleDeclarationImpl::copyPropertiesInSet):
        delete temporary list after we're done using it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/css/css_valueimpl.cpp

index e4cb015..694ac1b 100644 (file)
@@ -1,3 +1,14 @@
+2004-11-15  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Ken.
+        
+        - fixed <rdar://problem/3880075> leak in CSSStyleDeclarationImpl::copyPropertiesInSet, 
+        seen often in Mail and Blot
+
+        * khtml/css/css_valueimpl.cpp:
+        (CSSStyleDeclarationImpl::copyPropertiesInSet):
+        delete temporary list after we're done using it
+
 2004-11-15  Richard Williamson   <rjw@apple.com>
 
        Fixed leak (3879883) that John found.  Early return leaked
index 24765c2..1a942bb 100644 (file)
@@ -483,7 +483,9 @@ CSSStyleDeclarationImpl *CSSStyleDeclarationImpl::copyPropertiesInSet(const int
             list->append(property);
         }
     }
-    return new CSSStyleDeclarationImpl(0, list);
+    CSSStyleDeclarationImpl *result = new CSSStyleDeclarationImpl(0, list);
+    delete list;
+    return result;
 }
 
 // --------------------------------------------------------------------------------------