[macOS iOS ] animations/animation-direction-normal.html is flaky failing
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Mar 2020 15:59:03 +0000 (15:59 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Mar 2020 15:59:03 +0000 (15:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=206685
<rdar://problem/58841791>

Reviewed by Antti Koivisto.

To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time
at which we want to pause the animation (2.5s).

* animations/animation-direction-normal-expected.txt:
* animations/animation-direction-normal.html:
* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/animations/animation-direction-normal-expected.txt
LayoutTests/animations/animation-direction-normal.html
LayoutTests/platform/ios-wk2/TestExpectations
LayoutTests/platform/mac/TestExpectations

index 76b556b..3ef52ba 100644 (file)
@@ -1,3 +1,19 @@
+2020-03-18  Antoine Quint  <graouts@apple.com>
+
+        [macOS iOS ] animations/animation-direction-normal.html is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=206685
+        <rdar://problem/58841791>
+
+        Reviewed by Antti Koivisto.
+
+        To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time
+        at which we want to pause the animation (2.5s).
+
+        * animations/animation-direction-normal-expected.txt:
+        * animations/animation-direction-normal.html:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2020-03-18  Jason Lawrence  <lawrence.j@apple.com>
 
         [ iOS wk2 Release ] platform/ios/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width.html is flaky failing.
index 5d6eb7f..370dbcc 100644 (file)
@@ -1,4 +1,4 @@
-PASS - "webkitTransform" property for "box" element at 0.5s saw something close to: 1,0,0,1,50,0
-PASS - "webkitTransform" property for "box" element at 1s saw something close to: 1,0,0,1,100,0
-PASS - "webkitTransform" property for "box" element at 2.5s saw something close to: 1,0,0,1,50,0
+PASS - "margin-left" property for "box" element at 0.5s saw something close to: 50
+PASS - "margin-left" property for "box" element at 1s saw something close to: 100
+PASS - "margin-left" property for "box" element at 2.5s saw something close to: 50
 
index def7cb8..62f73b8 100644 (file)
@@ -30,8 +30,8 @@
       background-color: green;
     }
     @-webkit-keyframes "move1" {
-      from { -webkit-transform: translateX(0px); }
-      to   { -webkit-transform: translateX(200px); }
+      from { margin-left: 0px; }
+      to   { margin-left: 200px; }
     }
     #result {
       color: white; /* hide from pixel results */
   <script type="text/javascript" charset="utf-8">
     const expectedValues = [
       // [animation-name, time, element-id, property, expected-value, tolerance]
-      ["move1", 0.5, "box", "webkitTransform", [1,0,0,1, 50,0], 20],
-      ["move1", 1.0, "box", "webkitTransform", [1,0,0,1,100,0], 20],
-      ["move1", 2.5, "box", "webkitTransform", [1,0,0,1, 50,0], 20],
+      ["move1", 0.5, "box", "margin-left", 50, 20],
+      ["move1", 1.0, "box", "margin-left", 100, 20],
+      ["move1", 2.5, "box", "margin-left", 50, 20],
     ];
 
     function pauseAnimation()
     {
-        document.getElementById("box").style.webkitAnimationPlayState = "paused";
+        const box = document.getElementById("box");
+        box.style.webkitAnimationPlayState = "paused";
+        box.getAnimations()[0].currentTime = 2500;
     }
 
     function setTimers()
index 7b1d08b..566c471 100644 (file)
@@ -1318,8 +1318,6 @@ webkit.org/b/206616 [ Release ] http/tests/security/contentSecurityPolicy/module
 
 webkit.org/b/206630 [ Release ] fast/forms/validationMessage.html [ Pass Timeout ]
 
-webkit.org/b/206685 [ Debug ] animations/animation-direction-normal.html [ Pass Failure ]
-
 webkit.org/b/206687 imported/w3c/web-platform-tests/beacon/idlharness.any.html [ Pass Timeout ]
 
 webkit.org/b/206752 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]
index 784c923..9f8145f 100644 (file)
@@ -1911,8 +1911,6 @@ webkit.org/b/77568 [ Sierra HighSierra Mojave Catalina ] fast/text/locale-shapin
 
 webkit.org/b/203222 svg/wicd/rightsizing-grid.xhtml [ Pass Failure ]
 
-webkit.org/b/206685 animations/animation-direction-normal.html [ Pass Failure ]
-
 webkit.org/b/206711 http/wpt/resource-timing/rt-resource-errors.html [ Pass Failure ]
 
 webkit.org/b/206752 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]