Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
authorch.dumez@sisa.samsung.com <ch.dumez@sisa.samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jun 2013 12:25:41 +0000 (12:25 +0000)
committerch.dumez@sisa.samsung.com <ch.dumez@sisa.samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jun 2013 12:25:41 +0000 (12:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=117531

Reviewed by Kentaro Hara.

Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.

Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.

No new tests, no behavior change.

* Modules/filesystem/FileWriter.idl:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/notifications/Notification.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechSynthesisUtterance.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* dom/MessageChannel.idl:
* fileapi/FileReader.idl:
* html/MediaController.idl:
* html/track/TextTrackCue.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22 files changed:
Source/WebCore/ChangeLog
Source/WebCore/Modules/filesystem/FileWriter.idl
Source/WebCore/Modules/mediasource/MediaSource.idl
Source/WebCore/Modules/mediasource/SourceBufferList.idl
Source/WebCore/Modules/mediastream/MediaStream.idl
Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
Source/WebCore/Modules/notifications/Notification.idl
Source/WebCore/Modules/speech/SpeechRecognition.idl
Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl
Source/WebCore/Modules/webaudio/OfflineAudioContext.idl
Source/WebCore/Modules/websockets/WebSocket.idl
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/bindings/scripts/IDLAttributes.txt
Source/WebCore/bindings/scripts/test/TestInterface.idl
Source/WebCore/dom/MessageChannel.idl
Source/WebCore/fileapi/FileReader.idl
Source/WebCore/html/MediaController.idl
Source/WebCore/html/track/TextTrackCue.idl
Source/WebCore/page/EventSource.idl
Source/WebCore/workers/SharedWorker.idl
Source/WebCore/workers/Worker.idl
Source/WebCore/xml/XMLHttpRequest.idl

index 6440f77..c994970 100644 (file)
@@ -1,3 +1,43 @@
+2013-06-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
+        https://bugs.webkit.org/show_bug.cgi?id=117531
+
+        Reviewed by Kentaro Hara.
+
+        Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
+        meaning is slightly different when [CallWith] is used for IDL operations
+        or attributes. This improves IDL readability a bit and makes it more
+        directly understandable.
+
+        Also removed [ConstructorCallWith] statements from interfaces with custom
+        constructors or no constructor, as this does not have any effect.
+
+        No new tests, no behavior change.
+
+        * Modules/filesystem/FileWriter.idl:
+        * Modules/mediasource/MediaSource.idl:
+        * Modules/mediasource/SourceBufferList.idl:
+        * Modules/mediastream/MediaStream.idl:
+        * Modules/mediastream/RTCPeerConnection.idl:
+        * Modules/notifications/Notification.idl:
+        * Modules/speech/SpeechRecognition.idl:
+        * Modules/speech/SpeechSynthesisUtterance.idl:
+        * Modules/webaudio/OfflineAudioContext.idl:
+        * Modules/websockets/WebSocket.idl:
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorDefinition):
+        * bindings/scripts/IDLAttributes.txt:
+        * bindings/scripts/test/TestInterface.idl:
+        * dom/MessageChannel.idl:
+        * fileapi/FileReader.idl:
+        * html/MediaController.idl:
+        * html/track/TextTrackCue.idl:
+        * page/EventSource.idl:
+        * workers/SharedWorker.idl:
+        * workers/Worker.idl:
+        * xml/XMLHttpRequest.idl:
+
 2013-06-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 
         [Qt] Set windows key-code for multimedia keys
index 9de6166..c50d3c1 100644 (file)
@@ -33,7 +33,6 @@
     NoInterfaceObject,
     Conditional=FILE_SYSTEM,
     ActiveDOMObject,
-    CallWith=ScriptExecutionContext,
     EventTarget,
     JSNoStaticTables
 ] interface FileWriter {
index 725ff90..7b04347 100644 (file)
@@ -33,7 +33,7 @@
     ActiveDOMObject,
     EventTarget,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     InterfaceName=WebKitMediaSource
 ] interface MediaSource {
     // All the source buffers created by this object.
index ae83d27..04132dc 100644 (file)
@@ -32,7 +32,6 @@
     Conditional=MEDIA_SOURCE,
     IndexedGetter,
     EventTarget,
-    CallWith=ScriptExecutionContext,
     InterfaceName=WebKitSourceBufferList
 ] interface SourceBufferList {
     readonly attribute unsigned long length;
index 3b52801..ba1dc63 100644 (file)
@@ -28,7 +28,7 @@
     Constructor,
     Constructor(MediaStream stream),
     Constructor(MediaStreamTrack[] tracks),
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     SkipVTableValidation,
     InterfaceName=webkitMediaStream
 ] interface MediaStream {
index 9021af5..98466fc 100644 (file)
@@ -33,7 +33,7 @@
     ActiveDOMObject,
     Constructor(Dictionary rtcIceServers, optional Dictionary mediaConstraints),
     ConstructorRaisesException,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
     InterfaceName=webkitRTCPeerConnection
 ] interface RTCPeerConnection {
index 0e7bdd1..572e96b 100644 (file)
@@ -35,7 +35,7 @@
     EventTarget,
 #if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS
     Constructor(DOMString title, [Default=Undefined] optional Dictionary options),
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
 #else
 #endif
 ] interface Notification {
index 27f0eb0..371acf5 100644 (file)
@@ -27,7 +27,7 @@
     Conditional=SCRIPTED_SPEECH,
     ActiveDOMObject,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
     InterfaceName=webkitSpeechRecognition
 ] interface SpeechRecognition {
index f42ca61..e82da42 100644 (file)
@@ -26,7 +26,7 @@
 [
     Conditional=SPEECH_SYNTHESIS,
     EventTarget,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     Constructor([Default=NullString] optional DOMString text)
 ] interface SpeechSynthesisUtterance {
     attribute DOMString text;
index ebf0cdb..e4ecd5d 100644 (file)
@@ -28,7 +28,7 @@
     JSGenerateToJSObject,
     Constructor(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate),
     ConstructorRaisesException,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     InterfaceName=webkitOfflineAudioContext
 ] interface OfflineAudioContext : AudioContext {
 
index 8d2b721..4bd6272 100644 (file)
@@ -38,7 +38,7 @@
     Constructor(DOMString url, sequence<DOMString> protocols),
     Constructor(DOMString url, DOMString protocol),
     ConstructorRaisesException,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
     JSNoStaticTables,
 ] interface WebSocket {
index 6b5d033..5b5100b 100644 (file)
@@ -4175,7 +4175,7 @@ END
             my $numParameters = @{$function->parameters};
             my ($dummy, $paramIndex) = GenerateParametersCheck($outputArray, $function, $interface, $numParameters, $interfaceName, "constructorCallback", undef, undef, undef);
 
-            if ($codeGenerator->ExtendedAttributeContains($interface->extendedAttributes->{"CallWith"}, "ScriptExecutionContext")) {
+            if ($codeGenerator->ExtendedAttributeContains($interface->extendedAttributes->{"ConstructorCallWith"}, "ScriptExecutionContext")) {
                 push(@constructorArgList, "context");
                 push(@$outputArray, "    ScriptExecutionContext* context = castedThis->scriptExecutionContext();\n");
                 push(@$outputArray, "    if (!context)\n");
index 974dee4..c4e2c8a 100644 (file)
@@ -27,6 +27,7 @@ CheckSecurityForNode
 Clamp
 Conditional=*
 Constructor
+ConstructorCallWith=ScriptExecutionContext
 ConstructorConditional=*
 ConstructorRaisesException
 ConstructorTemplate=Event|TypedArray
index ae4dbd0..933796d 100644 (file)
@@ -32,7 +32,7 @@
     ActiveDOMObject,
     CustomNamedSetter,
     Conditional=Condition1|Condition2,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     Constructor(DOMString str1, [Default=Undefined] optional DOMString str2),
     ConstructorRaisesException,
     ConstructorConditional=TEST_INTERFACE,
index dd5fd86..02243c5 100644 (file)
@@ -28,7 +28,7 @@
     GlobalContext=WindowAndWorker,
     Conditional=CHANNEL_MESSAGING,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     JSCustomMarkFunction,
     JSNoStaticTables,
     ImplementationLacksVTable
index 037224c..3df36ba 100644 (file)
@@ -34,7 +34,7 @@
     Conditional=BLOB,
     ActiveDOMObject,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
     JSNoStaticTables
 ] interface FileReader {
index 59bc125..26e6650 100644 (file)
@@ -26,7 +26,7 @@
 [
     Conditional=VIDEO,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     JSGenerateToJSObject,
     EventTarget
 ] interface MediaController {
index 6167e24..92e0e41 100644 (file)
@@ -27,7 +27,7 @@
     Conditional=VIDEO_TRACK,
     JSGenerateToNativeObject,
     Constructor(double startTime, double endTime, DOMString text),
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
     JSCustomMarkFunction,
     CustomIsReachable,
index 185f4fd..04c76c5 100644 (file)
@@ -33,7 +33,7 @@
     GlobalContext=WindowAndWorker,
     ActiveDOMObject,
     Constructor(DOMString url, optional Dictionary eventSourceInit),
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     ConstructorRaisesException,
     EventTarget,
     JSNoStaticTables
index 07ece45..97c8d9b 100644 (file)
@@ -33,8 +33,6 @@
     EnabledAtRuntime,
     Conditional=SHARED_WORKERS,
     CustomConstructor(DOMString scriptURL, [Default=NullString] optional DOMString name),
-    CallWith=ScriptExecutionContext,
-    ConstructorRaisesException,
     JSCustomMarkFunction,
     JSGenerateToNativeObject,
     JSGenerateToJSObject
index 136dab5..1cb44f7 100644 (file)
@@ -28,8 +28,6 @@
 [
     Conditional=WORKERS,
     CustomConstructor(DOMString scriptUrl),
-    CallWith=ScriptExecutionContext,
-    ConstructorRaisesException,
     JSGenerateToNativeObject,
     JSGenerateToJSObject
 ] interface Worker : AbstractWorker {
index c6d6599..ba17ada 100644 (file)
@@ -40,7 +40,7 @@ enum XMLHttpRequestResponseType {
     GlobalContext=WindowAndWorker,
     ActiveDOMObject,
     Constructor,
-    CallWith=ScriptExecutionContext,
+    ConstructorCallWith=ScriptExecutionContext,
     JSCustomMarkFunction,
     EventTarget,
     JSNoStaticTables