[CSS Grid Layout] Enable runtime feature by default
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Apr 2014 08:54:39 +0000 (08:54 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Apr 2014 08:54:39 +0000 (08:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=132189

Reviewed by Benjamin Poulain.

Source/WebCore:
* page/Settings.in: Set cssGridLayoutEnabled to true.

Source/WebKit/mac:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Remove unneeded changes that
enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.

Source/WebKit2:
* Shared/WebPreferencesStore.h: Remove unneeded changes that
enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.
* UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Settings.in
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebPreferences.mm
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesStore.h
Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp

index 26a21e3..32bd059 100644 (file)
@@ -1,5 +1,14 @@
 2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
 
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * page/Settings.in: Set cssGridLayoutEnabled to true.
+
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
         [CSS Grid Layout] Wrap some specific grid code under compilation flag
         https://bugs.webkit.org/show_bug.cgi?id=132341
 
index 8427193..8dbfafc 100644 (file)
@@ -85,7 +85,7 @@ canvasUsesAcceleratedDrawing initial=false
 acceleratedDrawingEnabled initial=false
 acceleratedFiltersEnabled initial=false
 regionBasedColumnsEnabled initial=false
-cssGridLayoutEnabled initial=false
+cssGridLayoutEnabled initial=true
 useLegacyTextAlignPositionedElementBehavior initial=false
 
 # FIXME: This should really be disabled by default as it makes platforms that don't support the feature download files
index 04a275d..048b69a 100644 (file)
@@ -1,3 +1,15 @@
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]): Remove unneeded changes that
+        enable/disable the runtime feature depending on the compilation flag.
+        And set it to true by default.
+
 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
 
         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
index 723be65..22e7454 100644 (file)
@@ -482,11 +482,7 @@ public:
         [NSNumber numberWithBool:YES],  WebKitAcceleratedCompositingEnabledPreferenceKey,
         [NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
         [NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
-#if ENABLE(CSS_GRID_LAYOUT)
         [NSNumber numberWithBool:YES],  WebKitCSSGridLayoutEnabledPreferenceKey,
-#else
-        [NSNumber numberWithBool:NO],  WebKitCSSGridLayoutEnabledPreferenceKey,
-#endif
 #if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
         [NSNumber numberWithBool:YES],  WebKitAcceleratedDrawingEnabledPreferenceKey,
         [NSNumber numberWithBool:YES],  WebKitCanvasUsesAcceleratedDrawingPreferenceKey,
index 1e0f09c..7d5b034 100644 (file)
@@ -1,3 +1,15 @@
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * Shared/WebPreferencesStore.h: Remove unneeded changes that
+        enable/disable the runtime feature depending on the compilation flag.
+        And set it to true by default.
+        * UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.
+
 2014-04-30  Roger Fong  <roger_fong@apple.com>
 
         Unreviewed. Wrong units used in offset calculation from r167961.
index b9e15de..dd72638 100644 (file)
@@ -100,12 +100,6 @@ namespace WebKit {
 #define DEFAULT_CANVAS_USES_ACCELERATED_DRAWING true
 #endif
 
-#if ENABLE(CSS_GRID_LAYOUT)
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED true
-#else
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED false
-#endif
-
 #define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \
     macro(JavaScriptEnabled, javaScriptEnabled, Bool, bool, true) \
     macro(JavaScriptMarkupEnabled, javaScriptMarkupEnabled, Bool, bool, true) \
@@ -139,7 +133,7 @@ namespace WebKit {
     macro(Accelerated2dCanvasEnabled, accelerated2dCanvasEnabled, Bool, bool, false) \
     macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true) \
     macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true) \
-    macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, DEFAULT_CSS_GRID_LAYOUT_ENABLED) \
+    macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true) \
     macro(RegionBasedColumnsEnabled, regionBasedColumnsEnabled, Bool, bool, false) \
     macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \
     macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED) \
index 1b69302..0de7a22 100644 (file)
@@ -39,7 +39,7 @@ struct Setting {
 };
 
 static Setting settings[] = {
-    { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", false },
+    { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", true },
     { ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
 };