transforms/no_transform_hit_testing.html is flaky
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Apr 2012 23:46:20 +0000 (23:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Apr 2012 23:46:20 +0000 (23:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=82415

Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.

Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.

* platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
* transforms/no_transform_hit_testing-expected.txt: Added.
* transforms/no_transform_hit_testing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/chromium-linux/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/chromium-mac/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/platform/gtk/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/platform/mac-leopard/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/platform/qt-mac/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.png [deleted file]
LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt [deleted file]
LayoutTests/transforms/no_transform_hit_testing-expected.txt [new file with mode: 0644]
LayoutTests/transforms/no_transform_hit_testing.html

index 2239b5f..521f704 100644 (file)
@@ -1,3 +1,31 @@
+2012-04-19  Florin Malita  <fmalita@google.com>
+
+        transforms/no_transform_hit_testing.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=82415
+
+        Reviewed by Simon Fraser.
+
+        Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.
+
+        * platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * platform/chromium/test_expectations.txt:
+        * platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
+        * platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
+        * transforms/no_transform_hit_testing-expected.txt: Added.
+        * transforms/no_transform_hit_testing.html:
+
 2012-04-19  James Robinson  <jamesr@chromium.org>
 
         [chromium] Unreviewed, update chromium expectations for various compositing layout tests
diff --git a/LayoutTests/platform/chromium-linux/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/chromium-linux/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index f0e4e86..0000000
Binary files a/LayoutTests/platform/chromium-linux/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index 4649e63..0000000
Binary files a/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index 72a9f13..0000000
Binary files a/LayoutTests/platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/chromium-mac/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index 4649e63..0000000
Binary files a/LayoutTests/platform/chromium-mac/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index e0c91ca..0000000
Binary files a/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index 8635caa..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x37
-        RenderText {#text} at (0,0) size 616x36
-          text run at (0,0) width 616: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,58) size 784x20
-        RenderText {#text} at (0,0) size 291x19
-          text run at (0,0) width 291: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 122x19
-      text run at (0,0) width 122: "transformed element"
-layer at (8,216) size 27x20
-  RenderBlock (positioned) {P} at (8,216) size 27x20
-    RenderText {#text} at (0,0) size 27x19
-      text run at (0,0) width 27: "pass"
index ac0b0dd..66d996a 100644 (file)
@@ -3626,8 +3626,6 @@ BUGWK82409 LINUX RELEASE : inspector/styles/css-live-edit.html = PASS TIMEOUT
 BUGWK82410 : css2.1/20110323/abspos-containing-block-initial-004b.htm = PASS IMAGE
 BUGWK82410 : css2.1/20110323/abspos-containing-block-initial-004d.htm = PASS IMAGE
 
-BUGWK82415 : transforms/no_transform_hit_testing.html = PASS IMAGE
-
 BUGWK82413 LINUX : fast/filesystem/workers/async-operations.html = PASS TIMEOUT
 BUGWK82413 MAC DEBUG : fast/filesystem/workers/async-operations.html = PASS TIMEOUT
 
diff --git a/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index 9c55364..0000000
Binary files a/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index fc90435..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x37
-        RenderText {#text} at (0,0) size 616x36
-          text run at (0,0) width 616: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,58) size 784x19
-        RenderText {#text} at (0,0) size 305x19
-          text run at (0,0) width 305: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 128x19
-      text run at (0,0) width 128: "transformed element"
-layer at (8,216) size 27x19
-  RenderBlock (positioned) {P} at (8,216) size 27x19
-    RenderText {#text} at (0,0) size 27x19
-      text run at (0,0) width 27: "pass"
diff --git a/LayoutTests/platform/gtk/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/gtk/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index c7b4a72..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x37
-        RenderText {#text} at (0,0) size 615x36
-          text run at (0,0) width 615: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,58) size 784x18
-        RenderText {#text} at (0,0) size 310x17
-          text run at (0,0) width 310: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 132x17
-      text run at (0,0) width 132: "transformed element"
-layer at (8,216) size 28x18
-  RenderBlock (positioned) {P} at (8,216) size 28x18
-    RenderText {#text} at (0,0) size 28x17
-      text run at (0,0) width 28: "pass"
diff --git a/LayoutTests/platform/mac-leopard/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/mac-leopard/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index 70709e6..0000000
Binary files a/LayoutTests/platform/mac-leopard/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index d698bde..0000000
Binary files a/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index 963bb31..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x37
-        RenderText {#text} at (0,0) size 616x37
-          text run at (0,0) width 616: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,58) size 784x18
-        RenderText {#text} at (0,0) size 305x18
-          text run at (0,0) width 305: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 128x18
-      text run at (0,0) width 128: "transformed element"
-layer at (8,216) size 27x18
-  RenderBlock (positioned) {P} at (8,216) size 27x18
-    RenderText {#text} at (0,0) size 27x18
-      text run at (0,0) width 27: "pass"
diff --git a/LayoutTests/platform/qt-mac/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/qt-mac/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index ca360bf..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x37
-        RenderText {#text} at (0,0) size 616x36
-          text run at (0,0) width 616: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,58) size 784x18
-        RenderText {#text} at (0,0) size 305x17
-          text run at (0,0) width 305: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 128x17
-      text run at (0,0) width 128: "transformed element"
-layer at (8,216) size 27x18
-  RenderBlock (positioned) {P} at (8,216) size 27x18
-    RenderText {#text} at (0,0) size 27x17
-      text run at (0,0) width 27: "pass"
diff --git a/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.png b/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.png
deleted file mode 100644 (file)
index f83a29c..0000000
Binary files a/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt
deleted file mode 100644 (file)
index 0815a3c..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {H1} at (0,0) size 784x42
-        RenderText {#text} at (0,0) size 683x42
-          text run at (0,0) width 683: "Testing hittest on a layer with null transform"
-      RenderBlock {P} at (0,63) size 784x21
-        RenderText {#text} at (0,0) size 337x21
-          text run at (0,0) width 337: "https://bugs.webkit.org/show_bug.cgi?id=24252"
-layer at (20,96) size 400x100
-  RenderBlock (positioned) {P} at (20,96) size 400x100 [bgcolor=#DDDDFF]
-    RenderText {#text} at (0,0) size 145x21
-      text run at (0,0) width 145: "transformed element"
-layer at (8,216) size 34x21
-  RenderBlock (positioned) {P} at (8,216) size 34x21
-    RenderText {#text} at (0,0) size 34x21
-      text run at (0,0) width 34: "pass"
diff --git a/LayoutTests/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/transforms/no_transform_hit_testing-expected.txt
new file mode 100644 (file)
index 0000000..ddca942
--- /dev/null
@@ -0,0 +1,6 @@
+Testing hittest on a layer with null transform
+
+https://bugs.webkit.org/show_bug.cgi?id=24252
+
+transformed element
+Pass.
index 0434b5b..57a506a 100644 (file)
        var results = document.getElementById("results");
 
        if (x.id == "x") {
-         results.innerText = "pass";
+         results.innerText = "Pass.";
        }
+
+       if (window.layoutTestController)
+         layoutTestController.dumpAsText();
      }
 
   </script>
@@ -39,8 +42,8 @@
   <h1>Testing hittest on a layer with null transform</h1>
   <p>https://bugs.webkit.org/show_bug.cgi?id=24252</p>
 
-  <p id="x">transformed element</p>
+  <p id="x">transformed element</p><br>
   
-  <p id="results">fail</p>
+  <p id="results">Fail!</p>
 </body>
 </html>